From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.322.1621354205323275239 for ; Tue, 18 May 2021 09:10:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.net header.s=2017 header.b=dsrOX0fI; spf=pass (domain: posteo.net, ip: 185.67.36.65, mailfrom: sergei@posteo.net) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9D21A24002A for ; Tue, 18 May 2021 18:09:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621354193; bh=zJgp3TFWQo5ElBYMbza3GqsCwqc0tzEi9sbsIQ42c7M=; h=From:To:Cc:Subject:Date:From; b=dsrOX0fIY2MoGI1qqSE0vFvwFq5maDDSoca3jpfXiYHma1czKvyVyJN1QCjR4CxUT LRrQvoEcLUVqhTLvygAAOIXPiXD1ffPsA5hll5flcGk2n+A/n/TvEqpJ18zmMrQWJc PZWjVJqBzJfPXhkTHyLiyGIrgIDl8ZpfEtqixvGRnQFHsiTwt2eSLh4807TBSLHnrV lQJ7ODMwY7sOZ19M3ME2HrWfTtkoygjTv/IZMSOkYG7lyK2ss4HosowWsu8olvDI7a gvv6IIZddL9kOexmyWWRa32JgYLlMtlYgaLAUm3w4vEWmEJ4W23zMv8yYLrDSvzpqS wZlj/l7ku+nLg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl1DJ4fvgz9rxL; Tue, 18 May 2021 18:09:52 +0200 (CEST) From: "Sergei Dmitrouk" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang Subject: [PATCH v2 3/3] CryptoPkg/BaseCryptLib: Fix possible uninitialized use Date: Tue, 18 May 2021 16:09:42 +0000 Message-Id: <20210518160942.17634-4-sergei@posteo.net> In-Reply-To: <20210518160942.17634-1-sergei@posteo.net> References: <20210518160942.17634-1-sergei@posteo.net> `Result` can be used uninitialized in both functions after following either first or second `goto` statement. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Sergei Dmitrouk --- CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c | 1 + CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c | 1 + 2 files changed, 2 insertions(+) diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c index 4009d37d5f91..0b2960f06c4c 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c @@ -82,6 +82,7 @@ RsaPssVerify ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; + Result = FALSE; EvpRsaKey = NULL; EvpVerifyCtx = NULL; KeyCtx = NULL; diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c index b66b6f7296ad..ece765f9ae0a 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPssSign.c @@ -97,6 +97,7 @@ RsaPssSign ( EVP_PKEY_CTX *KeyCtx; CONST EVP_MD *HashAlg; + Result = FALSE; EvpRsaKey = NULL; EvpVerifyCtx = NULL; KeyCtx = NULL; -- 2.17.6