From: "Marcin Wojtas" <mw@semihalf.com>
To: devel@edk2.groups.io
Cc: liming.gao@intel.com, michael.d.kinney@intel.com,
leif@nuviainc.com, ardb+tianocore@kernel.org,
Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com,
gjb@semihalf.com, upstream@semihalf.com,
Marcin Wojtas <mw@semihalf.com>
Subject: [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
Date: Sun, 23 May 2021 11:15:12 +0200 [thread overview]
Message-ID: <20210523091512.2348586-1-mw@semihalf.com> (raw)
The Microsoft Debug Port Table 2 (DBG2) specification revision
May 31, 2017 adds support for 16550-compatible Serial Port
Subtype with parameters defined in Generic Address Structure (GAS) [1]
Reflect that in the EDK2 headers.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
index 3faa30b76a..9ccfc1b1ee 100644
--- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
+++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
@@ -47,6 +47,7 @@ typedef struct {
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010
+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012
#define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001
#define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000
#define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002
diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index 2066c7895e..7796796afe 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -100,6 +100,11 @@ typedef struct {
///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
+///
+/// 16550-compatible with parameters defined in Generic Address Structure
+///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12
+
//
// Interrupt Type
//
--
2.29.0
next reply other threads:[~2021-05-23 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 9:15 Marcin Wojtas [this message]
2021-05-24 2:09 ` [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 Sunny Wang
2021-05-24 2:21 ` Marcin Wojtas
2021-05-24 3:20 ` Sunny Wang
2021-05-24 8:42 ` 回复: " gaoliming
2021-05-24 8:50 ` Marcin Wojtas
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
2021-06-01 1:27 ` 回复: " gaoliming
[not found] ` <168451009D6DDB30.28811@groups.io>
2021-06-02 5:55 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523091512.2348586-1-mw@semihalf.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox