From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mx.groups.io with SMTP id smtpd.web12.19101.1621834175452641485 for ; Sun, 23 May 2021 22:29:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=x7t22stB; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.208.178, mailfrom: mw@semihalf.com) Received: by mail-lj1-f178.google.com with SMTP id a4so17128676ljd.5 for ; Sun, 23 May 2021 22:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ak4reBxjMMQzieRP0Y1lP6I3N7dl6U0lCZnPpIynDQE=; b=x7t22stBqDBbzWo94Z/04xN7HSrsMnEL1bRPhVqPSRcvGPiwj4MSWhtQFZzdxsONta dr2eg8Xj7/iVWY5nHpIX1YDSSt6uwrzOSDkOyHve11t+e6ymJII2XeZI7EfBb2ycX5BO IarMdkuY0I5N/3/3IMdu3aGlljmO+3SECHR1A7ZbI0L+zZxsQdKKVlnPlyBf+tzkPV/T M3Ht3Pi0xWDzIpRelp4piWctDNju9xO7YUcN1J/qkwGgE+UgsJEDKfIegUSJMNSGRRtH oUI9kQbvMuG8UaYA7J+o0tR35OcIqe+EyVAt9uovDCkVZDKr+dPo2LyHRbqQhQ8UwzTd 6NTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ak4reBxjMMQzieRP0Y1lP6I3N7dl6U0lCZnPpIynDQE=; b=fEOVsPs5G9XNhIyJMMYe47QqsWfVjwv1g/QOKTbLvnKBsBemZ7sMWNxFMRmRwPXDpz EVaJeQnXgBDyDo4X9JUZmF8DnN+BRpabAe150VVd+2bKZ4xXJMRwGVJnQg2pQ83kW9+a u4z6VMOJCJMHGpppipsWVBwmByIG5Z/qd0cDy6JKE7+bXo5vngMEPCtcHLBuUK9aQ9Nf k+taDw6LSnVvs3B7tUVALDLhMxmiatyYaqbKUfAmtSIZv/LQixmQrCjHDOjo7f7O+jrJ dSlND+pyNICPZo/5cjZ431Zp+cFsBJ9BhxEsJ/LNMpZxLACdAsOjmaGm8EIyNFiX9YoK 9Jsw== X-Gm-Message-State: AOAM5321sh8TsgsAxEsmyJf3sA8org2Ha1Og5uyRhPJjdJR8ievqjnSV RDGncpngdawkBpXy8lVIeYYhCiENzHqw59UC X-Google-Smtp-Source: ABdhPJyV/ra0e4ivfcxOpICeN0f8+BSJyVsMtZC31yC47dJlWHkFPfvlhfMdhKfAY04/GYxz+Vm6jw== X-Received: by 2002:a2e:9a90:: with SMTP id p16mr15773621lji.7.1621834173767; Sun, 23 May 2021 22:29:33 -0700 (PDT) Return-Path: Received: from gilgamesh.semihalf.com (host-193.106.246.138.static.3s.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id w17sm90739lfp.300.2021.05.23.22.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 22:29:33 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: leif@nuviainc.com, ardb+tianocore@kernel.org, Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com, gjb@semihalf.com, upstream@semihalf.com, Marcin Wojtas Subject: [edk2-platforms PATCH 1/6] Marvell/Drivers: SmbiosPlatformDxe: Align Type17 to SMBIOS v3.2 Date: Mon, 24 May 2021 07:29:14 +0200 Message-Id: <20210524052919.2496579-2-mw@semihalf.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210524052919.2496579-1-mw@semihalf.com> References: <20210524052919.2496579-1-mw@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This patch adds missing entries required for SMBIOS v3.2 compliance of the Type17 table. On the occasion improve Type4 table contents. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 39 +++++++= +++++++++++-- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c = b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c index 2ecaec2af5..a99291e902 100644 --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -181,7 +181,7 @@ STATIC SMBIOS_TABLE_TYPE4 mArmadaDefaultType4 =3D { 3, //version=0D {0,0,0,0,0,1}, //voltage=0D 0, //external clock=0D - 2000, //max speed=0D + 2200, //max speed=0D 0, //current speed - requires update=0D 0x41, //status=0D ProcessorUpgradeOther,=0D @@ -196,6 +196,9 @@ STATIC SMBIOS_TABLE_TYPE4 mArmadaDefaultType4 =3D { 4, //threads per socket=0D 0xEC, //processor characteristics=0D ProcessorFamilyARM, //ARM core=0D + 0, // CoreCount2;=0D + 0, // EnabledCoreCount2;=0D + 0, // ThreadCount2;=0D };=0D =0D STATIC CHAR8 CONST *mArmadaDefaultType4Strings[] =3D {=0D @@ -457,7 +460,7 @@ STATIC SMBIOS_TABLE_TYPE17 mArmadaDefaultType17 =3D { 0, //Memory size obtained dynamically=0D MemoryFormFactorRowOfChips, //Memory factor=0D 0, //Not part of a set=0D - 1, //Right side of board=0D + 1, //Location=0D 2, //Bank 0=0D MemoryTypeDdr4, //DDR4=0D {0,0,0,0,0,0,0,0,0,0,0,0,0,0,1}, //unbuffered=0D @@ -467,10 +470,36 @@ STATIC SMBIOS_TABLE_TYPE17 mArmadaDefaultType17 =3D { 0, //asset tag=0D 0, //part number=0D 0, //rank=0D + 0, // ExtendedSize; (since Size < 32GB-1)=0D + 0, // ConfiguredMemoryClockSpeed - initialized at runtime=0D + 0, // MinimumVoltage; (unknown)=0D + 0, // MaximumVoltage; (unknown)=0D + 0, // ConfiguredVoltage; (unknown)=0D + MemoryTechnologyDram, // MemoryTechnology=0D + {{ // MemoryOperatingModeCapability=0D + 0, // Reserved :1;=0D + 0, // Other :1;=0D + 0, // Unknown :1;=0D + 1, // VolatileMemory :1;=0D + 0, // ByteAccessiblePersistentMemory :1;=0D + 0, // BlockAccessiblePersistentMemory :1;=0D + 0 // Reserved :10;=0D + }},=0D + 0, // FirwareVersion=0D + 0, // ModuleManufacturerID (unknown)=0D + 0, // ModuleProductID (unknown)=0D + 0, // MemorySubsystemControllerManufacturerID (unknown)=0D + 0, // MemorySubsystemControllerProductID (unknown)=0D + 0, // NonVolatileSize=0D + 0, // VolatileSize - initialized at runtime=0D + 0, // CacheSize=0D + 0, // LogicalSize=0D + 0, // ExtendedSpeed,=0D + 0 // ExtendedConfiguredMemorySpeed=0D };=0D =0D STATIC CHAR8 CONST *mArmadaDefaultType17Strings[] =3D {=0D - "RIGHT SIDE\0", /* location */=0D + "DIMM SLOT\0", /* location */=0D "BANK 0\0", /* bank description */=0D NULL=0D };=0D @@ -735,9 +764,10 @@ SmbiosMemoryInstall ( }=0D =0D //=0D - // Update TYPE17 memory size field=0D + // Update TYPE17 memory size fields=0D //=0D mArmadaDefaultType17.Size =3D (UINT16)(MemorySize >> 20);=0D + mArmadaDefaultType17.VolatileSize =3D MemorySize;=0D =0D return EFI_SUCCESS;=0D }=0D @@ -767,6 +797,7 @@ SmbiosInstallAllStructures ( mArmadaDefaultType0.SystemBiosMinorRelease =3D FirmwareMinorRevisionNumb= er;=0D mArmadaDefaultType4.CurrentSpeed =3D SampleAtResetGetCpuFrequency ();=0D mArmadaDefaultType17.Speed =3D SampleAtResetGetDramFrequency ();=0D + mArmadaDefaultType17.ConfiguredMemoryClockSpeed =3D SampleAtResetGetDram= Frequency ();=0D =0D //=0D // Generate memory descriptors.=0D --=20 2.29.0