From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web08.19183.1621834177517179038 for ; Sun, 23 May 2021 22:29:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=NVt86oYT; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.208.175, mailfrom: mw@semihalf.com) Received: by mail-lj1-f175.google.com with SMTP id p20so31949358ljj.8 for ; Sun, 23 May 2021 22:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NYQ9qfSM4qfT0qsaCkpPoDyHg0lPZIUGMHthaVwLOCg=; b=NVt86oYTKDqMoayH+IaSMy0tvw7ONJx6Ql0IdIMY/pp7YeEstcsqHHWNQWzv/XRFEi pSPWZUPjcYbwtyj8uZrpVs0xEoObj32O2UrxaoYDCjt8hLqNWMSYj5Qt+Klm/A0fo/XZ CZL5QeehgQwpFjLwR9oySaLrqC4y420NQzn491D2po+OnvPF0vQ51VXRBl2A99aIp/tt +yi4/FNSwhTUwaAzMzI9WvVp747TVgiffzgpJggTkl149wjEn+Dp4/QxhiVlx47SnxZq kY5KrprxHgMVf+cDOdKRRZB+Lg+NBtKwbP9Mw0z8aLCpr0c13aausFnQZ79QUWpDaYRB DN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NYQ9qfSM4qfT0qsaCkpPoDyHg0lPZIUGMHthaVwLOCg=; b=jYzLa2GvAdw7ymNIiu3kfcCHFdoVmabCcia8T483msNQiUjpDzAC5dHOwN7epMCgbH kcVclAuHrGVrKbLudoUGsg1M6u0yfmu+v7ml8YjzSAKUCEPxCSHsGhYfVAST5UFDEUU+ LqMiFmmeyXFoBaAzIpKkmU1XJQi3GY1Y2j9TqZZIvp5W6z4yDfJ76OsYhHDIM0nyRvZD DHgbFD3v9tZ5T40v8YQ0TgmnDLXTjsiqfTfOCSNZgyALE4WkMREtFq0mBYOKh+WjAUAK bss+jhaufGbGIHe+d4vCqMQCVnPhw0NI9aCFZXZw9Se8XYoqAQ77MLUQSpdxY7t1Iz0E zC4g== X-Gm-Message-State: AOAM530QnGL2wSJb22WM4QFb6oRC+jKLCCh+MPvSNzMVqfgybHH3tXOf 1LTuIcs1YxmwK4g3mLXvLrODEaIBix5AoIKv X-Google-Smtp-Source: ABdhPJzRS8LOzxQ3wpMgVBczTOGEvax+1OVf4HhtrWenLp2XCKNMkEdYp2mBSn7DtJIpXBODhQ7PHA== X-Received: by 2002:a2e:a553:: with SMTP id e19mr15526405ljn.280.1621834175802; Sun, 23 May 2021 22:29:35 -0700 (PDT) Return-Path: Received: from gilgamesh.semihalf.com (host-193.106.246.138.static.3s.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id w17sm90739lfp.300.2021.05.23.22.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 22:29:35 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: leif@nuviainc.com, ardb+tianocore@kernel.org, Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com, gjb@semihalf.com, upstream@semihalf.com, Marcin Wojtas Subject: [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Date: Mon, 24 May 2021 07:29:16 +0200 Message-Id: <20210524052919.2496579-4-mw@semihalf.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210524052919.2496579-1-mw@semihalf.com> References: <20210524052919.2496579-1-mw@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable DBG2 ACPI table description [1] specifies three subtypes related to 16550 UART: 0x0 - 16550 compatible 0x1 - 16550 subset 0x12 - 16550 compatible with parameters defined in Generic Address Structure (GAS) It turned out however, that the Windows OS treats 0x0 subtype as legacy x86 UART with 8-bit access. ARM SoCs can use types 0x1 (16550 with fixed mmio32 access) or 0x12 (16550 with fully respected GAS contents). Switch Marvell SoCs ACPI UART subtype to 0x1 - thanks to that the same firmware can run properly with UART output in Windows 10, Linux and ESXI hypervisor. [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-= debug-port-table Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc | 2 +- Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc b/Silicon/Marv= ell/Armada7k8k/AcpiTables/Spcr.aslc index 438cf7880e..6efc175bdf 100644 --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc @@ -22,7 +22,7 @@ EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE,=0D EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION=0D ),=0D - EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550, //= InterfaceType=0D + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450, //= InterfaceType=0D { EFI_ACPI_RESERVED_BYTE,=0D EFI_ACPI_RESERVED_BYTE,=0D EFI_ACPI_RESERVED_BYTE }, //= Reserved1[3]=0D diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc b/Silicon/Ma= rvell/OcteonTx/AcpiTables/T91/Spcr.aslc index f663d8ade8..2a3415f0a6 100644 --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc @@ -22,7 +22,7 @@ EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE,=0D EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION=0D ),=0D - EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550, //= InterfaceType=0D + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450, //= InterfaceType=0D { EFI_ACPI_RESERVED_BYTE,=0D EFI_ACPI_RESERVED_BYTE,=0D EFI_ACPI_RESERVED_BYTE }, //= Reserved1[3]=0D --=20 2.29.0