From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: [PATCH v1 1/1] MdePkg: MmControl: Fix function and structure definition mismatches
Date: Thu, 27 May 2021 01:17:23 -0700 [thread overview]
Message-ID: <20210527081723.1934-2-kuqin12@gmail.com> (raw)
In-Reply-To: <20210527081723.1934-1-kuqin12@gmail.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3397
Current Ppi/MmControl.h file has structure definition of "struct
_PEI_MM_CONTROL_PPI". This name mismatches with its definition in PI
Specification v1.7 (Errata) as "struct _EFI_PEI_MM_CONTROL_PPI".
In addition, field types "PEI_MM_ACTIVATE" and "PEI_MM_DEACTIVATE" used
in "struct _PEI_MM_CONTROL_PPI" mismatches with the definition of
"EFI_PEI_MM_ACTIVATE" and "EFI_PEI_MM_DEACTIVATE" in the PI spec.
This change fixes these mismatches by using the PI spec defined names.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Fixes: 6f33f7a262314af35e2b99c849e08928ea49aa55
Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
MdePkg/Include/Ppi/MmControl.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Ppi/MmControl.h b/MdePkg/Include/Ppi/MmControl.h
index 983ed95cd53d..17586f437b4b 100644
--- a/MdePkg/Include/Ppi/MmControl.h
+++ b/MdePkg/Include/Ppi/MmControl.h
@@ -69,7 +69,7 @@ EFI_STATUS
**/
typedef
EFI_STATUS
-(EFIAPI *PEI_MM_DEACTIVATE) (
+(EFIAPI *EFI_PEI_MM_DEACTIVATE) (
IN EFI_PEI_SERVICES **PeiServices,
IN EFI_PEI_MM_CONTROL_PPI * This,
IN BOOLEAN Periodic OPTIONAL
@@ -80,9 +80,9 @@ EFI_STATUS
/// platform hardware that generates an MMI. There are often I/O ports that, when accessed, will
/// generate the MMI. Also, the hardware optionally supports the periodic generation of these signals.
///
-struct _PEI_MM_CONTROL_PPI {
- PEI_MM_ACTIVATE Trigger;
- PEI_MM_DEACTIVATE Clear;
+struct _EFI_PEI_MM_CONTROL_PPI {
+ EFI_PEI_MM_ACTIVATE Trigger;
+ EFI_PEI_MM_DEACTIVATE Clear;
};
extern EFI_GUID gEfiPeiMmControlPpiGuid;
--
2.31.1.windows.1
next prev parent reply other threads:[~2021-05-27 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 8:17 [PATCH v1 0/1] Fix function and structure definition mismatches in Ppi/MmControl.h Kun Qin
2021-05-27 8:17 ` Kun Qin [this message]
2021-06-01 1:26 ` 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: MmControl: Fix function and structure definition mismatches gaoliming
[not found] ` <168450F5F1A18D8C.26195@groups.io>
2021-06-02 5:55 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527081723.1934-2-kuqin12@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox