From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web09.4159.1622103467655428414 for ; Thu, 27 May 2021 01:17:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pPDn1AmN; spf=pass (domain: gmail.com, ip: 209.85.216.50, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f50.google.com with SMTP id f8so25354pjh.0 for ; Thu, 27 May 2021 01:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iG30sCCTyuSmeyHmQfzTcVawOFme3ezQu3kRzcwe7nU=; b=pPDn1AmN3VB3swSKSQg1J2JKcYV++bhZ8hWlcIxdk7j7LWhowRhwI5Zwdn834HqanQ A9mih1PZ3xbwncBfe+UzGABvWsXuYJBtVsHQuSxS/+L0VnpkU86FIQzcrqcHAdxN6JDq Q4w8iEBfPthYl4a2qlXj8Jk9A3G8GJbAaM4R2b2ECpSJA78Ia0xpEWZEO+ewQ6dG7QT6 yhRBy7VcZSNrAIOVb01LMEsim0rrXrzr7YphAK/m01r3tinbBjPd+30EiT+K6ef6bEql otVRpj0jXnkXjqicY7S4bJxmGAjhKKTlqmc2MsAHWO29RrLi+NG18XRKpKFj7eRhr9Qa ubMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iG30sCCTyuSmeyHmQfzTcVawOFme3ezQu3kRzcwe7nU=; b=jWXTLQBzQ1oc8eDBfZQUoa+itT1WM+jq9b310+hZoZB6fdTZBulGd2/kfnqgBe8GXm bPLZ+pUqdcjhnazmZCIGOja70ViyzPrhefAGJ9hyd4HyqHLmKXpCJnxr5kpjf1dY5FTh wSZYtCdS62aTDrDb+LtCYriGFaPPd2GXCAJvJffWidT+UpXsbRBkvIeFFr5dySfWubU1 oQXP3AMv4mWHgxJn46xalF98IFPVF5RJQM9FOvAMPbB9WvITXgRRLz2U5vPdMsecXyVS Uv1kuGEcjYoFURo7G5ZXUS5Mus4GQnCmWh6Zsbpk4RXWbvBuoY67L0VN9o9/Z0a7J5yP Wa7w== X-Gm-Message-State: AOAM532EhTxBZZtcqX/vuJDLaz4fujLVPFVLr2kD9KZiQbrFbqFLPtt4 7nb36y8hc1VbYSQlAGWq9BFvfqZtm8yq7Q== X-Google-Smtp-Source: ABdhPJy5yWMp4ILLJ+JNZyPGPD/GjphZDJrquCh1HeVxZkABWmVVP+bElsGrwBZv80O/jtMGDzXr9Q== X-Received: by 2002:a17:90b:1217:: with SMTP id gl23mr464018pjb.137.1622103467123; Thu, 27 May 2021 01:17:47 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id c130sm1223252pfc.51.2021.05.27.01.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 01:17:46 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH v1 1/1] MdePkg: MmControl: Fix function and structure definition mismatches Date: Thu, 27 May 2021 01:17:23 -0700 Message-Id: <20210527081723.1934-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210527081723.1934-1-kuqin12@gmail.com> References: <20210527081723.1934-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3397 Current Ppi/MmControl.h file has structure definition of "struct _PEI_MM_CONTROL_PPI". This name mismatches with its definition in PI Specification v1.7 (Errata) as "struct _EFI_PEI_MM_CONTROL_PPI". In addition, field types "PEI_MM_ACTIVATE" and "PEI_MM_DEACTIVATE" used in "struct _PEI_MM_CONTROL_PPI" mismatches with the definition of "EFI_PEI_MM_ACTIVATE" and "EFI_PEI_MM_DEACTIVATE" in the PI spec. This change fixes these mismatches by using the PI spec defined names. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Fixes: 6f33f7a262314af35e2b99c849e08928ea49aa55 Signed-off-by: Kun Qin --- MdePkg/Include/Ppi/MmControl.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Ppi/MmControl.h b/MdePkg/Include/Ppi/MmControl.h index 983ed95cd53d..17586f437b4b 100644 --- a/MdePkg/Include/Ppi/MmControl.h +++ b/MdePkg/Include/Ppi/MmControl.h @@ -69,7 +69,7 @@ EFI_STATUS **/ typedef EFI_STATUS -(EFIAPI *PEI_MM_DEACTIVATE) ( +(EFIAPI *EFI_PEI_MM_DEACTIVATE) ( IN EFI_PEI_SERVICES **PeiServices, IN EFI_PEI_MM_CONTROL_PPI * This, IN BOOLEAN Periodic OPTIONAL @@ -80,9 +80,9 @@ EFI_STATUS /// platform hardware that generates an MMI. There are often I/O ports that, when accessed, will /// generate the MMI. Also, the hardware optionally supports the periodic generation of these signals. /// -struct _PEI_MM_CONTROL_PPI { - PEI_MM_ACTIVATE Trigger; - PEI_MM_DEACTIVATE Clear; +struct _EFI_PEI_MM_CONTROL_PPI { + EFI_PEI_MM_ACTIVATE Trigger; + EFI_PEI_MM_DEACTIVATE Clear; }; extern EFI_GUID gEfiPeiMmControlPpiGuid; -- 2.31.1.windows.1