* [PATCH] Add missing EFIAPI to VirtioMmioSetQueueAddress
@ 2021-05-28 14:16 Gerd Hoffmann
2021-06-01 12:25 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2021-05-28 14:16 UTC (permalink / raw)
To: devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 +
OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
index 785876c75f82..ab53b90d51c9 100644
--- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
+++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
@@ -107,6 +107,7 @@ VirtioMmioSetQueueSel (
);
EFI_STATUS
+EFIAPI
VirtioMmioSetQueueAddress (
IN VIRTIO_DEVICE_PROTOCOL *This,
IN VRING *Ring,
diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
index 454f008827be..b0d75fb1dd24 100644
--- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
+++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
@@ -173,6 +173,7 @@ VirtioMmioSetQueueSel (
}
EFI_STATUS
+EFIAPI
VirtioMmioSetQueueAddress (
IN VIRTIO_DEVICE_PROTOCOL *This,
IN VRING *Ring,
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH] Add missing EFIAPI to VirtioMmioSetQueueAddress
2021-05-28 14:16 [PATCH] Add missing EFIAPI to VirtioMmioSetQueueAddress Gerd Hoffmann
@ 2021-06-01 12:25 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2021-06-01 12:25 UTC (permalink / raw)
To: devel, kraxel
Hi Gerd,
On 05/28/21 16:16, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 +
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 +
> 2 files changed, 2 insertions(+)
Thanks for the patch!
(1) Please write a non-empty commit message body. For example, "This
error was found while compiling VirtioMmioDeviceLib for X64 with the
GCC5 toolchain, where EFIAPI makes a difference."
(I had to verify that the actual protocol member function type,
VIRTIO_SET_QUEUE_ADDRESS [OvmfPkg/Include/Protocol/VirtioDevice.h], did
spell out EFIAPI.)
(2) The patch contains some CRLF issues; please consider running
"BaseTools/Scripts/SetupGit.py" in your clone. Two things could be
missing in particular:
- the "8bit" (or even "base64") value for "sendemail.transferEncoding",
- the "cr-at-eol" value for "core.whitespace".
Thanks!
Laszlo
>
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> index 785876c75f82..ab53b90d51c9 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h
> @@ -107,6 +107,7 @@ VirtioMmioSetQueueSel (
> );
>
>
>
> EFI_STATUS
>
> +EFIAPI
>
> VirtioMmioSetQueueAddress (
>
> IN VIRTIO_DEVICE_PROTOCOL *This,
>
> IN VRING *Ring,
>
> diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> index 454f008827be..b0d75fb1dd24 100644
> --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c
> @@ -173,6 +173,7 @@ VirtioMmioSetQueueSel (
> }
>
>
>
> EFI_STATUS
>
> +EFIAPI
>
> VirtioMmioSetQueueAddress (
>
> IN VIRTIO_DEVICE_PROTOCOL *This,
>
> IN VRING *Ring,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-28 14:16 [PATCH] Add missing EFIAPI to VirtioMmioSetQueueAddress Gerd Hoffmann
2021-06-01 12:25 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox