From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.58156.1622555452337649422 for ; Tue, 01 Jun 2021 06:50:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=lZBzhBWt; spf=pass (domain: puresoftware.com, ip: 209.85.210.173, mailfrom: vikas.singh@puresoftware.com) Received: by mail-pf1-f173.google.com with SMTP id u18so1236427pfk.11 for ; Tue, 01 Jun 2021 06:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d7biy9cpYJEXRj4/gPpQ544DjmJd9/DlKNKwhRAsMO0=; b=lZBzhBWt1EZFLYG99kMTSFxHXuAGWVUPVEL85HH7KXmmKdd2MZa8wNzvnW0WxmthKF Z3ojNUxSziBSPlsyB+Ls1+d0Y11KDCOgf4c+vPGMftbt2oq37LtiFXSg5pegOkqvSG1T 4fXE1mnoKA3a9Z68zJhux0tKkH8277xbqyvQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d7biy9cpYJEXRj4/gPpQ544DjmJd9/DlKNKwhRAsMO0=; b=VT5K6S9beto7wHSL2waiEoh19YzyzFEIAB8a8GYMhsDmIIiZnaDA441+GnBMh2Njg7 1bdPmLpQ6Y9L7MuyIj1uJabNW22/W6+9UeGybLr4OViipMvU+OQg2iF/ukJwPdATKIJU zbY0knQgDMRGbspO5wwAZMAi3Ur4aEZjZ+zwuwShGnyjugEAJ1HaosF50ON4rYgWkyE0 nPKQxB0yo6CMRcPNCGxO7Or+zhrvSae/CvfkRY8YNuW1fJ2n1dewwtdEETduOS98ifpl 5ZyQqNd4g3Vyz5QKXlwdyQ9yckMmdIe/eHQBHc4LoTlmE8vtWdWHCyl429FtzLxnL5uO Jtiw== X-Gm-Message-State: AOAM532dQa4+MI6P1E1LKo+V25r7hpuJ8UN8mdYpNU815hJOv1xoUke8 2lkBr97CnDvApANiHnc+I3f2pk7K2rsmG7yA140= X-Google-Smtp-Source: ABdhPJyH0o2riUtgt12rVvI37383MomI8rwZemwmobtZbVP4rUv5D9UXDy42m7cgXRRi+j9j1hJgnw== X-Received: by 2002:aa7:8ecc:0:b029:2e8:df63:9bc3 with SMTP id b12-20020aa78ecc0000b02902e8df639bc3mr22178684pfr.5.1622555451658; Tue, 01 Jun 2021 06:50:51 -0700 (PDT) Return-Path: Received: from embedded-PC.puresoft.int ([125.63.92.170]) by smtp.gmail.com with ESMTPSA id d22sm14504798pgb.15.2021.06.01.06.50.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Jun 2021 06:50:51 -0700 (PDT) From: "Vikas Singh" To: devel@edk2.groups.io Cc: sami.mujawar@arm.com, leif@nuviainc.com, meenakshi.aggarwal@nxp.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com, Sunny.Wang@arm.com Subject: [PATCH V0 1/4] Platform/NXP: Add generic log in CM to print SoC version Date: Tue, 1 Jun 2021 19:20:31 +0530 Message-Id: <20210601135034.22386-2-vikas.singh@puresoftware.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210601135034.22386-1-vikas.singh@puresoftware.com> References: <20210601135034.22386-1-vikas.singh@puresoftware.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Summary - 1.Configuration Manager(CM) is a common implementation and should not evaluate the SoC version using macro's However CM must directly consume SoC ver string from platfrom who is extending CM services for ACPI table generation. 2.Platforms who extends CM services for themselves must notify their SoC details to CM. 3.This patch will update the lx2160ardb platform header also with PLAT_SOC_NAME, this will be consumed by CM. Signed-off-by: Vikas Singh --- .../ConfigurationManagerDxe/ConfigurationManager.c | 10 +++------- Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 5 ++--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/C= onfigurationManager.c b/Platform/NXP/ConfigurationManagerPkg/ConfigurationM= anagerDxe/ConfigurationManager.c index 80ce8412c4..dc1a7f5f85 100644 --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c @@ -2,7 +2,7 @@ Configuration Manager Dxe=0D =0D Copyright 2020 NXP=0D - Copyright 2020 Puresoftware Ltd=0D + Copyright 2020-2021 Puresoftware Ltd=0D =0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D @@ -170,12 +170,8 @@ InitializePlatformRepository ( PlatformRepo =3D This->PlatRepoInfo;=0D =0D Svr =3D SocGetSvr ();=0D - if (SVR_SOC_VER(Svr) =3D=3D SVR_LX2160A) {=0D - PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr);=0D - DEBUG ((DEBUG_INFO, "Fsl : SoC LX2160A Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision));=0D - } else {=0D - DEBUG ((DEBUG_INFO, "Fsl : SoC Unknown Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision));=0D - }=0D + PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr);=0D + DEBUG ((DEBUG_INFO, "Fsl : SoC =3D %s Rev =3D 0x%x\n", PLAT_SOC_NAME, Pl= atformRepo->FslBoardRevision));=0D =0D return EFI_SUCCESS;=0D }=0D diff --git a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h b/Platform/NXP/L= X2160aRdbPkg/Include/Platform.h index 76a41d4369..c18faf28cd 100644 --- a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h +++ b/Platform/NXP/LX2160aRdbPkg/Include/Platform.h @@ -2,7 +2,7 @@ * Platform headers=0D *=0D * Copyright 2020 NXP=0D - * Copyright 2020 Puresoftware Ltd=0D + * Copyright 2020-2021 Puresoftware Ltd=0D *=0D * SPDX-License-Identifier: BSD-2-Clause-Patent=0D *=0D @@ -15,12 +15,11 @@ #define EFI_ACPI_ARM_OEM_REVISION 0x00000000=0D =0D // Soc defines=0D +#define PLAT_SOC_NAME "LX2160ARDB"=0D #define SVR_SOC_VER(svr) (((svr) >> 8) & 0xFFFFFE)=0D #define SVR_MAJOR(svr) (((svr) >> 4) & 0xf)=0D #define SVR_MINOR(svr) (((svr) >> 0) & 0xf)=0D =0D -#define SVR_LX2160A 0x873600=0D -=0D // PCLK=0D #define DCFG_BASE 0x1E00000=0D #define DCFG_LEN 0x1FFFF=0D --=20 2.25.1