From: "Leif Lindholm" <leif@nuviainc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: devel@edk2.groups.io, Vu Nguyen <vunguyen@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platforms][PATCH v2 07/32] JadePkg: Implement RealTimeClockLib for PCF85063
Date: Sat, 5 Jun 2021 00:26:15 +0100 [thread overview]
Message-ID: <20210604232615.zdpphdmxdj3kvg37@leviathan> (raw)
In-Reply-To: <20210526100724.5359-9-nhi@os.amperecomputing.com>
On Wed, May 26, 2021 at 17:06:59 +0700, Nhi Pham wrote:
> From: Vu Nguyen <vunguyen@os.amperecomputing.com>
>
> This library adds the support for retrieving and updating system
> datetime over real RTC PCF85063 device on Mt. Jade platform instead of
> using virtual RTC.
>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +
> Platform/Ampere/JadePkg/Jade.dsc | 2 +-
> Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.inf | 44 +++
> Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.h | 91 ++++++
> Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c | 317 ++++++++++++++++++++
> Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c | 257 ++++++++++++++++
> 6 files changed, 712 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> index 6a6f72e995af..9f19f495fad2 100755
> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> @@ -84,6 +84,8 @@ [LibraryClasses.common]
> SystemFirmwareInterfaceLib|Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.inf
> AmpereCpuLib|Silicon/Ampere/AmpereAltraPkg/Library/AmpereCpuLib/AmpereCpuLib.inf
> TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> + I2cLib|Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.inf
> + GpioLib|Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf
> MmCommunicationLib|Silicon/Ampere/AmpereAltraPkg/Library/MmCommunicationLib/MmCommunicationLib.inf
>
> #
> diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc
> index f92855af99ab..f37ab1a92e44 100755
> --- a/Platform/Ampere/JadePkg/Jade.dsc
> +++ b/Platform/Ampere/JadePkg/Jade.dsc
> @@ -73,7 +73,7 @@ [LibraryClasses]
> #
> # RTC Library: Common RTC
> #
> - RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> + RealTimeClockLib|Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.inf
>
> #
> # Library for FailSafe support
> diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.inf b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.inf
> new file mode 100644
> index 000000000000..1fe561cc0ec9
> --- /dev/null
> +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.inf
> @@ -0,0 +1,44 @@
> +## @file
> +#
> +# Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 0x0001001B
> + MODULE_TYPE = BASE
> + BASE_NAME = PCF85063RealTimeClockLib
> + FILE_GUID = 271569F6-5522-4006-9FF5-F07A59473AAC
> + LIBRARY_CLASS = RealTimeClockLib
> + VERSION_STRING = 1.0
> +
> +[Sources.common]
> + PCF85063.c
> + PCF85063.h
> + PCF85063RealTimeClockLib.c
> +
> +[Packages]
> + ArmPkg/ArmPkg.dec
> + ArmPlatformPkg/ArmPlatformPkg.dec
> + EmbeddedPkg/EmbeddedPkg.dec
> + MdePkg/MdePkg.dec
> + Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec
> + Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
> +
> +[LibraryClasses]
> + ArmGenericTimerCounterLib
> + ArmLib
> + BaseLib
> + DebugLib
> + GpioLib
> + DxeServicesTableLib
> + I2cLib
> + TimeBaseLib
> + TimerLib
> + UefiLib
> + UefiRuntimeLib
> +
> +[Guids]
> + gEfiEventVirtualAddressChangeGuid
> diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.h b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.h
> new file mode 100644
> index 000000000000..03ce4d29a03f
> --- /dev/null
> +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.h
> @@ -0,0 +1,91 @@
> +/** @file
> +
> + Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef PCF85063_H_
> +#define PCF85063_H_
> +
> +#include <Uefi.h>
> +
> +#include <Library/BaseLib.h>
> +#include <Library/RealTimeClockLib.h>
> +
> +//
> +// I2C bus address that RTC connected to
> +//
> +#define I2C_RTC_BUS_ADDRESS 1
> +
> +//
> +// I2C RTC bus speed
> +//
> +#define I2C_RTC_BUS_SPEED 100000
> +
> +//
> +// I2C chip address that RTC connected to
> +//
> +#define I2C_RTC_CHIP_ADDRESS 0x51
> +
> +//
> +// The GPI PIN that tell if RTC can be access
> +//
> +#define I2C_RTC_ACCESS_GPIO_PIN 28
> +
> +/**
> + * Returns the current time and date information of the hardware platform.
> + *
> + * @param Time A pointer to storage to receive a snapshot of the current time.
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER Time is NULL.
> + * @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error.
> + */
> +EFI_STATUS
> +EFIAPI
> +PlatformGetTime (
> + OUT EFI_TIME *Time
> + );
> +
> +/**
> + * Set the time and date information to the hardware platform.
> + *
> + * @param Time A pointer to storage to set the current time to hardware platform.
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER Time is NULL.
> + * @retval EFI_DEVICE_ERROR The time could not be set due due to hardware error.
> + **/
> +EFI_STATUS
> +EFIAPI
> +PlatformSetTime (
> + IN EFI_TIME *Time
> + );
> +
> +/**
> + * Callback function for hardware platform to convert data pointers to virtual address
> + */
> +VOID
> +EFIAPI
> +PlatformVirtualAddressChangeEvent (
> + VOID
> + );
> +
> +/**
> + * Callback function for hardware platform to initialize private data
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval Others The error status indicates the error
> + */
> +EFI_STATUS
> +EFIAPI
> +PlatformInitialize (
> + VOID
> + );
> +
> +#endif /* PCF85063_H_ */
> diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c
> new file mode 100644
> index 000000000000..f9fa125d9d7e
> --- /dev/null
> +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c
> @@ -0,0 +1,317 @@
> +/** @file
> +
> + Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Uefi.h>
> +
> +#include <Library/BaseLib.h>
> +#include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
> +#include <Library/GpioLib.h>
> +#include <Library/I2cLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Library/PcdLib.h>
> +#include <Library/TimerLib.h>
> +#include <Library/UefiBootServicesTableLib.h>
> +#include <Library/UefiLib.h>
> +#include <Library/UefiRuntimeLib.h>
> +#include <Library/UefiRuntimeServicesTableLib.h>
> +
> +#include "PCF85063.h"
> +
> +#define RTC_TIMEOUT_WAIT_ACCESS 100000 /* 100 miliseconds */
> +#define RTC_DEFAULT_MIN_YEAR 2000
> +#define RTC_DEFAULT_MAX_YEAR 2099
> +
> +#define RTC_ADDR 0x4
> +#define RTC_DATA_BUF_LEN 8
> +
> +/**
> + * PCF85063 register offsets
> + */
> +#define PCF85063_OFFSET_SEC 0x0
> +#define PCF85063_OFFSET_MIN 0x1
> +#define PCF85063_OFFSET_HR 0x2
> +#define PCF85063_OFFSET_DAY 0x3
> +#define PCF85063_OFFSET_WKD 0x4
> +#define PCF85063_OFFSET_MON 0x5
> +#define PCF85063_OFFSET_YEA 0x6
> +
> +/**
> + * PCF85063 encoding macros
> + */
> +#define PCF85063_SEC_ENC(s) (((((s) / 10) & 0x7) << 4) | (((s) % 10) & 0xf))
> +#define PCF85063_MIN_ENC(m) (((((m) / 10) & 0x7) << 4) | (((m) % 10) & 0xf))
> +#define PCF85063_HR_ENC(h) (((((h) / 10) & 0x3) << 4) | (((h) % 10) & 0xf))
> +#define PCF85063_DAY_ENC(d) (((((d) / 10) & 0x3) << 4) | (((d) % 10) & 0xf))
> +#define PCF85063_WKD_ENC(w) ((w) & 0x7)
> +#define PCF85063_MON_ENC(m) (((((m) / 10) & 0x1) << 4) | (((m) % 10) & 0xf))
> +#define PCF85063_YEA_ENC(y) (((((y) / 10) & 0xf) << 4) | (((y) % 10) & 0xf))
> +
> +/**
> + * PCF85063 decoding macros
> + */
> +#define PCF85063_SEC_DEC(s) (((((s) & 0x70) >> 4) * 10) + ((s) & 0xf))
> +#define PCF85063_MIN_DEC(m) (((((m) & 0x70) >> 4) * 10) + ((m) & 0xf))
> +#define PCF85063_HR_DEC(h) (((((h) & 0x30) >> 4) * 10) + ((h) & 0xf))
> +#define PCF85063_DAY_DEC(d) (((((d) & 0x30) >> 4)* 10) + ((d) & 0xf))
*twitch*
Please add that space before '*' like on all other lines.
With that:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
/
Leif
> +#define PCF85063_WKD_DEC(w) ((w) & 0x7)
> +#define PCF85063_MON_DEC(m) (((((m) & 0x10) >> 4) * 10) + ((m) & 0xf))
> +#define PCF85063_YEA_DEC(y) (((((y) & 0xf0) >> 4) * 10) + ((y) & 0xf))
> +
> +/* Buffer pointers to convert Vir2Phys and Phy2Vir */
> +STATIC volatile UINT64 RtcBufVir;
> +STATIC volatile UINT64 RtcBufPhy;
> +
> +STATIC
> +EFI_STATUS
> +RtcI2cWaitAccess (
> + VOID
> + )
> +{
> + INTN Timeout;
> +
> + Timeout = RTC_TIMEOUT_WAIT_ACCESS;
> + while ((GpioReadBit (I2C_RTC_ACCESS_GPIO_PIN) != 0) && (Timeout > 0)) {
> + MicroSecondDelay (100);
> + Timeout -= 100;
> + }
> +
> + if (Timeout <= 0) {
> + DEBUG ((DEBUG_ERROR, "%a: Timeout while waiting access RTC\n", __FUNCTION__));
> + return EFI_TIMEOUT;
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +STATIC
> +EFI_STATUS
> +RtcI2cRead (
> + IN UINT8 Addr,
> + IN OUT UINT64 Data,
> + IN UINT32 DataLen
> + )
> +{
> + EFI_STATUS Status;
> + UINT32 TmpLen;
> +
> + if (EFI_ERROR (RtcI2cWaitAccess ())) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + Status = I2cProbe (I2C_RTC_BUS_ADDRESS, I2C_RTC_BUS_SPEED);
> + if (EFI_ERROR (Status)) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + //
> + // Send the slave address for read
> + //
> + TmpLen = 1;
> + Status = I2cWrite (I2C_RTC_BUS_ADDRESS, I2C_RTC_CHIP_ADDRESS, (UINT8 *)&Addr, &TmpLen);
> + if (EFI_ERROR (Status)) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + //
> + // Read back the time
> + //
> + Status = I2cRead (I2C_RTC_BUS_ADDRESS, I2C_RTC_CHIP_ADDRESS, NULL, 0, (UINT8 *)Data, &DataLen);
> + if (EFI_ERROR (Status)) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +EFI_STATUS
> +RtcI2cWrite (
> + IN UINT8 Addr,
> + IN UINT64 Data,
> + IN UINT32 DataLen
> + )
> +{
> + EFI_STATUS Status;
> + UINT8 TmpBuf[RTC_DATA_BUF_LEN + 1];
> + UINT32 TmpLen;
> +
> + if (EFI_ERROR (RtcI2cWaitAccess ())) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + if (DataLen > sizeof (TmpBuf) - 1) {
> + return EFI_INVALID_PARAMETER;
> + }
> +
> + Status = I2cProbe (I2C_RTC_BUS_ADDRESS, I2C_RTC_BUS_SPEED);
> + if (EFI_ERROR (Status)) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + //
> + // The first byte is the address
> + //
> + TmpBuf[0] = Addr;
> + TmpLen = DataLen + 1;
> + CopyMem ((VOID *)(TmpBuf + 1), (VOID *)Data, DataLen);
> +
> + Status = I2cWrite (I2C_RTC_BUS_ADDRESS, I2C_RTC_CHIP_ADDRESS, TmpBuf, &TmpLen);
> + if (EFI_ERROR (Status)) {
> + return EFI_DEVICE_ERROR;
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + * Returns the current time and date information of the hardware platform.
> + *
> + * @param Time A pointer to storage to receive a snapshot of the current time.
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER Time is NULL.
> + * @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error.
> + */
> +EFI_STATUS
> +EFIAPI
> +PlatformGetTime (
> + OUT EFI_TIME *Time
> + )
> +{
> + EFI_STATUS Status;
> + UINT8 *Data;
> +
> + if (Time == NULL) {
> + return EFI_INVALID_PARAMETER;
> + }
> +
> + Status = RtcI2cRead (RTC_ADDR, RtcBufVir, RTC_DATA_BUF_LEN);
> +
> + Data = (UINT8 *)RtcBufVir;
> + if (Status == EFI_SUCCESS) {
> + Time->Second = PCF85063_SEC_DEC (Data[PCF85063_OFFSET_SEC]);
> + Time->Minute = PCF85063_MIN_DEC (Data[PCF85063_OFFSET_MIN]);
> + Time->Hour = PCF85063_HR_DEC (Data[PCF85063_OFFSET_HR]);
> + Time->Day = PCF85063_DAY_DEC (Data[PCF85063_OFFSET_DAY]);
> + Time->Month = PCF85063_MON_DEC (Data[PCF85063_OFFSET_MON]);
> + Time->Year = PCF85063_YEA_DEC (Data[PCF85063_OFFSET_YEA]);
> + Time->Year += RTC_DEFAULT_MIN_YEAR;
> + if (Time->Year > RTC_DEFAULT_MAX_YEAR) {
> + Time->Year = RTC_DEFAULT_MAX_YEAR;
> + }
> + if (Time->Year < RTC_DEFAULT_MIN_YEAR) {
> + Time->Year = RTC_DEFAULT_MIN_YEAR;
> + }
> + }
> +
> + return Status;
> +}
> +
> +/**
> + * Set the time and date information to the hardware platform.
> + *
> + * @param Time A pointer to storage to set the current time to hardware platform.
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER Time is NULL.
> + * @retval EFI_DEVICE_ERROR The time could not be set due due to hardware error.
> + **/
> +EFI_STATUS
> +EFIAPI
> +PlatformSetTime (
> + IN EFI_TIME *Time
> + )
> +{
> + UINT8 *Data;
> +
> + if (Time == NULL) {
> + return EFI_INVALID_PARAMETER;
> + }
> +
> + if (Time->Year < RTC_DEFAULT_MIN_YEAR ||
> + Time->Year > RTC_DEFAULT_MAX_YEAR)
> + {
> + return EFI_INVALID_PARAMETER;
> + }
> +
> + Data = (UINT8 *)RtcBufVir;
> + Data[PCF85063_OFFSET_SEC] = PCF85063_SEC_ENC (Time->Second);
> + Data[PCF85063_OFFSET_MIN] = PCF85063_MIN_ENC (Time->Minute);
> + Data[PCF85063_OFFSET_HR] = PCF85063_HR_ENC (Time->Hour);
> + Data[PCF85063_OFFSET_DAY] = PCF85063_DAY_ENC (Time->Day);
> + Data[PCF85063_OFFSET_MON] = PCF85063_MON_ENC (Time->Month);
> + Data[PCF85063_OFFSET_YEA] = PCF85063_YEA_ENC (Time->Year - RTC_DEFAULT_MIN_YEAR);
> +
> + return RtcI2cWrite (RTC_ADDR, RtcBufVir, RTC_DATA_BUF_LEN);
> +}
> +
> +/**
> + * Callback function for hardware platform to convert data pointers to virtual address
> + */
> +VOID
> +EFIAPI
> +PlatformVirtualAddressChangeEvent (
> + VOID
> + )
> +{
> + EfiConvertPointer (0x0, (VOID **)&RtcBufVir);
> +}
> +
> +/**
> + * Callback function for hardware platform to initialize private data
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval Others The error status indicates the error
> + */
> +EFI_STATUS
> +EFIAPI
> +PlatformInitialize (
> + VOID
> + )
> +{
> + EFI_STATUS Status;
> +
> + /*
> + * Allocate the buffer for RTC data
> + * The buffer can be accessible after ExitBootServices
> + */
> + RtcBufVir = (UINT64)AllocateRuntimeZeroPool (RTC_DATA_BUF_LEN);
> + ASSERT_EFI_ERROR (RtcBufVir);
> + RtcBufPhy = (UINT64)RtcBufVir;
> +
> + Status = I2cSetupRuntime (I2C_RTC_BUS_ADDRESS);
> + ASSERT_EFI_ERROR (Status);
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "%a:%d I2cSetupRuntime() failed - %r \n",
> + __FUNCTION__,
> + __LINE__,
> + Status
> + ));
> + return Status;
> + }
> +
> + Status = GpioSetupRuntime (I2C_RTC_ACCESS_GPIO_PIN);
> + ASSERT_EFI_ERROR (Status);
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "%a:%d GpioSetupRuntime() failed - %r \n",
> + __FUNCTION__,
> + __LINE__,
> + Status
> + ));
> + return Status;
> + }
> +
> + return EFI_SUCCESS;
> +}
> diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c
> new file mode 100755
> index 000000000000..ef8c71e92c18
> --- /dev/null
> +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c
> @@ -0,0 +1,257 @@
> +/** @file
> +
> + Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <PiDxe.h>
> +#include <Uefi.h>
> +
> +#include <Guid/EventGroup.h>
> +#include <Library/ArmGenericTimerCounterLib.h>
> +#include <Library/ArmLib.h>
> +#include <Library/BaseLib.h>
> +#include <Library/DebugLib.h>
> +#include <Library/DxeServicesTableLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Library/RealTimeClockLib.h>
> +#include <Library/TimeBaseLib.h>
> +#include <Library/UefiBootServicesTableLib.h>
> +#include <Library/UefiLib.h>
> +#include <Library/UefiRuntimeLib.h>
> +#include <Library/UefiRuntimeServicesTableLib.h>
> +#include <Protocol/RealTimeClock.h>
> +
> +#include "PCF85063.h"
> +
> +#define TICKS_PER_SEC (ArmGenericTimerGetTimerFreq ())
> +
> +STATIC EFI_EVENT mVirtualAddressChangeEvent = NULL;
> +
> +STATIC UINT64 mLastSavedSystemCount = 0;
> +STATIC UINT64 mLastSavedTimeEpoch = 0;
> +
> +/**
> + * Returns the current time and date information, and the time-keeping capabilities
> + * of the hardware platform.
> + *
> + * @param Time A pointer to storage to receive a snapshot of the current time.
> + * @param Capabilities An optional pointer to a buffer to receive the real time clock
> + * device's capabilities.
> + *
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER Time is NULL.
> + * @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error.
> + */
> +EFI_STATUS
> +EFIAPI
> +LibGetTime (
> + OUT EFI_TIME *Time,
> + OUT EFI_TIME_CAPABILITIES *Capabilities
> + )
> +{
> + EFI_STATUS Status;
> + UINT64 CurrentSystemCount;
> + UINT64 TimeElapsed;
> + UINTN EpochSeconds;
> +
> + if ((mLastSavedTimeEpoch == 0) || EfiAtRuntime ()) {
> + Status = PlatformGetTime (Time);
> + if (EFI_ERROR (Status)) {
> + // Failed to read platform RTC so create fake time
> + Time->Second = 0;
> + Time->Minute = 0;
> + Time->Hour = 10;
> + Time->Day = 1;
> + Time->Month = 1;
> + Time->Year = 2017;
> + }
> +
> + EpochSeconds = EfiTimeToEpoch (Time);
> + if (!EfiAtRuntime ()) {
> + mLastSavedTimeEpoch = EpochSeconds;
> + mLastSavedSystemCount = ArmGenericTimerGetSystemCount ();
> + }
> + } else {
> + CurrentSystemCount = ArmGenericTimerGetSystemCount ();
> + if (CurrentSystemCount >= mLastSavedSystemCount) {
> + TimeElapsed = (CurrentSystemCount - mLastSavedSystemCount) / MultU64x32 (1, TICKS_PER_SEC);
> + EpochSeconds = mLastSavedTimeEpoch + TimeElapsed;
> + } else {
> + // System counter overflow 64 bits
> + // Call GetTime again to read the date from RTC HW, not using generic timer system counter
> + mLastSavedTimeEpoch = 0;
> + return LibGetTime (Time, Capabilities);
> + }
> + }
> +
> + // Adjust for the correct timezone
> + if (Time->TimeZone != EFI_UNSPECIFIED_TIMEZONE) {
> + EpochSeconds += Time->TimeZone * SEC_PER_MIN;
> + }
> +
> + // Adjust for the correct period
> + if ((Time->Daylight & EFI_TIME_IN_DAYLIGHT) == EFI_TIME_IN_DAYLIGHT) {
> + // Convert to adjusted time, i.e. spring forwards one hour
> + EpochSeconds += SEC_PER_HOUR;
> + }
> +
> + EpochToEfiTime (EpochSeconds, Time);
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + * Sets the current local time and date information.
> + *
> + * @param Time A pointer to the current time.
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + * @retval EFI_INVALID_PARAMETER A time field is out of range.
> + * @retval EFI_DEVICE_ERROR The time could not be set due due to hardware error.
> + */
> +EFI_STATUS
> +EFIAPI
> +LibSetTime (
> + IN EFI_TIME *Time
> + )
> +{
> + EFI_STATUS Status;
> + UINTN EpochSeconds;
> +
> + EpochSeconds = EfiTimeToEpoch (Time);
> +
> + // Adjust for the correct time zone, i.e. convert to UTC time zone
> + if (Time->TimeZone != EFI_UNSPECIFIED_TIMEZONE) {
> + EpochSeconds -= Time->TimeZone * SEC_PER_MIN;
> + }
> +
> + // Adjust for the correct period, i.e. fall back one hour
> + if ((Time->Daylight & EFI_TIME_IN_DAYLIGHT) == EFI_TIME_IN_DAYLIGHT) {
> + EpochSeconds -= SEC_PER_HOUR;
> + }
> +
> + EpochToEfiTime (EpochSeconds, Time);
> +
> + Status = PlatformSetTime (Time);
> + if (EFI_ERROR (Status)) {
> + return Status;
> + }
> +
> + if (!EfiAtRuntime ()) {
> + mLastSavedTimeEpoch = EpochSeconds;
> + mLastSavedSystemCount = ArmGenericTimerGetSystemCount ();
> + }
> +
> + return EFI_SUCCESS;
> +}
> +
> +/**
> + * Returns the current wakeup alarm clock setting.
> + *
> + * @param Enabled Indicates if the alarm is currently enabled or disabled.
> + * @param Pending Indicates if the alarm signal is pending and requires acknowledgement.
> + * @param Time The current alarm setting.
> + *
> + * @retval EFI_SUCCESS The alarm settings were returned.
> + * @retval EFI_INVALID_PARAMETER Any parameter is NULL.
> + * @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved due to a hardware error.
> + */
> +EFI_STATUS
> +EFIAPI
> +LibGetWakeupTime (
> + OUT BOOLEAN *Enabled,
> + OUT BOOLEAN *Pending,
> + OUT EFI_TIME *Time
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> +
> +/**
> + * Sets the system wakeup alarm clock time.
> + *
> + * @param Enabled Enable or disable the wakeup alarm.
> + * @param Time If Enable is TRUE, the time to set the wakeup alarm for.
> + *
> + * @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alarm was enabled. If
> + * Enable is FALSE, then the wakeup alarm was disabled.
> + * @retval EFI_INVALID_PARAMETER A time field is out of range.
> + * @retval EFI_DEVICE_ERROR The wakeup time could not be set due to a hardware error.
> + * @retval EFI_UNSUPPORTED A wakeup timer is not supported on this platform.
> + */
> +EFI_STATUS
> +EFIAPI
> +LibSetWakeupTime (
> + IN BOOLEAN Enabled,
> + OUT EFI_TIME *Time
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> +
> +/**
> + Fixup internal data so that EFI can be call in virtual mode.
> + Call the passed in Child Notify event and convert any pointers in
> + lib to virtual mode.
> +
> + @param[in] Event The Event that is being processed
> + @param[in] Context Event Context
> +**/
> +VOID
> +EFIAPI
> +LibRtcVirtualNotifyEvent (
> + IN EFI_EVENT Event,
> + IN VOID *Context
> + )
> +{
> + //
> + // Only needed if you are going to support the OS calling RTC functions in virtual mode.
> + // You will need to call EfiConvertPointer (). To convert any stored physical addresses
> + // to virtual address. After the OS transitions to calling in virtual mode, all future
> + // runtime calls will be made in virtual mode.
> + //
> + PlatformVirtualAddressChangeEvent ();
> +}
> +
> +/**
> + * This is the declaration of an EFI image entry point. This can be the entry point to an application
> + * written to this specification, an EFI boot service driver, or an EFI runtime driver.
> + *
> + * @param ImageHandle Handle that identifies the loaded image.
> + * @param SystemTable System Table for this image.
> + *
> + * @retval EFI_SUCCESS The operation completed successfully.
> + */
> +EFI_STATUS
> +EFIAPI
> +LibRtcInitialize (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + EFI_STATUS Status;
> +
> + Status = PlatformInitialize ();
> + if (EFI_ERROR (Status)) {
> + return Status;
> + }
> +
> + //
> + // Register for the virtual address change event
> + //
> + Status = gBS->CreateEventEx (
> + EVT_NOTIFY_SIGNAL,
> + TPL_NOTIFY,
> + LibRtcVirtualNotifyEvent,
> + NULL,
> + &gEfiEventVirtualAddressChangeGuid,
> + &mVirtualAddressChangeEvent
> + );
> + ASSERT_EFI_ERROR (Status);
> +
> + return EFI_SUCCESS;
> +}
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-06-04 23:26 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 10:06 [edk2-platforms][PATCH v2 00/32] Add new Ampere Mt. Jade platform Nhi Pham
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 01/32] Ampere: Initial support for Ampere Altra processor and " Nhi Pham
2021-06-04 23:04 ` Leif Lindholm
2021-06-09 4:50 ` Nhi Pham
2021-06-09 12:40 ` Leif Lindholm
2021-06-15 16:46 ` Nhi Pham
2021-05-26 10:06 ` [PATCH 1/1] UsbCdcNetDxe: Remove reading connection status in SNP GetStatus Nhi Pham
2021-05-26 10:23 ` [edk2-devel] " Nhi Pham
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 02/32] AmpereAltraPkg: Add MmCommunication modules Nhi Pham
2021-06-04 23:05 ` Leif Lindholm
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 03/32] AmperePlatformPkg: Implement FailSafe library Nhi Pham
2021-06-04 23:07 ` Leif Lindholm
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 04/32] AmperePlatformPkg: Add FailSafe and WDT support Nhi Pham
2021-06-04 23:12 ` Leif Lindholm
2021-06-15 16:47 ` Nhi Pham
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 05/32] AmpereAltraPkg: Add DwI2cLib library Nhi Pham
2021-06-04 23:21 ` Leif Lindholm
2021-06-15 16:47 ` Nhi Pham
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 06/32] AmpereAltraPkg: Add DwGpioLib library Nhi Pham
2021-06-04 23:22 ` Leif Lindholm
2021-05-26 10:06 ` [edk2-platforms][PATCH v2 07/32] JadePkg: Implement RealTimeClockLib for PCF85063 Nhi Pham
2021-06-04 23:26 ` Leif Lindholm [this message]
2021-06-15 16:48 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 08/32] AmpereAltraPkg: Add BootProgress support Nhi Pham
2021-06-04 23:27 ` Leif Lindholm
2021-06-15 16:48 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 09/32] AmpereAltraPkg: Support non-volatile variables Nhi Pham
2021-06-04 23:36 ` Leif Lindholm
2021-06-15 16:48 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 10/32] AmpereSiliconPkg: Add PlatformManagerUiLib library instance Nhi Pham
2021-06-04 23:37 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 11/32] AmperePlatformPkg: Add AcpiPccLib to support ACPI PCCT Table Nhi Pham
2021-06-04 23:44 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 12/32] AmperePlatformPkg: Add AcpiHelperLib to update ACPI DSDT table Nhi Pham
2021-06-04 23:47 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 13/32] AmpereAltraPkg, JadePkg: Add ACPI support Nhi Pham
2021-06-04 23:50 ` Leif Lindholm
2021-06-15 16:49 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 14/32] AmpereAltraPkg: Add PcieCoreLib library instance Nhi Pham
2021-06-05 0:05 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 15/32] JadePkg: Add PcieBoardLib " Nhi Pham
2021-06-07 22:45 ` Leif Lindholm
2021-06-15 16:50 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 16/32] AmpereAltraPkg: Add PciHostBridge driver Nhi Pham
2021-06-08 22:26 ` Leif Lindholm
2021-06-09 5:29 ` Ard Biesheuvel
2021-06-15 15:54 ` Nhi Pham
2021-06-16 14:20 ` Ard Biesheuvel
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 17/32] JadePkg: Enable PCIe-related libraries and device drivers Nhi Pham
2021-06-07 22:51 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 18/32] JadePkg: Add ASpeed GOP driver Nhi Pham
2021-06-07 22:51 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 19/32] AmpereAltraPkg: Add Random Number Generator Support Nhi Pham
2021-06-08 11:13 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 20/32] JadePkg: Add SMBIOS tables support Nhi Pham
2021-06-07 23:00 ` Leif Lindholm
2021-06-15 16:51 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 21/32] AmpereAltraPkg: Add DebugInfoPei module Nhi Pham
2021-06-07 23:08 ` Leif Lindholm
2021-06-15 16:51 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 22/32] AmpereAltraPkg: Add platform info screen Nhi Pham
2021-06-07 23:10 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 23/32] AmpereAltraPkg: Add configuration screen for memory Nhi Pham
2021-06-07 23:14 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 24/32] AmpereAltraPkg: Add configuration screen for CPU Nhi Pham
2021-06-07 23:15 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 25/32] AmpereAltraPkg: Add configuration screen for ACPI Nhi Pham
2021-06-07 23:20 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 26/32] AmpereAltraPkg: Add configuration screen for RAS Nhi Pham
2021-06-07 23:22 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 27/32] AmpereAltraPkg: Add configuration screen for Watchdog timer Nhi Pham
2021-06-07 23:24 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 28/32] AmpereAltraPkg: Add configuration screen for Pcie Devices Nhi Pham
2021-06-07 23:34 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 29/32] JadePkg: Recover boot options when NVRAM cleared Nhi Pham
2021-06-07 23:46 ` Leif Lindholm
2021-06-15 16:52 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 30/32] AmpereSiliconPkg: Implement PlatformBootManagerLib for LinuxBoot Nhi Pham
2021-06-07 23:50 ` Leif Lindholm
2021-06-09 15:21 ` Nhi Pham
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 31/32] Platform/Ampere: Introduce the LinuxBootPkg Nhi Pham
2021-06-07 23:51 ` Leif Lindholm
2021-05-26 10:07 ` [edk2-platforms][PATCH v2 32/32] AmpereAltraPkg,JadePkg: Support LinuxBoot DSC/FDF build for Jade platform Nhi Pham
2021-06-07 23:58 ` Leif Lindholm
2021-06-09 15:20 ` Nhi Pham
2021-05-27 12:56 ` [edk2-platforms][PATCH v2 00/32] Add new Ampere Mt. " Leif Lindholm
2021-06-04 13:54 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604232615.zdpphdmxdj3kvg37@leviathan \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox