From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web09.5146.1623106276219917626 for ; Mon, 07 Jun 2021 15:51:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=t6LDQg/h; spf=pass (domain: nuviainc.com, ip: 209.85.128.45, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f45.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso664685wmh.4 for ; Mon, 07 Jun 2021 15:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iuHyUDfYjQek9wvDpKW36DoKEpfglH7baLPTh9zFbME=; b=t6LDQg/hON+q0JA+lHi1c4MbWSmPK4RqDWOS76haJw2d/7PaxW05J1Kems0XoxzSQ4 Ulb3TBlKtTo8a7W8EPRyQDC53Z2Da5ksPdemVongkn/WnMh7UudplZz++HVQVhdrZdRc 1HqynXGtQX3lNKXeMqsDtQSbwEKI3ez3EzKZimkCz6BqvDy82K/fcuGz/WhqgcVpF8nQ ef55L2ug9LozSgchTyyFATQAgFkUYcAamKLX1YVY/xLk9BO4eby/ppXpO98LWlkkQ7vV cVt9wvVQxpI5dQTMXPsutgkn3jLlQEznTdjcI1s22RjzL+vDqIIFr5m9XDyIPM7SWgt/ 9pXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iuHyUDfYjQek9wvDpKW36DoKEpfglH7baLPTh9zFbME=; b=MzKEOIH3DALRP8URhwjAfrrq7WA7PxW1GKfMER6vIEhIRkL9kr77WRXnSrGaSUjf6b Eb3wXSX5PVL3vWI8Q/4K6mra1c0XlntsJxe90MeB/g4a4wp8jvGupcr3GOk6I11wJirr vk4CMWOxzYTPj2KNS0/xsuXmXCS/9zw2xATF6Ozq6oyIzIGyykXZ5YHTGq5/i2C8YP0A HLdbhr9sPeE12Nb02YBrWTmzjpaeqtc8mgWpxsm3J9RQlYJ0xzIqq3ZtEJDNn9QLXwhB AWRIuSlo1/g1oSgUOzZ2mdC23Gwm8q30cLowx7tyWhPPVbB30ZtsdO7pdx8TekOCsxuu O2bQ== X-Gm-Message-State: AOAM530NH9aLnm8M0cWx49YAyFfuXA3z1qDcu8163i9sXvwiFqMzIyXm Obs683TXKAPlcJ1YNG+sLeUyBQ== X-Google-Smtp-Source: ABdhPJx7BlwqVXJBc3YXt88L4BGsEGmboS9ay0bAajwI6nGTZg890x6mDm6hLk1xRhUjgZ3cWLmdlQ== X-Received: by 2002:a1c:7402:: with SMTP id p2mr1179689wmc.88.1623106274689; Mon, 07 Jun 2021 15:51:14 -0700 (PDT) Return-Path: Received: from leviathan (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id w18sm17021403wrt.55.2021.06.07.15.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 15:51:14 -0700 (PDT) Date: Mon, 7 Jun 2021 23:51:12 +0100 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, Vu Nguyen , Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone Subject: Re: [edk2-platforms][PATCH v2 17/32] JadePkg: Enable PCIe-related libraries and device drivers Message-ID: <20210607225112.azk25bdtrm3cc6ky@leviathan> References: <20210526100724.5359-1-nhi@os.amperecomputing.com> <20210526100724.5359-19-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20210526100724.5359-19-nhi@os.amperecomputing.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 26, 2021 at 17:07:09 +0700, Nhi Pham wrote: > From: Vu Nguyen > > This change also enables the support for SCSI, NVMe, USB keyboard, and > USB storage devices. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ard Biesheuvel > Cc: Nate DeSimone > > Signed-off-by: Vu Nguyen Reviewed-by: Leif Lindholm / Leif > --- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 34 ++++++++++++++++++++ > Platform/Ampere/JadePkg/Jade.dsc | 5 +++ > Platform/Ampere/JadePkg/Jade.fdf | 33 +++++++++++++++++++ > 3 files changed, 72 insertions(+) > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > index fc8e0b40ee19..33f5fe7af544 100755 > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > @@ -83,6 +83,7 @@ [LibraryClasses.common] > NVParamLib|Silicon/Ampere/AmpereAltraPkg/Library/NVParamLib/NVParamLib.inf > MailboxInterfaceLib|Silicon/Ampere/AmpereAltraPkg/Library/MailboxInterfaceLib/MailboxInterfaceLib.inf > SystemFirmwareInterfaceLib|Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.inf > + PciePhyLib|Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf > PcieCoreLib|Silicon/Ampere/AmpereAltraPkg/Library/PcieCoreLib/PcieCoreLib.inf > AmpereCpuLib|Silicon/Ampere/AmpereAltraPkg/Library/AmpereCpuLib/AmpereCpuLib.inf > TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > @@ -648,6 +649,39 @@ [Components.common] > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > FatPkg/EnhancedFatDxe/Fat.inf > > + # > + # SCSI Bus and Disk Driver > + # > + MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # SATA Support > + # > + MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf > + > + # > + # NVME Support > + # > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > + # USB Support > + # > + MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > + MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + > + # > + # PCIe Support > + # > + MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + Silicon/Ampere/AmpereAltraPkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + > # > # Bds > # > diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc > index 0f9d0adbd34e..576e1c3ab663 100755 > --- a/Platform/Ampere/JadePkg/Jade.dsc > +++ b/Platform/Ampere/JadePkg/Jade.dsc > @@ -88,6 +88,11 @@ [LibraryClasses] > AcpiHelperLib|Platform/Ampere/AmperePlatformPkg/Library/AcpiHelperLib/AcpiHelperLib.inf > AcpiPccLib|Platform/Ampere/AmperePlatformPkg/Library/AcpiPccLib/AcpiPccLib.inf > > + # > + # Pcie Board > + # > + PcieBoardLib|Platform/Ampere/JadePkg/Library/PcieBoardLib/PcieBoardLib.inf > + > ################################################################################ > # > # Specific Platform Pcds > diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf > index 2c6f9fac76fd..fc47556b072b 100755 > --- a/Platform/Ampere/JadePkg/Jade.fdf > +++ b/Platform/Ampere/JadePkg/Jade.fdf > @@ -266,6 +266,39 @@ [FV.FvMain] > INF FatPkg/EnhancedFatDxe/Fat.inf > INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > + # > + # SCSI Bus and Disk Driver > + # > + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > + > + # > + # SATA Support > + # > + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + INF MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf > + > + # > + # NVME Support > + # > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > + # USB Support > + # > + INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + > + # > + # PCIe Support > + # > + INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF Silicon/Ampere/AmpereAltraPkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > + > # > # UEFI application (Shell Embedded Boot Loader) > # > -- > 2.17.1 >