Re: [edk2-platforms][PATCH v2 18/32] JadePkg: Add ASpeed GOP driver

["Leif Lindholm" <leif@nuviainc.com>]

On Wed, May 26, 2021 at 17:07:10 +0700, Nhi Pham wrote:
> This wires up the pre-built binary placed in the edk2-non-osi
> repository for PCIe VGA Controller support.
> 
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

/
    Leif

> ---
>  Platform/Ampere/JadePkg/Jade.dsc | 12 ++++++++++++
>  Platform/Ampere/JadePkg/Jade.fdf |  5 +++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc
> index 576e1c3ab663..6aaa644ad298 100755
> --- a/Platform/Ampere/JadePkg/Jade.dsc
> +++ b/Platform/Ampere/JadePkg/Jade.dsc
> @@ -115,6 +115,13 @@ [PcdsFixedAtBuild.common]
>  !endif
>  
>  
> +[PcdsPatchableInModule]
> +  #
> +  # Console Resolution (HD mode)
> +  #
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|768
> +
>  ################################################################################
>  #
>  # Specific Platform Component
> @@ -136,3 +143,8 @@ [Components.common]
>    Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf
>    Silicon/Ampere/AmpereAltraPkg/AcpiCommonTables/AcpiCommonTables.inf
>    Platform/Ampere/JadePkg/AcpiTables/AcpiTables.inf
> +
> +  #
> +  # VGA Aspeed
> +  #
> +  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf
> index fc47556b072b..6820a197568b 100755
> --- a/Platform/Ampere/JadePkg/Jade.fdf
> +++ b/Platform/Ampere/JadePkg/Jade.fdf
> @@ -299,6 +299,11 @@ [FV.FvMain]
>    INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>    INF Silicon/Ampere/AmpereAltraPkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>  
> +  #
> +  # VGA Aspeed
> +  #
> +  INF Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> +
>    #
>    # UEFI application (Shell Embedded Boot Loader)
>    #
> -- 
> 2.17.1
>