From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46])
 by mx.groups.io with SMTP id smtpd.web08.5035.1623106301832751685
 for <devel@edk2.groups.io>;
 Mon, 07 Jun 2021 15:51:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=yi34REd9;
 spf=pass (domain: nuviainc.com, ip: 209.85.221.46, mailfrom: leif@nuviainc.com)
Received: by mail-wr1-f46.google.com with SMTP id q5so19394818wrm.1
        for <devel@edk2.groups.io>; Mon, 07 Jun 2021 15:51:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=0yMmFswwGPUcrGc3/yhIurAPIbR8LLqYj9x1/C0cIxU=;
        b=yi34REd9foxVRc1vUMELdJLX0/q/FuwYrkax3CvUDkDgThY0vGrjBGKIUyrthLnah7
         0KNh0GfFgBK/42rFzlq5S4el9x0+bCLDM5zdcF+EVcajCW4hTf5G3nkiaC0lBKSjrxeD
         MqNJeRScd5K9mY8XmelX7J5KFuAHtsfGK1/VpaLL8aXVewCLquNyVVMYvRlxi++m+I4V
         F6g9mNoDr7FyWxfqbuvPvZQjWjDGZG7AEj3zWPbSkh81ZvAPOTUA3O/zLCmaAaW9nopg
         Hig/zvTklt3I637iEkWgBeaLrb65O+OZ11o/v1hu/UyKAPo7OSjzgUlOtJddYqWfmAGk
         zyxQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=0yMmFswwGPUcrGc3/yhIurAPIbR8LLqYj9x1/C0cIxU=;
        b=ApLJQNpF3OIbecyiRYVyJSxB2Pu2Frcz5ksNJPZb3BBjAaB/gMOVKr7/FbSOPn1g31
         8Ykmd2/P2akPEFzRgwb8A2EhqQpZux9hjwXqD3E3VJa2BaNvxa0fC1IbsPrl6hrt9uca
         UCzz/ga2AKYrmckL1L0Wc+JRkz+cuO3CLOciuD3JG6g5txd7TzSLls5CtjGrhEq9IwEQ
         F5bftG7oV7ElClk15mMmS9C/bvzVrgr+y+RIdVQe2t796Fjl2EN5mNTJYXHaIe2lFFR+
         T3pdqc364KYXyFI55/3ZbKL/6IWiBd0MPlIvm6AepsDDIzgAOeU1Eo/q32x7vjrtDw4s
         jjtQ==
X-Gm-Message-State: AOAM532vorpxRHSvzDSIUJL/Bxdy4EZnIh7MTaEUXtXWhyo70IqnZ6hG
	EBI4ztoNxOb5SNxAYsVsIGbAVw==
X-Google-Smtp-Source: ABdhPJxku/uaR2NVPsMxBUaGJxJEtr53u9EPTebsr9DbjgMfODlDCGrpCXOzIHtjrxX3/cioHvelSA==
X-Received: by 2002:adf:df09:: with SMTP id y9mr19374536wrl.108.1623106300408;
        Mon, 07 Jun 2021 15:51:40 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from leviathan (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148])
        by smtp.gmail.com with ESMTPSA id b135sm945175wmb.5.2021.06.07.15.51.39
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 07 Jun 2021 15:51:40 -0700 (PDT)
Date: Mon, 7 Jun 2021 23:51:38 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: devel@edk2.groups.io, Thang Nguyen <thang@os.amperecomputing.com>,
	Chuong Tran <chuong@os.amperecomputing.com>,
	Phong Vo <phong@os.amperecomputing.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platforms][PATCH v2 18/32] JadePkg: Add ASpeed GOP driver
Message-ID: <20210607225138.m735j3fqm6fkrq5m@leviathan>
References: <20210526100724.5359-1-nhi@os.amperecomputing.com>
 <20210526100724.5359-20-nhi@os.amperecomputing.com>
MIME-Version: 1.0
In-Reply-To: <20210526100724.5359-20-nhi@os.amperecomputing.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 26, 2021 at 17:07:10 +0700, Nhi Pham wrote:
> This wires up the pre-built binary placed in the edk2-non-osi
> repository for PCIe VGA Controller support.
> 
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>

/
    Leif

> ---
>  Platform/Ampere/JadePkg/Jade.dsc | 12 ++++++++++++
>  Platform/Ampere/JadePkg/Jade.fdf |  5 +++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc
> index 576e1c3ab663..6aaa644ad298 100755
> --- a/Platform/Ampere/JadePkg/Jade.dsc
> +++ b/Platform/Ampere/JadePkg/Jade.dsc
> @@ -115,6 +115,13 @@ [PcdsFixedAtBuild.common]
>  !endif
>  
>  
> +[PcdsPatchableInModule]
> +  #
> +  # Console Resolution (HD mode)
> +  #
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|768
> +
>  ################################################################################
>  #
>  # Specific Platform Component
> @@ -136,3 +143,8 @@ [Components.common]
>    Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf
>    Silicon/Ampere/AmpereAltraPkg/AcpiCommonTables/AcpiCommonTables.inf
>    Platform/Ampere/JadePkg/AcpiTables/AcpiTables.inf
> +
> +  #
> +  # VGA Aspeed
> +  #
> +  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf
> index fc47556b072b..6820a197568b 100755
> --- a/Platform/Ampere/JadePkg/Jade.fdf
> +++ b/Platform/Ampere/JadePkg/Jade.fdf
> @@ -299,6 +299,11 @@ [FV.FvMain]
>    INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>    INF Silicon/Ampere/AmpereAltraPkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>  
> +  #
> +  # VGA Aspeed
> +  #
> +  INF Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> +
>    #
>    # UEFI application (Shell Embedded Boot Loader)
>    #
> -- 
> 2.17.1
>