public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Vikas Singh <vikas.singh@puresoftware.com>
Cc: devel@edk2.groups.io, sami.mujawar@arm.com,
	meenakshi.aggarwal@nxp.com, samer.el-haj-mahmoud@arm.com,
	v.sethi@nxp.com, arokia.samy@puresoftware.com,
	kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com,
	vikas.singh@nxp.com, Sunny.Wang@arm.com
Subject: Re: [PATCH V0 0/4] Enable Dynamic ACPI for LS1046AFRWY
Date: Tue, 8 Jun 2021 12:11:53 +0100	[thread overview]
Message-ID: <20210608111153.s6t2ssmot3kmbdoy@leviathan> (raw)
In-Reply-To: <20210601135034.22386-1-vikas.singh@puresoftware.com>

Hi Vikas,

Please resubmit this set, following the instructions set out by
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers
as I requested for your previous set.

Best Regards,

Leif

On Tue, Jun 01, 2021 at 19:20:30 +0530, Vikas Singh wrote:
> This patch series basically aims to extend the Dynamic ACPI
> framework towards NXP's LS1046AFRWY platform.
> 
> Refer- https://edk2.groups.io/g/devel/message/71709
> 
> The change set in the series is in below order -
> 
> (1)Introducing a new platform specific macro "PLAT_SOC_NAME"
> This macro will be consumed by Configuration Manager(CM).
> Platforms who extends CM services for themselves must notify
> their SoC details to CM. Additionally also update the lx2160ardb
> platform header with PLAT_SOC_NAME, this will be consumed by CM.
> 
> (2)Introduced a function to get SoC's System Version Register(SVR)
> This function will fetch SVR for LS1046A SoC based platforms.
> In current patch series, this function will be used by LS1046aFrwy.
> 
> (3)Extending Configuration Manager (CM) and its services to leverage
> the Dynamic ACPI support for NXP's LS1046aFrwy platform.
> 
> (4)Introduced an OEM specific firmware acpi table generator
> Also add Dsdt.asl as a place holder having only platform's clock
> related dsdt properties for now and can accommodate other IP specific
> dsdt tables(acpi properties) for LS1046AFRWY in future patch series.
> 
> Vikas Singh (4):
>   Platform/NXP: Add generic log in CM to print SoC version
>   Silicon/NXP: Add support of SVR handling for LS1046FRWY
>   Platform/NXP/LS1046aFrwyPkg: Extend Dynamic ACPI support
>   Platform/NXP/LS1046aFrwyPkg: Add OEM specific DSDT generator
> 
>  .../ConfigurationManager.c                    |  10 +-
>  .../AcpiTablesInclude/Dsdt/Clk.asl            |  60 +++++++
>  .../AcpiTablesInclude/Dsdt/Dsdt.asl           |  15 ++
>  .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf |  39 +++++
>  .../PlatformAcpiDsdtLib/RawDsdtGenerator.c    | 138 +++++++++++++++
>  .../AcpiTablesInclude/PlatformAcpiLib.h       |  23 +++
>  .../NXP/LS1046aFrwyPkg/Include/Platform.h     | 159 ++++++++++++++++++
>  .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc     |  29 ++++
>  .../NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf     |  13 ++
>  Platform/NXP/LX2160aRdbPkg/Include/Platform.h |   5 +-
>  Silicon/NXP/LS1046A/LS1046A.dsc.inc           |  10 ++
>  Silicon/NXP/LS1046A/Library/SocLib/SocLib.c   |  16 ++
>  12 files changed, 507 insertions(+), 10 deletions(-)
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Clk.asl
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Dsdt.asl
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/PlatformAcpiLib.h
>  create mode 100644 Platform/NXP/LS1046aFrwyPkg/Include/Platform.h
> 
> -- 
> 2.25.1
> 

      parent reply	other threads:[~2021-06-08 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 13:50 [PATCH V0 0/4] Enable Dynamic ACPI for LS1046AFRWY Vikas Singh
2021-06-01 13:50 ` [PATCH V0 1/4] Platform/NXP: Add generic log in CM to print SoC version Vikas Singh
2021-06-01 13:50 ` [PATCH V0 2/4] Silicon/NXP: Add support of SVR handling for LS1046FRWY Vikas Singh
2021-06-01 13:50 ` [PATCH V0 3/4] Platform/NXP/LS1046aFrwyPkg: Extend Dynamic ACPI support Vikas Singh
2021-06-01 13:50 ` [PATCH V0 4/4] Platform/NXP/LS1046aFrwyPkg: Add OEM specific DSDT generator Vikas Singh
2021-06-08 11:11 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608111153.s6t2ssmot3kmbdoy@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox