From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.11306.1623154402586860865 for ; Tue, 08 Jun 2021 05:13:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aVdUKUpx; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623154401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vAroUjbr1N62W8AXVTo+ZevB0u58ena/ddyFFYfYQQs=; b=aVdUKUpxY9kboQin85S86wk/54h/2yRIqPfN2r5Q75IXHoswoBS1LRAaAAL1q8dyEbDDDc fKt0mhYZ69MWVEkXYyWJghSpjJRYtwrhudQMvlGH4UNoZ3bbLezAiNIUkb2cO42T1U8yVL TIwDgJIuALRS31bwXNkFiGkYz0CmzH0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-F_jHPkcXOAmisKzLCbdBWg-1; Tue, 08 Jun 2021 08:13:19 -0400 X-MC-Unique: F_jHPkcXOAmisKzLCbdBWg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9B88107ACCD; Tue, 8 Jun 2021 12:13:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-27.ams2.redhat.com [10.36.113.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B98F620DE; Tue, 8 Jun 2021 12:13:16 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Maciej Rabeda , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Siyuan Fu Subject: [PUBLIC edk2 PATCH v2 10/10] NetworkPkg/IScsiDxe: check IScsiHexToBin() return values Date: Tue, 8 Jun 2021 14:12:59 +0200 Message-Id: <20210608121259.32451-11-lersek@redhat.com> In-Reply-To: <20210608121259.32451-1-lersek@redhat.com> References: <20210608121259.32451-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 SVNjc2lEeGUgKHRoYXQgaXMsIHRoZSBpbml0aWF0b3IpIHJlY2VpdmVzIHR3byBoZXgtZW5jb2Rl ZCBzdHJpbmdzIGZyb20KdGhlIGlTQ1NJIHRhcmdldDoKCi0gQ0hBUF9DLCB3aGVyZSB0aGUgdGFy Z2V0IGNoYWxsZW5nZXMgdGhlIGluaXRpYXRvciwKCi0gQ0hBUF9SLCB3aGVyZSB0aGUgdGFyZ2V0 IGFuc3dlcnMgdGhlIGNoYWxsZW5nZSBmcm9tIHRoZSBpbml0aWF0b3IgKGluCiAgY2FzZSB0aGUg aW5pdGlhdG9yIHdhbnRzIG11dHVhbCBhdXRoZW50aWNhdGlvbikuCgpBY2NvcmRpbmdseSwgd2Ug aGF2ZSB0d28gSVNjc2lIZXhUb0JpbigpIGNhbGwgc2l0ZXM6CgotIEF0IHRoZSBDSEFQX0MgZGVj b2Rpbmcgc2l0ZSwgY2hlY2sgd2hldGhlciB0aGUgZGVjb2Rpbmcgc3VjY2VlZHMuIFRoZQogIGRl Y29kZWQgYnVmZmVyICgiQXV0aERhdGEtPkluQ2hhbGxlbmdlIikgY2FuIGFjY29tbW9kYXRlIDEw MjQgYnl0ZXMsCiAgd2hpY2ggaXMgYSBwZXJtaXNzaWJsZSByZXN0cmljdGlvbiBvbiB0aGUgdGFy Z2V0LCBwZXIKICA8aHR0cHM6Ly90b29scy5pZXRmLm9yZy9odG1sL3JmYzcxNDMjc2VjdGlvbi0x Mi4xLjM+LiBTaG9ydGVyIGNoYWxsZW5nZXMKICBmcm9tIHRoZSB0YXJnZXQgYXJlIGFjY2VwdGFi bGUuCgotIEF0IHRoZSBDSEFQX1IgZGVjb2Rpbmcgc2l0ZSwgZW5mb3JjZSB0aGF0IHRoZSBkZWNv ZGluZyBib3RoIHN1Y2NlZWQsIGFuZAogIHByb3ZpZGUgZXhhY3RseSBJU0NTSV9DSEFQX1JTUF9M RU4gYnl0ZXMuIENIQVBfUiBjb250YWlucyB0aGUgZGlnZXN0CiAgY2FsY3VsYXRlZCBieSB0aGUg dGFyZ2V0LCB0aGVyZWZvcmUgaXQgbXVzdCBiZSBvZiBmaXhlZCBzaXplLiBXZSBtYXkKICBvbmx5 IGNhbGwgSVNjc2lDSEFQQXV0aFRhcmdldCgpIGlmICJUYXJnZXRSc3AiIGhhcyBiZWVuIGZ1bGx5 IHBvcHVsYXRlZC4KCkNjOiBKaWF4aW4gV3UgPGppYXhpbi53dUBpbnRlbC5jb20+CkNjOiBNYWNp ZWogUmFiZWRhIDxtYWNpZWoucmFiZWRhQGxpbnV4LmludGVsLmNvbT4KQ2M6IFBoaWxpcHBlIE1h dGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KQ2M6IFNpeXVhbiBGdSA8c2l5dWFuLmZ1 QGludGVsLmNvbT4KUmVmOiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcu Y2dpP2lkPTMzNTYKU2lnbmVkLW9mZi1ieTogTGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNv bT4KUmV2aWV3ZWQtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNv bT4KUmV2aWV3ZWQtYnk6IE1hY2llaiBSYWJlZGEgPG1hY2llai5yYWJlZGFAbGludXguaW50ZWwu Y29tPgotLS0KIE5ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lDSEFQLmMgfCAyMCArKysrKysrKysr KysrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2NzaUNIQVAuYyBiL05ldHdv cmtQa2cvSVNjc2lEeGUvSVNjc2lDSEFQLmMKaW5kZXggZGJlM2M4ZWY0NmY5Li43ZTkzMGMwZDFl YWIgMTAwNjQ0Ci0tLSBhL05ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lDSEFQLmMKKysrIGIvTmV0 d29ya1BrZy9JU2NzaUR4ZS9JU2NzaUNIQVAuYwpAQCAtMjc0LDQzICsyNzQsNDcgQEAgSVNjc2lD SEFQT25Sc3BSZWNlaXZlZCAoCiANCiAgICAgQ2hhbGxlbmdlID0gSVNjc2lHZXRWYWx1ZUJ5S2V5 RnJvbUxpc3QgKA0KICAgICAgICAgICAgICAgICAgIEtleVZhbHVlTGlzdCwNCiAgICAgICAgICAg ICAgICAgICBJU0NTSV9LRVlfQ0hBUF9DSEFMTEVOR0UNCiAgICAgICAgICAgICAgICAgICApOw0K ICAgICBpZiAoQ2hhbGxlbmdlID09IE5VTEwpIHsNCiAgICAgICBnb3RvIE9OX0VYSVQ7DQogICAg IH0NCiAgICAgLy8NCiAgICAgLy8gUHJvY2VzcyB0aGUgQ0hBUCBpZGVudGlmaWVyIGFuZCBDSEFQ IENoYWxsZW5nZSBmcm9tIFRhcmdldC4NCiAgICAgLy8gQ2FsY3VsYXRlIFJlc3BvbnNlIHZhbHVl Lg0KICAgICAvLw0KICAgICBSZXN1bHQgPSBJU2NzaU5ldE50b2kgKElkZW50aWZpZXIpOw0KICAg ICBpZiAoUmVzdWx0ID4gMHhGRikgew0KICAgICAgIGdvdG8gT05fRVhJVDsNCiAgICAgfQ0KIA0K ICAgICBBdXRoRGF0YS0+SW5JZGVudGlmaWVyICAgICAgPSAoVUlOVDMyKSBSZXN1bHQ7DQogICAg IEF1dGhEYXRhLT5JbkNoYWxsZW5nZUxlbmd0aCA9IChVSU5UMzIpIHNpemVvZiAoQXV0aERhdGEt PkluQ2hhbGxlbmdlKTsNCi0gICAgSVNjc2lIZXhUb0JpbiAoDQotICAgICAgKFVJTlQ4ICopIEF1 dGhEYXRhLT5JbkNoYWxsZW5nZSwNCi0gICAgICAmQXV0aERhdGEtPkluQ2hhbGxlbmdlTGVuZ3Ro LA0KLSAgICAgIENoYWxsZW5nZQ0KLSAgICAgICk7DQorICAgIFN0YXR1cyA9IElTY3NpSGV4VG9C aW4gKA0KKyAgICAgICAgICAgICAgIChVSU5UOCAqKSBBdXRoRGF0YS0+SW5DaGFsbGVuZ2UsDQor ICAgICAgICAgICAgICAgJkF1dGhEYXRhLT5JbkNoYWxsZW5nZUxlbmd0aCwNCisgICAgICAgICAg ICAgICBDaGFsbGVuZ2UNCisgICAgICAgICAgICAgICApOw0KKyAgICBpZiAoRUZJX0VSUk9SIChT dGF0dXMpKSB7DQorICAgICAgU3RhdHVzID0gRUZJX1BST1RPQ09MX0VSUk9SOw0KKyAgICAgIGdv dG8gT05fRVhJVDsNCisgICAgfQ0KICAgICBTdGF0dXMgPSBJU2NzaUNIQVBDYWxjdWxhdGVSZXNw b25zZSAoDQogICAgICAgICAgICAgICAgQXV0aERhdGEtPkluSWRlbnRpZmllciwNCiAgICAgICAg ICAgICAgICBBdXRoRGF0YS0+QXV0aENvbmZpZy0+Q0hBUFNlY3JldCwNCiAgICAgICAgICAgICAg ICAoVUlOVDMyKSBBc2NpaVN0ckxlbiAoQXV0aERhdGEtPkF1dGhDb25maWctPkNIQVBTZWNyZXQp LA0KICAgICAgICAgICAgICAgIEF1dGhEYXRhLT5JbkNoYWxsZW5nZSwNCiAgICAgICAgICAgICAg ICBBdXRoRGF0YS0+SW5DaGFsbGVuZ2VMZW5ndGgsDQogICAgICAgICAgICAgICAgQXV0aERhdGEt PkNIQVBSZXNwb25zZQ0KICAgICAgICAgICAgICAgICk7DQogDQogICAgIC8vDQogICAgIC8vIFRy YW5zaXQgdG8gbmV4dCBzdGVwLg0KICAgICAvLw0KICAgICBDb25uLT5BdXRoU3RlcCA9IElTQ1NJ X0NIQVBfU1RFUF9USFJFRTsNCiAgICAgYnJlYWs7DQogDQogICBjYXNlIElTQ1NJX0NIQVBfU1RF UF9USFJFRToNCiAgICAgLy8NCiAgICAgLy8gT25lIHdheSBDSEFQIGF1dGhlbnRpY2F0aW9uIGFu ZCB0aGUgdGFyZ2V0IHdvdWxkIGxpa2UgdG8NCiAgICAgLy8gYXV0aGVudGljYXRlIHVzLg0KQEAg LTMyMSwzOSArMzI1LDQzIEBAIElTY3NpQ0hBUE9uUnNwUmVjZWl2ZWQgKAogICBjYXNlIElTQ1NJ X0NIQVBfU1RFUF9GT1VSOg0KICAgICBBU1NFUlQgKEF1dGhEYXRhLT5BdXRoQ29uZmlnLT5DSEFQ VHlwZSA9PSBJU0NTSV9DSEFQX01VVFVBTCk7DQogICAgIC8vDQogICAgIC8vIFRoZSBmb3J0aCBz dGVwLCBDSEFQX049PE4+IENIQVBfUj08Uj4gaXMgcmVjZWl2ZWQgZnJvbSBUYXJnZXQuDQogICAg IC8vDQogICAgIE5hbWUgPSBJU2NzaUdldFZhbHVlQnlLZXlGcm9tTGlzdCAoS2V5VmFsdWVMaXN0 LCBJU0NTSV9LRVlfQ0hBUF9OQU1FKTsNCiAgICAgaWYgKE5hbWUgPT0gTlVMTCkgew0KICAgICAg IGdvdG8gT05fRVhJVDsNCiAgICAgfQ0KIA0KICAgICBSZXNwb25zZSA9IElTY3NpR2V0VmFsdWVC eUtleUZyb21MaXN0ICgNCiAgICAgICAgICAgICAgICAgIEtleVZhbHVlTGlzdCwNCiAgICAgICAg ICAgICAgICAgIElTQ1NJX0tFWV9DSEFQX1JFU1BPTlNFDQogICAgICAgICAgICAgICAgICApOw0K ICAgICBpZiAoUmVzcG9uc2UgPT0gTlVMTCkgew0KICAgICAgIGdvdG8gT05fRVhJVDsNCiAgICAg fQ0KIA0KICAgICBSc3BMZW4gPSBJU0NTSV9DSEFQX1JTUF9MRU47DQotICAgIElTY3NpSGV4VG9C aW4gKFRhcmdldFJzcCwgJlJzcExlbiwgUmVzcG9uc2UpOw0KKyAgICBTdGF0dXMgPSBJU2NzaUhl eFRvQmluIChUYXJnZXRSc3AsICZSc3BMZW4sIFJlc3BvbnNlKTsNCisgICAgaWYgKEVGSV9FUlJP UiAoU3RhdHVzKSB8fCBSc3BMZW4gIT0gSVNDU0lfQ0hBUF9SU1BfTEVOKSB7DQorICAgICAgU3Rh dHVzID0gRUZJX1BST1RPQ09MX0VSUk9SOw0KKyAgICAgIGdvdG8gT05fRVhJVDsNCisgICAgfQ0K IA0KICAgICAvLw0KICAgICAvLyBDaGVjayB0aGUgQ0hBUCBOYW1lIGFuZCBSZXNwb25zZSByZXBs aWVkIGJ5IFRhcmdldC4NCiAgICAgLy8NCiAgICAgU3RhdHVzID0gSVNjc2lDSEFQQXV0aFRhcmdl dCAoQXV0aERhdGEsIFRhcmdldFJzcCk7DQogICAgIGJyZWFrOw0KIA0KICAgZGVmYXVsdDoNCiAg ICAgYnJlYWs7DQogICB9DQogDQogT05fRVhJVDoNCiANCiAgIGlmIChLZXlWYWx1ZUxpc3QgIT0g TlVMTCkgew0KICAgICBJU2NzaUZyZWVLZXlWYWx1ZUxpc3QgKEtleVZhbHVlTGlzdCk7DQogICB9 DQogDQogICBGcmVlUG9vbCAoRGF0YSk7DQogDQotLSAKMi4xOS4xLjMuZzMwMjQ3YWE1ZDIwMQoK