From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.11416.1623154396997963767 for ; Tue, 08 Jun 2021 05:13:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ik9rgc7g; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623154396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lzjbBBNwYY3+XLdYQXV22aRMQl+aHx/w0QaQ9kIcWHc=; b=Ik9rgc7g8UYetC9swhTKYspbMHPgtjRa7qKaycbHOL8vXoLeOLKqYHBVphc2CQL3cSjok/ +k0SmyCFQ106i5JNxXAWXJrS5qfsJVq5CUoynmUoYPalzEbNBos96X8pD8AxGCOgmAPNoj U2sOyI68db+dKv6+EXpSaazY/ZcmJ+E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-DL52HgSDN4Cbbm_XlmNI9w-1; Tue, 08 Jun 2021 08:13:12 -0400 X-MC-Unique: DL52HgSDN4Cbbm_XlmNI9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8958E106BAA7; Tue, 8 Jun 2021 12:13:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-27.ams2.redhat.com [10.36.113.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D4CE620DE; Tue, 8 Jun 2021 12:13:10 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Maciej Rabeda , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Siyuan Fu Subject: [PUBLIC edk2 PATCH v2 06/10] NetworkPkg/IScsiDxe: assert that IScsiBinToHex() always succeeds Date: Tue, 8 Jun 2021 14:12:55 +0200 Message-Id: <20210608121259.32451-7-lersek@redhat.com> In-Reply-To: <20210608121259.32451-1-lersek@redhat.com> References: <20210608121259.32451-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 SVNjc2lCaW5Ub0hleCgpIGlzIGNhbGxlZCBmb3IgZW5jb2Rpbmc6CgotIHRoZSBhbnN3ZXIgdG8g dGhlIHRhcmdldCdzIGNoYWxsZW5nZTsgdGhhdCBpcywgQ0hBUF9SOwoKLSB0aGUgY2hhbGxlbmdl IGZvciB0aGUgdGFyZ2V0LCBpbiBjYXNlIG11dHVhbCBhdXRoZW50aWNhdGlvbiBpcyBlbmFibGVk OwogIHRoYXQgaXMsIENIQVBfQy4KClRoZSBpbml0aWF0b3IgY29udHJvbHMgdGhlIHNpemUgb2Yg Ym90aCBibG9icywgdGhlIHNpemVzIG9mIHRoZWlyIGhleAplbmNvZGluZ3MgYXJlIGNvcnJlY3Rs eSBjYWxjdWxhdGVkIGluICJSc3BMZW4iIGFuZCAiQ2hhbGxlbmdlTGVuIi4KVGhlcmVmb3JlIHRo ZSBJU2NzaUJpblRvSGV4KCkgY2FsbHMgbmV2ZXIgZmFpbDsgYXNzZXJ0IHRoYXQuCgpDYzogSmlh eGluIFd1IDxqaWF4aW4ud3VAaW50ZWwuY29tPgpDYzogTWFjaWVqIFJhYmVkYSA8bWFjaWVqLnJh YmVkYUBsaW51eC5pbnRlbC5jb20+CkNjOiBQaGlsaXBwZSBNYXRoaWV1LURhdWTDqSA8cGhpbG1k QHJlZGhhdC5jb20+CkNjOiBTaXl1YW4gRnUgPHNpeXVhbi5mdUBpbnRlbC5jb20+ClJlZjogaHR0 cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzU2ClNpZ25lZC1v ZmYtYnk6IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+ClJldmlld2VkLWJ5OiBQaGls aXBwZSBNYXRoaWV1LURhdWTDqSA8cGhpbG1kQHJlZGhhdC5jb20+ClJldmlld2VkLWJ5OiBNYWNp ZWogUmFiZWRhIDxtYWNpZWoucmFiZWRhQGxpbnV4LmludGVsLmNvbT4KLS0tCiBOZXR3b3JrUGtn L0lTY3NpRHhlL0lTY3NpQ0hBUC5jIHwgMjcgKysrKysrKysrKystLS0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9O ZXR3b3JrUGtnL0lTY3NpRHhlL0lTY3NpQ0hBUC5jIGIvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2Nz aUNIQVAuYwppbmRleCA5ZTE5MmNlMjkyZTguLmRiZTNjOGVmNDZmOSAxMDA2NDQKLS0tIGEvTmV0 d29ya1BrZy9JU2NzaUR4ZS9JU2NzaUNIQVAuYworKysgYi9OZXR3b3JrUGtnL0lTY3NpRHhlL0lT Y3NpQ0hBUC5jCkBAIC0zNzUsMzggKzM3NSwzOSBAQCBJU2NzaUNIQVBPblJzcFJlY2VpdmVkICgK ICAgQHJldHZhbCBFRklfUFJPVE9DT0xfRVJST1IgICAgU29tZSBraW5kIG9mIHByb3RvY29sIGVy cm9yIG9jY3VycmVkLg0KIA0KICoqLw0KIEVGSV9TVEFUVVMNCiBJU2NzaUNIQVBUb1NlbmRSZXEg KA0KICAgSU4gICAgICBJU0NTSV9DT05ORUNUSU9OICAqQ29ubiwNCiAgIElOIE9VVCAgTkVUX0JV RiAgICAgICAgICAgKlBkdQ0KICAgKQ0KIHsNCiAgIEVGSV9TVEFUVVMgICAgICAgICAgICAgICAg ICBTdGF0dXM7DQogICBJU0NTSV9TRVNTSU9OICAgICAgICAgICAgICAgKlNlc3Npb247DQogICBJ U0NTSV9MT0dJTl9SRVFVRVNUICAgICAgICAgKkxvZ2luUmVxOw0KICAgSVNDU0lfQ0hBUF9BVVRI X0RBVEEgICAgICAgICpBdXRoRGF0YTsNCiAgIENIQVI4ICAgICAgICAgICAgICAgICAgICAgICAq VmFsdWU7DQogICBDSEFSOCAgICAgICAgICAgICAgICAgICAgICAgVmFsdWVTdHJbMjU2XTsNCiAg IENIQVI4ICAgICAgICAgICAgICAgICAgICAgICAqUmVzcG9uc2U7DQogICBVSU5UMzIgICAgICAg ICAgICAgICAgICAgICAgUnNwTGVuOw0KICAgQ0hBUjggICAgICAgICAgICAgICAgICAgICAgICpD aGFsbGVuZ2U7DQogICBVSU5UMzIgICAgICAgICAgICAgICAgICAgICAgQ2hhbGxlbmdlTGVuOw0K KyAgRUZJX1NUQVRVUyAgICAgICAgICAgICAgICAgIEJpblRvSGV4U3RhdHVzOw0KIA0KICAgQVNT RVJUIChDb25uLT5DdXJyZW50U3RhZ2UgPT0gSVNDU0lfU0VDVVJJVFlfTkVHT1RJQVRJT04pOw0K IA0KICAgU2Vzc2lvbiAgICAgPSBDb25uLT5TZXNzaW9uOw0KICAgQXV0aERhdGEgICAgPSAmU2Vz c2lvbi0+QXV0aERhdGEuQ0hBUDsNCiAgIExvZ2luUmVxICAgID0gKElTQ1NJX0xPR0lOX1JFUVVF U1QgKikgTmV0YnVmR2V0Qnl0ZSAoUGR1LCAwLCAwKTsNCiAgIGlmIChMb2dpblJlcSA9PSBOVUxM KSB7DQogICAgIHJldHVybiBFRklfUFJPVE9DT0xfRVJST1I7DQogICB9DQogICBTdGF0dXMgICAg ICA9IEVGSV9TVUNDRVNTOw0KIA0KICAgUnNwTGVuICAgICAgPSAyICogSVNDU0lfQ0hBUF9SU1Bf TEVOICsgMzsNCiAgIFJlc3BvbnNlICAgID0gQWxsb2NhdGVaZXJvUG9vbCAoUnNwTGVuKTsNCiAg IGlmIChSZXNwb25zZSA9PSBOVUxMKSB7DQogICAgIHJldHVybiBFRklfT1VUX09GX1JFU09VUkNF UzsNCiAgIH0NCiANCiAgIENoYWxsZW5nZUxlbiAgPSAyICogSVNDU0lfQ0hBUF9SU1BfTEVOICsg MzsNCiAgIENoYWxsZW5nZSAgICAgPSBBbGxvY2F0ZVplcm9Qb29sIChDaGFsbGVuZ2VMZW4pOw0K QEAgLTQ1NSw2MyArNDU2LDY1IEBAIElTY3NpQ0hBUFRvU2VuZFJlcSAoCiAgICAgQ29ubi0+QXV0 aFN0ZXAgPSBJU0NTSV9DSEFQX1NURVBfVFdPOw0KICAgICBicmVhazsNCiANCiAgIGNhc2UgSVND U0lfQ0hBUF9TVEVQX1RIUkVFOg0KICAgICAvLw0KICAgICAvLyBUaGlyZCBzdGVwLCBzZW5kIHRo ZSBMb2dpbiBSZXF1ZXN0IHdpdGggQ0hBUF9OPTxOPiBDSEFQX1I9PFI+IG9yDQogICAgIC8vIENI QVBfTj08Tj4gQ0hBUF9SPTxSPiBDSEFQX0k9PEk+IENIQVBfQz08Qz4gaWYgdGFyZ2V0IGF1dGhl bnRpY2F0aW9uIGlzDQogICAgIC8vIHJlcXVpcmVkIHRvby4NCiAgICAgLy8NCiAgICAgLy8gQ0hB UF9OPTxOPg0KICAgICAvLw0KICAgICBJU2NzaUFkZEtleVZhbHVlUGFpciAoDQogICAgICAgUGR1 LA0KICAgICAgIElTQ1NJX0tFWV9DSEFQX05BTUUsDQogICAgICAgKENIQVI4ICopICZBdXRoRGF0 YS0+QXV0aENvbmZpZy0+Q0hBUE5hbWUNCiAgICAgICApOw0KICAgICAvLw0KICAgICAvLyBDSEFQ X1I9PFI+DQogICAgIC8vDQotICAgIElTY3NpQmluVG9IZXggKA0KLSAgICAgIChVSU5UOCAqKSBB dXRoRGF0YS0+Q0hBUFJlc3BvbnNlLA0KLSAgICAgIElTQ1NJX0NIQVBfUlNQX0xFTiwNCi0gICAg ICBSZXNwb25zZSwNCi0gICAgICAmUnNwTGVuDQotICAgICAgKTsNCisgICAgQmluVG9IZXhTdGF0 dXMgPSBJU2NzaUJpblRvSGV4ICgNCisgICAgICAgICAgICAgICAgICAgICAgIChVSU5UOCAqKSBB dXRoRGF0YS0+Q0hBUFJlc3BvbnNlLA0KKyAgICAgICAgICAgICAgICAgICAgICAgSVNDU0lfQ0hB UF9SU1BfTEVOLA0KKyAgICAgICAgICAgICAgICAgICAgICAgUmVzcG9uc2UsDQorICAgICAgICAg ICAgICAgICAgICAgICAmUnNwTGVuDQorICAgICAgICAgICAgICAgICAgICAgICApOw0KKyAgICBB U1NFUlRfRUZJX0VSUk9SIChCaW5Ub0hleFN0YXR1cyk7DQogICAgIElTY3NpQWRkS2V5VmFsdWVQ YWlyIChQZHUsIElTQ1NJX0tFWV9DSEFQX1JFU1BPTlNFLCBSZXNwb25zZSk7DQogDQogICAgIGlm IChBdXRoRGF0YS0+QXV0aENvbmZpZy0+Q0hBUFR5cGUgPT0gSVNDU0lfQ0hBUF9NVVRVQUwpIHsN CiAgICAgICAvLw0KICAgICAgIC8vIENIQVBfST08ST4NCiAgICAgICAvLw0KICAgICAgIElTY3Np R2VuUmFuZG9tICgoVUlOVDggKikgJkF1dGhEYXRhLT5PdXRJZGVudGlmaWVyLCAxKTsNCiAgICAg ICBBc2NpaVNQcmludCAoVmFsdWVTdHIsIHNpemVvZiAoVmFsdWVTdHIpLCAiJWQiLCBBdXRoRGF0 YS0+T3V0SWRlbnRpZmllcik7DQogICAgICAgSVNjc2lBZGRLZXlWYWx1ZVBhaXIgKFBkdSwgSVND U0lfS0VZX0NIQVBfSURFTlRJRklFUiwgVmFsdWVTdHIpOw0KICAgICAgIC8vDQogICAgICAgLy8g Q0hBUF9DPTxDPg0KICAgICAgIC8vDQogICAgICAgSVNjc2lHZW5SYW5kb20gKChVSU5UOCAqKSBB dXRoRGF0YS0+T3V0Q2hhbGxlbmdlLCBJU0NTSV9DSEFQX1JTUF9MRU4pOw0KLSAgICAgIElTY3Np QmluVG9IZXggKA0KLSAgICAgICAgKFVJTlQ4ICopIEF1dGhEYXRhLT5PdXRDaGFsbGVuZ2UsDQot ICAgICAgICBJU0NTSV9DSEFQX1JTUF9MRU4sDQotICAgICAgICBDaGFsbGVuZ2UsDQotICAgICAg ICAmQ2hhbGxlbmdlTGVuDQotICAgICAgICApOw0KKyAgICAgIEJpblRvSGV4U3RhdHVzID0gSVNj c2lCaW5Ub0hleCAoDQorICAgICAgICAgICAgICAgICAgICAgICAgIChVSU5UOCAqKSBBdXRoRGF0 YS0+T3V0Q2hhbGxlbmdlLA0KKyAgICAgICAgICAgICAgICAgICAgICAgICBJU0NTSV9DSEFQX1JT UF9MRU4sDQorICAgICAgICAgICAgICAgICAgICAgICAgIENoYWxsZW5nZSwNCisgICAgICAgICAg ICAgICAgICAgICAgICAgJkNoYWxsZW5nZUxlbg0KKyAgICAgICAgICAgICAgICAgICAgICAgICAp Ow0KKyAgICAgIEFTU0VSVF9FRklfRVJST1IgKEJpblRvSGV4U3RhdHVzKTsNCiAgICAgICBJU2Nz aUFkZEtleVZhbHVlUGFpciAoUGR1LCBJU0NTSV9LRVlfQ0hBUF9DSEFMTEVOR0UsIENoYWxsZW5n ZSk7DQogDQogICAgICAgQ29ubi0+QXV0aFN0ZXAgPSBJU0NTSV9DSEFQX1NURVBfRk9VUjsNCiAg ICAgfQ0KICAgICAvLw0KICAgICAvLyBTZXQgdGhlIHN0YWdlIHRyYW5zaXRpb24gZmxhZy4NCiAg ICAgLy8NCiAgICAgSVNDU0lfU0VUX0ZMQUcgKExvZ2luUmVxLCBJU0NTSV9MT0dJTl9SRVFfUERV X0ZMQUdfVFJBTlNJVCk7DQogICAgIGJyZWFrOw0KIA0KICAgZGVmYXVsdDoNCiAgICAgU3RhdHVz ID0gRUZJX1BST1RPQ09MX0VSUk9SOw0KICAgICBicmVhazsNCiAgIH0NCiANCiAgIEZyZWVQb29s IChSZXNwb25zZSk7DQogICBGcmVlUG9vbCAoQ2hhbGxlbmdlKTsNCiANCiAgIHJldHVybiBTdGF0 dXM7DQotLSAKMi4xOS4xLjMuZzMwMjQ3YWE1ZDIwMQoKCg==