From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.11514.1623154400169553379 for ; Tue, 08 Jun 2021 05:13:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JL0omk/0; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623154399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCZqp7zGXlu7oW4R+Gp86Qe1wnjH2XndSWP7KwezK7I=; b=JL0omk/0ye9cCmtEzCgzuvmH1/A0Ydj41CAVi77/A4Mt7EfTSkOmqEB2oz+0CqN75H1Ctq HPiUK3Oaa3Kl6Go3z3arycbEiuT5uZBUFnLDWJ2jdf5k82byZ9MCChJcXL4fS0m2GS2HFJ x50C9Uvwk4AtBKT+idui/KQFI5fJXTc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257--Tz5uiQlOh2fZGwz1dCsdg-1; Tue, 08 Jun 2021 08:13:15 -0400 X-MC-Unique: -Tz5uiQlOh2fZGwz1dCsdg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7BCB107ACF2; Tue, 8 Jun 2021 12:13:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-27.ams2.redhat.com [10.36.113.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7087E197F9; Tue, 8 Jun 2021 12:13:13 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Maciej Rabeda , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Siyuan Fu Subject: [PUBLIC edk2 PATCH v2 08/10] NetworkPkg/IScsiDxe: fix IScsiHexToBin() hex parsing Date: Tue, 8 Jun 2021 14:12:57 +0200 Message-Id: <20210608121259.32451-9-lersek@redhat.com> In-Reply-To: <20210608121259.32451-1-lersek@redhat.com> References: <20210608121259.32451-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 VGhlIElTY3NpSGV4VG9CaW4oKSBmdW5jdGlvbiBoYXMgdGhlIGZvbGxvd2luZyBwYXJzZXIgaXNz dWVzOgoKKDEpIElmIHRoZSAqc3ViamVjdCBzZXF1ZW5jZSogaW4gIkhleFN0ciIgaXMgZW1wdHks IHRoZSBmdW5jdGlvbiByZXR1cm5zCiAgICBFRklfU1VDQ0VTUyAod2l0aCAiQmluTGVuZ3RoIiBz ZXQgdG8gMCBvbiBvdXRwdXQpLiBTdWNoIGlucHV0cyBzaG91bGQKICAgIGJlIHJlamVjdGVkLgoK KDIpIFRoZSBmdW5jdGlvbiBtaXMtaGFuZGxlcyBhICJIZXhTdHIiIHRoYXQgZW5kcyB3aXRoIGEg c3RyYXkgbmliYmxlLiBGb3IKICAgIGV4YW1wbGUsIGlmICJIZXhTdHIiIGlzICIweEFCQyIsIHRo ZSBmdW5jdGlvbiBkZWNvZGVzIGl0IHRvIHRoZSBieXRlcwogICAgezB4QUIsIDB4MEN9LCBzZXRz ICJCaW5MZW5ndGgiIHRvIDIgb24gb3V0cHV0LCBhbmQgcmV0dXJucwogICAgRUZJX1NVQ0NFU1Mu IFN1Y2ggaW5wdXRzIHNob3VsZCBiZSByZWplY3RlZC4KCigzKSBJZiBhbiBpbnZhbGlkIGhleCBj aGFyIGlzIGZvdW5kIGluICJIZXhTdHIiLCB0aGUgZnVuY3Rpb24gdHJlYXRzIGl0IGFzCiAgICBl bmQtb2YtaGV4LXN0cmluZywgYW5kIHJldHVybnMgRUZJX1NVQ0NFU1MuIFN1Y2ggaW5wdXRzIHNo b3VsZCBiZQogICAgcmVqZWN0ZWQuCgpBbGwgb2YgdGhlIGFib3ZlIGNhc2VzIGFyZSByZW1vdGVs eSB0cmlnZ2VyYWJsZSwgYXMgc2hvd24gaW4gYSBzdWJzZXF1ZW50CnBhdGNoLCB3aGljaCBhZGRz IGVycm9yIGNoZWNraW5nIHRvIHRoZSBJU2NzaUhleFRvQmluKCkgY2FsbCBzaXRlcy4gV2hpbGUK dGhlIGluaXRpYXRvciBpcyBub3QgaW1tZWRpYXRlbHkgY29tcHJvbWlzZWQsIGluY29ycmVjdGx5 IHBhcnNpbmcgQ0hBUF9SCmZyb20gdGhlIHRhcmdldCwgaW4gY2FzZSBvZiBtdXR1YWwgYXV0aGVu dGljYXRpb24sIGlzIG5vdCBncmVhdC4KCkV4dGVuZCB0aGUgaW50ZXJmYWNlIGNvbnRyYWN0IG9m IElTY3NpSGV4VG9CaW4oKSB3aXRoCkVGSV9JTlZBTElEX1BBUkFNRVRFUiwgZm9yIHJlcG9ydGlu ZyBpc3N1ZXMgKDEpIHRocm91Z2ggKDMpLCBhbmQgaW1wbGVtZW50CnRoZSBuZXcgY2hlY2tzLgoK Q2M6IEppYXhpbiBXdSA8amlheGluLnd1QGludGVsLmNvbT4KQ2M6IE1hY2llaiBSYWJlZGEgPG1h Y2llai5yYWJlZGFAbGludXguaW50ZWwuY29tPgpDYzogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kg PHBoaWxtZEByZWRoYXQuY29tPgpDYzogU2l5dWFuIEZ1IDxzaXl1YW4uZnVAaW50ZWwuY29tPgpS ZWY6IGh0dHBzOi8vYnVnemlsbGEudGlhbm9jb3JlLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM1NgpT aWduZWQtb2ZmLWJ5OiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPgpSZXZpZXdlZC1i eTogTWFjaWVqIFJhYmVkYSA8bWFjaWVqLnJhYmVkYUBsaW51eC5pbnRlbC5jb20+ClJldmlld2Vk LWJ5OiBQaGlsaXBwZSBNYXRoaWV1LURhdWTDqSA8cGhpbG1kQHJlZGhhdC5jb20+Ci0tLQogTmV0 d29ya1BrZy9JU2NzaUR4ZS9JU2NzaU1pc2MuaCB8ICAxICsKIE5ldHdvcmtQa2cvSVNjc2lEeGUv SVNjc2lNaXNjLmMgfCAxMiArKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9OZXR3b3JrUGtnL0lTY3NpRHhl L0lTY3NpTWlzYy5oIGIvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2NzaU1pc2MuaAppbmRleCAyOGNm NDA4Y2Q1YzUuLjQwNGE0ODJlNTdmMyAxMDA2NDQKLS0tIGEvTmV0d29ya1BrZy9JU2NzaUR4ZS9J U2NzaU1pc2MuaAorKysgYi9OZXR3b3JrUGtnL0lTY3NpRHhlL0lTY3NpTWlzYy5oCkBAIC0xNTUs MzggKzE1NSwzOSBAQCBJU2NzaUFzY2lpU3RyVG9JcCAoCiANCiAqKi8NCiBFRklfU1RBVFVTDQog SVNjc2lCaW5Ub0hleCAoDQogICBJTiAgICAgVUlOVDggICpCaW5CdWZmZXIsDQogICBJTiAgICAg VUlOVDMyIEJpbkxlbmd0aCwNCiAgIElOIE9VVCBDSEFSOCAgKkhleFN0ciwNCiAgIElOIE9VVCBV SU5UMzIgKkhleExlbmd0aA0KICAgKTsNCiANCiAvKioNCiAgIENvbnZlcnQgdGhlIGhleGFkZWNp bWFsIHN0cmluZyBpbnRvIGEgYmluYXJ5IGVuY29kZWQgYnVmZmVyLg0KIA0KICAgQHBhcmFtW2lu LCBvdXRdICBCaW5CdWZmZXIgICAgVGhlIGJpbmFyeSBidWZmZXIuDQogICBAcGFyYW1baW4sIG91 dF0gIEJpbkxlbmd0aCAgICBMZW5ndGggb2YgdGhlIGJpbmFyeSBidWZmZXIuDQogICBAcGFyYW1b aW5dICAgICAgIEhleFN0ciAgICAgICBUaGUgaGV4YWRlY2ltYWwgc3RyaW5nLg0KIA0KICAgQHJl dHZhbCBFRklfU1VDQ0VTUyAgICAgICAgICAgVGhlIGhleGFkZWNpbWFsIHN0cmluZyBpcyBjb252 ZXJ0ZWQgaW50byBhDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiaW5hcnkgZW5j b2RlZCBidWZmZXIuDQorICBAcmV0dmFsIEVGSV9JTlZBTElEX1BBUkFNRVRFUiBJbnZhbGlkIGhl eCBlbmNvZGluZyBmb3VuZCBpbiBIZXhTdHIuDQogICBAcmV0dmFsIEVGSV9CVUZGRVJfVE9PX1NN QUxMICBUaGUgYmluYXJ5IGJ1ZmZlciBpcyB0b28gc21hbGwgdG8gaG9sZCB0aGUNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnZlcnRlZCBkYXRhLg0KICoqLw0KIEVGSV9TVEFU VVMNCiBJU2NzaUhleFRvQmluICgNCiAgIElOIE9VVCBVSU5UOCAgKkJpbkJ1ZmZlciwNCiAgIElO IE9VVCBVSU5UMzIgKkJpbkxlbmd0aCwNCiAgIElOICAgICBDSEFSOCAgKkhleFN0cg0KICAgKTsN CiANCiANCiAvKioNCiAgIENvbnZlcnQgdGhlIGRlY2ltYWwtY29uc3RhbnQgc3RyaW5nIG9yIGhl eC1jb25zdGFudCBzdHJpbmcgaW50byBhIG51bWVyaWNhbCB2YWx1ZS4NCiANCiAgIEBwYXJhbVtp bl0gU3RyICAgICAgICAgICAgICAgICAgICBTdHJpbmcgaW4gZGVjaW1hbCBvciBoZXguDQogDQog ICBAcmV0dXJuIFRoZSBudW1lcmljYWwgdmFsdWUuDQogDQogKiovDQpkaWZmIC0tZ2l0IGEvTmV0 d29ya1BrZy9JU2NzaUR4ZS9JU2NzaU1pc2MuYyBiL05ldHdvcmtQa2cvSVNjc2lEeGUvSVNjc2lN aXNjLmMKaW5kZXggMDE0NzAwZTg3YTVmLi5mMGY0OTkyYjA3YzcgMTAwNjQ0Ci0tLSBhL05ldHdv cmtQa2cvSVNjc2lEeGUvSVNjc2lNaXNjLmMKKysrIGIvTmV0d29ya1BrZy9JU2NzaUR4ZS9JU2Nz aU1pc2MuYwpAQCAtMzYwLDcyICszNjAsODAgQEAgSVNjc2lCaW5Ub0hleCAoCiAgICAgSGV4U3Ry W0luZGV4ICogMiArIDJdID0gSVNjc2lIZXhTdHJpbmdbQmluQnVmZmVyW0luZGV4XSA+PiA0XTsN CiAgICAgSGV4U3RyW0luZGV4ICogMiArIDNdID0gSVNjc2lIZXhTdHJpbmdbQmluQnVmZmVyW0lu ZGV4XSAmIDB4Zl07DQogICB9DQogDQogICBIZXhTdHJbSW5kZXggKiAyICsgMl0gPSAnXDAnOw0K IA0KICAgcmV0dXJuIEVGSV9TVUNDRVNTOw0KIH0NCiANCiANCiAvKioNCiAgIENvbnZlcnQgdGhl IGhleGFkZWNpbWFsIHN0cmluZyBpbnRvIGEgYmluYXJ5IGVuY29kZWQgYnVmZmVyLg0KIA0KICAg QHBhcmFtW2luLCBvdXRdICBCaW5CdWZmZXIgICAgVGhlIGJpbmFyeSBidWZmZXIuDQogICBAcGFy YW1baW4sIG91dF0gIEJpbkxlbmd0aCAgICBMZW5ndGggb2YgdGhlIGJpbmFyeSBidWZmZXIuDQog ICBAcGFyYW1baW5dICAgICAgIEhleFN0ciAgICAgICBUaGUgaGV4YWRlY2ltYWwgc3RyaW5nLg0K IA0KICAgQHJldHZhbCBFRklfU1VDQ0VTUyAgICAgICAgICAgVGhlIGhleGFkZWNpbWFsIHN0cmlu ZyBpcyBjb252ZXJ0ZWQgaW50byBhDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi aW5hcnkgZW5jb2RlZCBidWZmZXIuDQorICBAcmV0dmFsIEVGSV9JTlZBTElEX1BBUkFNRVRFUiBJ bnZhbGlkIGhleCBlbmNvZGluZyBmb3VuZCBpbiBIZXhTdHIuDQogICBAcmV0dmFsIEVGSV9CVUZG RVJfVE9PX1NNQUxMICBUaGUgYmluYXJ5IGJ1ZmZlciBpcyB0b28gc21hbGwgdG8gaG9sZCB0aGUN CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnZlcnRlZCBkYXRhLg0KICoqLw0K IEVGSV9TVEFUVVMNCiBJU2NzaUhleFRvQmluICgNCiAgIElOIE9VVCBVSU5UOCAgKkJpbkJ1ZmZl ciwNCiAgIElOIE9VVCBVSU5UMzIgKkJpbkxlbmd0aCwNCiAgIElOICAgICBDSEFSOCAgKkhleFN0 cg0KICAgKQ0KIHsNCiAgIFVJTlROICAgSW5kZXg7DQogICBVSU5UTiAgIExlbmd0aDsNCiAgIFVJ TlQ4ICAgRGlnaXQ7DQogICBDSEFSOCAgIFRlbVN0clsyXTsNCiANCiAgIFplcm9NZW0gKFRlbVN0 ciwgc2l6ZW9mIChUZW1TdHIpKTsNCiANCiAgIC8vDQogICAvLyBGaW5kIG91dCBob3cgbWFueSBo ZXggY2hhcmFjdGVycyB0aGUgc3RyaW5nIGhhcy4NCiAgIC8vDQogICBpZiAoKEhleFN0clswXSA9 PSAnMCcpICYmICgoSGV4U3RyWzFdID09ICd4JykgfHwgKEhleFN0clsxXSA9PSAnWCcpKSkgew0K ICAgICBIZXhTdHIgKz0gMjsNCiAgIH0NCiANCiAgIExlbmd0aCA9IEFzY2lpU3RyTGVuIChIZXhT dHIpOw0KIA0KKyAgLy8NCisgIC8vIFJlamVjdCBhbiBlbXB0eSBoZXggc3RyaW5nOyByZWplY3Qg YSBzdHJheSBuaWJibGUuDQorICAvLw0KKyAgaWYgKExlbmd0aCA9PSAwIHx8IExlbmd0aCAlIDIg IT0gMCkgew0KKyAgICByZXR1cm4gRUZJX0lOVkFMSURfUEFSQU1FVEVSOw0KKyAgfQ0KKw0KICAg Zm9yIChJbmRleCA9IDA7IEluZGV4IDwgTGVuZ3RoOyBJbmRleCArKykgew0KICAgICBUZW1TdHJb MF0gPSBIZXhTdHJbSW5kZXhdOw0KICAgICBEaWdpdCA9IChVSU5UOCkgQXNjaWlTdHJIZXhUb1Vp bnQ2NCAoVGVtU3RyKTsNCiAgICAgaWYgKERpZ2l0ID09IDAgJiYgVGVtU3RyWzBdICE9ICcwJykg ew0KICAgICAgIC8vDQotICAgICAgLy8gSW52YWxpZCBMdW4gQ2hhci4NCisgICAgICAvLyBJbnZh bGlkIEhleCBDaGFyLg0KICAgICAgIC8vDQotICAgICAgYnJlYWs7DQorICAgICAgcmV0dXJuIEVG SV9JTlZBTElEX1BBUkFNRVRFUjsNCiAgICAgfQ0KICAgICBpZiAoKEluZGV4ICYgMSkgPT0gMCkg ew0KICAgICAgIEJpbkJ1ZmZlciBbSW5kZXgvMl0gPSBEaWdpdDsNCiAgICAgfSBlbHNlIHsNCiAg ICAgICBCaW5CdWZmZXIgW0luZGV4LzJdID0gKFVJTlQ4KSAoKEJpbkJ1ZmZlciBbSW5kZXgvMl0g PDwgNCkgKyBEaWdpdCk7DQogICAgIH0NCiAgIH0NCiANCiAgICpCaW5MZW5ndGggPSAoVUlOVDMy KSAoKEluZGV4ICsgMSkvMik7DQogDQogICByZXR1cm4gRUZJX1NVQ0NFU1M7DQogfQ0KIA0KIA0K IC8qKg0KICAgQ29udmVydCB0aGUgZGVjaW1hbC1jb25zdGFudCBzdHJpbmcgb3IgaGV4LWNvbnN0 YW50IHN0cmluZyBpbnRvIGEgbnVtZXJpY2FsIHZhbHVlLg0KIA0KICAgQHBhcmFtW2luXSBTdHIg ICAgICAgICAgICAgICAgICAgIFN0cmluZyBpbiBkZWNpbWFsIG9yIGhleC4NCiANCi0tIAoyLjE5 LjEuMy5nMzAyNDdhYTVkMjAxCgoK