public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ethin Probst <harlydavidsen@gmail.com>
Cc: devel@edk2.groups.io, lersek@redhat.com, mcb30@ipxe.org
Subject: Re: [edk2-devel] VirtIO sound device in qemu?
Date: Tue, 8 Jun 2021 21:25:06 +0100	[thread overview]
Message-ID: <20210608202506.5ukz7kro33c7d54x@leviathan> (raw)
In-Reply-To: <CAJQtwF1gwW1DzZQ55+9KKoUycR5Raa=moEZGy8RMhn50tog14g@mail.gmail.com>

Hi Ethin,

Adapting and overcoming is very much the point of GSoC.
The purpose of this project was always to bring portable audio support
to EDK2, and longer-term the UEFI specification. Virtio was just the
ideal means to that end.

If it turns out not being the ideal way, that's just the way it is.
*But*, I want to point out that there is no reason why we couldn't
build this on top of a not-yet-upstream QEMU patchset - and help out
by providing an eager real consumer for it.
The virtio-snd RFC has been sent out, and it is very unlikely that it
will not end up being merged, if in a modified form from what the
first proof-of-concept looked like. Working with it would give you the
opportunity to influence that implementation, as well as the
virtio-snd standard.

*However*, if the state of the QEMU virtio-snd RFC is not one that
lends itself to basing other work on, then QEMU's usb-audio support is
a close second - that should also be portable to other
If we pick that route, you can always come back to virtio a bit later
if you make good progress on USB Audio Device Class 1.0.

/
    Leif

On Tue, Jun 08, 2021 at 13:52:14 -0500, Ethin Probst wrote:
> So I just might have to go with USB audio (the basic audio device
> class) since no code in QEMU for VirtIO audio has actually been
> committed upstream. Perusing the qemu code (specifically this:
> https://github.com/qemu/qemu/blob/master/hw/usb/dev-audio.c) it
> appears that Qemu implements v. 1.0 of the ADC specification. Section
> 5.3.3.1.2 of the USB basic audio device specification (v. 1.0)
> confirms that the bcdADC field should be set to 0100h. Will doing this
> violate any rules of GSoC or anything like that?
> I can implement VirtIO, but I will have no way of testing it until
> Qemu actually adds it in (unless there's another emulator that
> implements it). :-(
> 
> On 6/7/21, Leif Lindholm <leif@nuviainc.com> wrote:
> > On Mon, Jun 07, 2021 at 17:16:00 +0200, Laszlo Ersek wrote:
> >> On 06/07/21 13:40, Michael Brown wrote:
> >> > On 07/06/2021 05:41, Ethin Probst wrote:
> >> >> For my audio output protocol (I wonder if we should abbreviate it as
> >> >> AOP?) I need to get access to VirtIO devices in PCIe configuration
> >> >> space. However, I can't seem to find a way of telling QEMU to use this
> >> >> device for audio output. Is there something I missed, or something
> >> >> that does support this?
> >> >
> >> > Do you mean that you can't find a way to get QEMU to create a Virtio
> >> > audio device visible to the guest, or that you can't find a way to get
> >> > QEMU to connect this Virtio device to the host-side audio output?
> >>
> >> My latest (admittedly, quite old) information has been that QEMU does
> >> not implement a virtio-audio device yet. It's been work in progress.
> >> Best inquire on qemu-devel, CC'ing the audio subsys maintainers.
> >
> > An RFC sent out end of April has not yet seen a PATCH, but some
> > feedback:
> > https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg06089.html
> >
> > /
> >     Leif
> >
> 
> 
> -- 
> Signed,
> Ethin D. Probst

  reply	other threads:[~2021-06-08 20:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  4:41 VirtIO sound device in qemu? Ethin Probst
2021-06-07 11:40 ` [edk2-devel] " Michael Brown
2021-06-07 15:16   ` Laszlo Ersek
2021-06-07 18:54     ` Ethin Probst
2021-06-07 21:33     ` Leif Lindholm
2021-06-08 18:52       ` Ethin Probst
2021-06-08 20:25         ` Leif Lindholm [this message]
2021-06-08 23:29           ` Rafael Machado
2021-06-09 10:57           ` Laszlo Ersek
2021-06-09 12:25             ` Michael Brown
2021-06-09 12:48               ` Leif Lindholm
2021-06-09 13:43                 ` Ethin Probst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608202506.5ukz7kro33c7d54x@leviathan \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox