From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.6866.1623241124185798156 for ; Wed, 09 Jun 2021 05:18:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=ItgkH3z4; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 159CCJgg055043; Wed, 9 Jun 2021 08:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=eC6Ct2rpdoMOiVgYB+lR4SDkuwoA6Ge4LFaq/X8aFOA=; b=ItgkH3z4COGT+erEMm3YZtq2AV2LyjXCCyVo5OVOZnCQJjfF5ycMt6uzXpA9IA8USyhO sWAlqAkvwmXVT8NH8fYkCbT+LbqYHnjPBM0yZaeL8D9WuHXVCr//iBWGRZHlBNuPiOJH simJUhN2+gRlBbprCtv0aDI/qktnhp9hTTqo0bLXOpjmAHj+31e4N276NuuYrfDDAVy4 AdtBaWxkR7hk9wcayxLUGVZQo5UzGPR6A7s73ndsnO6n/wDdudEMhF872P3t3pBA86CQ 02mQYyMsy5d+T9dpgX1ZHPSkFcyM5hel48kDoSjJvEJWMQneJ1LN2EFVLhM7aGXmLJe9 9w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 392vkr9uqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Jun 2021 08:18:43 -0400 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 159CCKx0055127; Wed, 9 Jun 2021 08:18:43 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 392vkr9uqa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Jun 2021 08:18:42 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 159CDVkd027141; Wed, 9 Jun 2021 12:18:42 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03wdc.us.ibm.com with ESMTP id 3900w9ye25-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Jun 2021 12:18:42 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 159CIgac26542502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jun 2021 12:18:42 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E226B124058; Wed, 9 Jun 2021 12:18:41 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD36C124054; Wed, 9 Jun 2021 12:18:41 +0000 (GMT) Received: from localhost.localdomain (unknown [9.2.130.16]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 9 Jun 2021 12:18:41 +0000 (GMT) From: "Dov Murik" To: devel@edk2.groups.io Cc: Dov Murik , Laszlo Ersek , Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum Subject: [PATCH v1 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header Date: Wed, 9 Jun 2021 12:18:28 +0000 Message-Id: <20210609121828.1884825-4-dovmurik@linux.ibm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210609121828.1884825-1-dovmurik@linux.ibm.com> References: <20210609121828.1884825-1-dovmurik@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: WZz3muRz-IfJ--oMQKzwTVFIBD3bqc1n X-Proofpoint-ORIG-GUID: wuUiZJfthrwxebWfsHKqGcfqC9-SVZKG X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-06-09_04:2021-06-04,2021-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106090059 Content-Transfer-Encoding: quoted-printable Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the ground to add a warning about the incompatibility with boot verification process. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: James Bottomley Cc: Tobin Feldman-Fitzthum Signed-off-by: Dov Murik --- OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/Ov= mfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c index 1177582ab051..dc9018f4333b 100644 --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c @@ -2,6 +2,9 @@ X86 specific implementation of QemuLoadImageLib library class interface= =0D with support for loading mixed mode images and non-EFI stub images=0D =0D + Note that this implementation reads the cmdline (and possibly kernel, se= tup=0D + data, and initrd in the legacy boot mode) from fw_cfg directly.=0D +=0D Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
=0D Copyright (c) 2020, ARM Ltd. All rights reserved.
=0D =0D --=20 2.25.1