From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web09.4505.1623289666315422119 for ; Wed, 09 Jun 2021 18:47:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=h7a5uX/m; spf=pass (domain: gmail.com, ip: 209.85.215.169, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f169.google.com with SMTP id t17so4698527pga.5 for ; Wed, 09 Jun 2021 18:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4Mttomqwl1jn3xBst770kmI+mC7cJj7BiYLmpOcXCNM=; b=h7a5uX/mSjKgxknbfk5axYpSp4CXDadqDzxNfKM8XGGyk/IUI28LFn1l3H1Fi4nsw0 LYGku8UZp0YU0BQpk3+0J6jminFVtp31s+IdhHuvDZ1GwtYv9C3siBeqeZ6d+BQl1XYd dWvnOvfOvoMHBoJjqjOu9aljvIn8MSp2UIn/GqGrPKW6v+oHHWolx8de/zOClPwS5Al3 xsH6WcNbdg6/7UwKc2unxjlacUfnFQ6rYazWaj69Nl2SuireuRNnvCl8DUS+3L+qNtV8 0MXIr72IHiqHoHmrgvQFV54e/8gx6RRE1sv6WpfG7G/Qm+7+Sj/HroMqPN61NQGwAF2R Wjjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4Mttomqwl1jn3xBst770kmI+mC7cJj7BiYLmpOcXCNM=; b=YkxZmljZvKGtpJxzLfnZnLwDwcrcaHfrrJiaJ9pgGtBwcD+a02BL4XFPSibmIetzPs 32sXjdUFPGB3g28LyNIZrmNkSUVSW0EwT3aFgvzcVAocDHTiCxZVbHO7NluoDNbUZKeY c7xG9fWPYlP3PyCJ10YBg34qwyVmzEmUfNCH5AYXW5tkmM2ULZjO+5rnPWlEAw2tug2+ cVWPyd5YrzCLJJUo49vKu6Kk6YsS8k6licAr0+jm5dmVuJ+7gJdq8J2qiZ01hJkk+8R5 /RRYUleRrjkXxAkfx3hOjApi3WiA+M3/+8GGtmAviaC00L26l33jkzVpe0hEobRT0omU 8k1A== X-Gm-Message-State: AOAM5309FeIudb3At8CHgjm/YBXTBumW8AVtOg1u9HyjeLNupi2itUBU QPEdnhhTgOtwQPBSoBgb9tMElPM16k3ACg== X-Google-Smtp-Source: ABdhPJzsK3spEEqyDvySSCR6wqHM+JOZZvpAGck56k8Asrqpxz1pRErWlJAnHzwAUbxGW3VrZwM13Q== X-Received: by 2002:a63:4915:: with SMTP id w21mr2530968pga.363.1623289665532; Wed, 09 Jun 2021 18:47:45 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id o17sm6187492pjp.33.2021.06.09.18.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 18:47:44 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao Subject: [PATCH v1 0/1] Spell Check File Mask Leak into Sequential Package Checks Date: Wed, 9 Jun 2021 18:47:32 -0700 Message-Id: <20210610014733.1267-1-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3443 Current spell check routine on CI build pipelines is ignoring some files incorrectly. The issue is class variable, STANDARD_PLUGIN_DEFINED_PATHS from SpellCheck.py, is a list. In a local function the list is assigned to a local variable, which is then modified based on the package config. But the modification of this local variable will change the class variable and then leaks to the next package. The proposed solution in this patch series is to convert class member to tuple so that is read-only. Then copy into list in the local function before package specific modifications. Patch v1 branch: https://github.com/kuqin12/edk2/tree/spell_check_v1 Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Sean Brogan (1): Pytool: SpellCheck: Fix incorrect file mask across package matrices .pytool/Plugin/SpellCheck/SpellCheck.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.31.1.windows.1