From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.5149.1623395281931039438 for ; Fri, 11 Jun 2021 00:08:02 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: sunny.wang@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A773E1396; Fri, 11 Jun 2021 00:08:00 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DB3733F719; Fri, 11 Jun 2021 00:07:58 -0700 (PDT) From: "Sunny Wang" To: devel@edk2.groups.io Cc: Sunny Wang , Samer El-Haj-Mahmoud , G Edhaya Chandran , Barton Gao , Heinrich Schuchardt , Michael D Kinney , Sunny Wang Subject: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Date: Fri, 11 Jun 2021 15:07:31 +0800 Message-Id: <20210611070731.2199-1-Sunny.Wang@arm.com> X-Mailer: git-send-email 2.31.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The commit a9d1fb58 caused SCT BS.CreateEvent failures. Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for exclusive use by the firmware. The creation of events by UEFI applications, UEFI drivers, and UEFI OS Loaders should not use this TPL level. Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the failures. For more information, https://edk2.groups.io/g/devel/message/76338 Cc: Samer El-Haj-Mahmoud Cc: G Edhaya Chandran Cc: Barton Gao Cc: Heinrich Schuchardt Cc: Michael D Kinney Signed-off-by: Sunny Wang --- .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTas= kPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreate= Event.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPr= iorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEve= nt.c index a7e7366e..d5c033f7 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriori= tyServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriori= tyServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c @@ -2,6 +2,7 @@ =20 Copyright 2006 - 2012 Unified EFI, Inc.
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.
+ Copyright (c) 2021, ARM Limited. All rights reserved. =20 This program and the accompanying materials are licensed and made available under the terms and conditions of the = BSD License @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 ( EFI_TPL NotifyTpls[] =3D { TPL_CALLBACK, TPL_NOTIFY, - TPL_HIGH_LEVEL, 0 }; EFI_TEST_ASSERTION AssertionType; @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 ( EFI_TPL NotifyTpls[] =3D { TPL_CALLBACK, TPL_NOTIFY, - TPL_HIGH_LEVEL, 0 }; EFI_TEST_ASSERTION AssertionType; @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 ( EFI_TPL NotifyTpls[] =3D { TPL_CALLBACK, TPL_NOTIFY, - TPL_HIGH_LEVEL, 0 }; EFI_TEST_ASSERTION AssertionType; @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 ( EFI_TPL NotifyTpls[] =3D { TPL_CALLBACK, TPL_NOTIFY, - TPL_HIGH_LEVEL, 0 }; EFI_TEST_ASSERTION AssertionType; --=20 2.31.0.windows.1