From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mx.groups.io with SMTP id smtpd.web11.10459.1623426743566688914 for ; Fri, 11 Jun 2021 08:52:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@puresoftware.com header.s=google header.b=e54tBbeC; spf=pass (domain: puresoftware.com, ip: 209.85.210.178, mailfrom: vikas.singh@puresoftware.com) Received: by mail-pf1-f178.google.com with SMTP id k15so4788829pfp.6 for ; Fri, 11 Jun 2021 08:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puresoftware.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a+W8qzV+1G1/nj1hMP9xnrSiUKUoQMnPvJ/FfOtPpdc=; b=e54tBbeC6DGMK2k+Z/JIEtVUj3r0CmC+mWIZHdgb0PfZSOyRQdpY/t6W5ROn6AN/fT e4ntSlZvacBoF+CSOT+bQgZ9OdLwCzqtRtH7R1pQTeotqqdCnuQsNlefDU8IvL3M3b7P 7QsR6GjtReXpqO4Z2UdadIT3nQloPmLPcWoMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+W8qzV+1G1/nj1hMP9xnrSiUKUoQMnPvJ/FfOtPpdc=; b=EiPn6Rn+EmB3JCdGEiZ7OuTubanR/Af+f6iipIcMDlMw3YFVK78CvRSUIuB4zgFVdo 7NtbrTwJaNaV4TZFyF3t4j6wfKfsrBebgDMYskLTv9iDEV0S08CQZ0devDseSVKMLaxH 8E07TygZq3FTAiqG2v5JEhmLWbgahKVYhiBFJ/THFiHKDXU8rShio4UaZEH7d5K6lGqp wcE9pGBV+WrTd3/NdrgjsNKEGylo2JEUzsmPUYCLzWJijiMqW4ZkxueD6Vo6AIeh3wew ofitPW8mt6ADQIzbBRLTxiu3bCPYooK6iaXb160isDKclSDONXLzqp82hvO6CHpSUrGh PYEw== X-Gm-Message-State: AOAM530D7DQsWwpM707DZoCrSWadQmDW+oc0aXtkljbNsyqhnIa2i41e GalPGdU1yCJE4fsJsLlxiCJHmnwXE6YQGNC43OY= X-Google-Smtp-Source: ABdhPJywdiCoEhmYH+OqNxIMEd80na0v/1pICZdPJFww2dXdPfuCMceJ288LFH0Gm//sZ7UL2KlTpA== X-Received: by 2002:a65:5684:: with SMTP id v4mr4163601pgs.218.1623426742982; Fri, 11 Jun 2021 08:52:22 -0700 (PDT) Return-Path: Received: from embedded-PC.puresoft.int ([125.63.92.170]) by smtp.gmail.com with ESMTPSA id h8sm5458689pjf.7.2021.06.11.08.52.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jun 2021 08:52:22 -0700 (PDT) From: "Vikas Singh" To: devel@edk2.groups.io Cc: sami.mujawar@arm.com, leif@nuviainc.com, meenakshi.aggarwal@nxp.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com, Sunny.Wang@arm.com Subject: [PATCH V1 1/4] Platform/NXP: Add generic log in CM to print SoC version Date: Fri, 11 Jun 2021 21:21:57 +0530 Message-Id: <20210611155200.15535-2-vikas.singh@puresoftware.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210611155200.15535-1-vikas.singh@puresoftware.com> References: <20210611155200.15535-1-vikas.singh@puresoftware.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Summary - 1.Configuration Manager(CM) is a common implementation and should not evaluate the SoC version using macro's However CM must directly consume SoC ver string from platfrom who is extending CM services for ACPI table generation. 2.Platforms who extends CM services for themselves must notify their SoC details to CM. 3.This patch will update the lx2160ardb platform header also with PLAT_SOC_NAME, this will be consumed by CM. Signed-off-by: Vikas Singh --- Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configuration= Manager.c | 10 +++------- Platform/NXP/LX2160aRdbPkg/Include/Platform.h = | 5 ++--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/C= onfigurationManager.c b/Platform/NXP/ConfigurationManagerPkg/ConfigurationM= anagerDxe/ConfigurationManager.c index 80ce8412c4..dc1a7f5f85 100644 --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/Configur= ationManager.c @@ -2,7 +2,7 @@ Configuration Manager Dxe=0D =0D Copyright 2020 NXP=0D - Copyright 2020 Puresoftware Ltd=0D + Copyright 2020-2021 Puresoftware Ltd=0D =0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D @@ -170,12 +170,8 @@ InitializePlatformRepository ( PlatformRepo =3D This->PlatRepoInfo;=0D =0D Svr =3D SocGetSvr ();=0D - if (SVR_SOC_VER(Svr) =3D=3D SVR_LX2160A) {=0D - PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr);=0D - DEBUG ((DEBUG_INFO, "Fsl : SoC LX2160A Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision));=0D - } else {=0D - DEBUG ((DEBUG_INFO, "Fsl : SoC Unknown Rev =3D 0x%x\n", PlatformRepo->= FslBoardRevision));=0D - }=0D + PlatformRepo->FslBoardRevision =3D SVR_MAJOR(Svr);=0D + DEBUG ((DEBUG_INFO, "Fsl : SoC =3D %s Rev =3D 0x%x\n", PLAT_SOC_NAME, Pl= atformRepo->FslBoardRevision));=0D =0D return EFI_SUCCESS;=0D }=0D diff --git a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h b/Platform/NXP/L= X2160aRdbPkg/Include/Platform.h index 76a41d4369..c18faf28cd 100644 --- a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h +++ b/Platform/NXP/LX2160aRdbPkg/Include/Platform.h @@ -2,7 +2,7 @@ * Platform headers=0D *=0D * Copyright 2020 NXP=0D - * Copyright 2020 Puresoftware Ltd=0D + * Copyright 2020-2021 Puresoftware Ltd=0D *=0D * SPDX-License-Identifier: BSD-2-Clause-Patent=0D *=0D @@ -15,12 +15,11 @@ #define EFI_ACPI_ARM_OEM_REVISION 0x00000000=0D =0D // Soc defines=0D +#define PLAT_SOC_NAME "LX2160ARDB"=0D #define SVR_SOC_VER(svr) (((svr) >> 8) & 0xFFFFFE)=0D #define SVR_MAJOR(svr) (((svr) >> 4) & 0xf)=0D #define SVR_MINOR(svr) (((svr) >> 0) & 0xf)=0D =0D -#define SVR_LX2160A 0x873600=0D -=0D // PCLK=0D #define DCFG_BASE 0x1E00000=0D #define DCFG_LEN 0x1FFFF=0D --=20 2.25.1