From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH v1 0/1] SpellCheck plugin inspects fewer files when run on Linux
Date: Fri, 11 Jun 2021 22:04:30 -0700 [thread overview]
Message-ID: <20210612050431.660-1-kuqin12@gmail.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454
When spellcheck plugin invokes cspell to check files, it uses wildcard
path patterns, i.e. <package>/**/*.h.
On Linux system, this will be expanded by the shell therefore fewer files
will be picked up than speficied through original command line.
To resolve this issue, the path needs double quoting. So that the shell
does not expand and the input parameter is passed to cspell to expand.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/exp_shell_v1
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Sean Brogan (1):
Pytool: SpellCheck: Defer path expansion in cspell parameters
.pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.31.1.windows.1
next reply other threads:[~2021-06-12 5:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 5:04 Kun Qin [this message]
2021-06-12 5:04 ` [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Kun Qin
2021-06-15 15:59 ` [edk2-devel] " Sean
2021-06-15 16:20 ` [EXTERNAL] " Bret Barkelew
2021-06-15 17:04 ` Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612050431.660-1-kuqin12@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox