From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mx.groups.io with SMTP id smtpd.web09.2592.1623474283365324223 for ; Fri, 11 Jun 2021 22:04:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mjJLXwDw; spf=pass (domain: gmail.com, ip: 209.85.216.44, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f44.google.com with SMTP id k5so6796622pjj.1 for ; Fri, 11 Jun 2021 22:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KIlVYmNu6O0+VjcSXhVg34jcOH7iqfJ84SnVsjCMW3s=; b=mjJLXwDw0g27i3UhmLQ+KYM684/xCAFpDCM7825Myg9+eMfKqPTz0m3IfVgAQ/SOj+ qAS6SCaYbjKcYdSqg/4BtXSzvviHNGrMLa+NcWmnG5TYBDW4alwxImF1hFRl9KMxRLdo 0yw0azMqFxYfa1NQbIYFCt40DTE4qSWl/JYKaDnXNnb7ZZ6vknyTM0WJ44fxW5otXhTC Y3HQqTVGQUw4g4kd5yBy6+fo8Pfg8YBE9sm4AO2UwGe88PLP2Ed+B1LO+IY876WpiOxE h/O0epcnjgHEQ2C92w+Vv6OAjzlc8VBXUuF3N09OcaCcwsxu8qJcn9kuscrpqUZnJL2L cuPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KIlVYmNu6O0+VjcSXhVg34jcOH7iqfJ84SnVsjCMW3s=; b=KRGgT+NrdOOeKPSLa395WNekaR92BC/XMZQC7mJyooXrWMuXCqqGEPOAVUTxIrGULc shNpfwQbxOGw63RJLNhHJD8nbEzPbmDgXrnEaCVLusJzeimp/OzQqJ1WXfvx1isa4MmS MFiGbUkhdWYJjdyefWpfOEzz78bPhbCxY4K08XwdDBakfUcVYMoPSJe6hnT9KHMNt7Mv DYZJeNRZHE0TtomdqVNvpI9z35jLQ2MaYKHaUcy9+L03jdI6ikQ10IV0wjE6x2Xg5YL8 IhJRRTymm1syYrxXPisAYNWXSD/rPyO7v8BN5XmCrtitHYY0xGjBIRMzMPhEzJ/9DneZ ee9A== X-Gm-Message-State: AOAM533gLISi7dOYG0x+zsfb3DQa0ALGN1FscCM5hVP29Tog/j+cDstY PJLTTEC7vz0eC7rx4H8+cUQ9ghQWiCdMHQ== X-Google-Smtp-Source: ABdhPJzvoz/a2DIS1y134UHu6SgezMVqVO7p2EQlu9qx5WGiKpcvurdghLr99y+CTqwOu++68m0ZOg== X-Received: by 2002:a17:902:778d:b029:119:3443:9ebd with SMTP id o13-20020a170902778db029011934439ebdmr2868116pll.45.1623474282614; Fri, 11 Jun 2021 22:04:42 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id n37sm6363485pfv.47.2021.06.11.22.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 22:04:42 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao Subject: [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Date: Fri, 11 Jun 2021 22:04:31 -0700 Message-Id: <20210612050431.660-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210612050431.660-1-kuqin12@gmail.com> References: <20210612050431.660-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan --- .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/SpellCheck/SpellCheck.py index 43365441b91c..97b240ef747c 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin): # relpath = os.path.relpath(abs_pkg_path) cpsell_paths = " ".join( - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_check]) + # Double quote each path to defer expansion to cspell parameters + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_check]) # Make the config file config_file_path = os.path.join( -- 2.31.1.windows.1