[PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

[PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/76419

v2 patches mainly focus on feedback for reviewed commits in v1 patches,
including:
a. Adding "Reviewed-by" tags for applicable patches;
b. Adding "Signed-Off-by" tags for myself for all patches;

Patch v2 branch: https://github.com/kuqin12/edk2/tree/node_14_v2

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

Kun Qin (1):
  Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

Sean Brogan (3):
  StandaloneMmPkg: Core: Spelling error in comment
  ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly
  ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords

 StandaloneMmPkg/Core/Dispatcher.c                      |  2 +-
 .azurepipelines/templates/spell-check-prereq-steps.yml |  2 +-
 ArmPkg/ArmPkg.ci.yaml                                  | 19 +++++++++++++++++++
 ArmPlatformPkg/ArmPlatformPkg.ci.yaml                  |  2 +-
 4 files changed, 22 insertions(+), 3 deletions(-)

-- 
2.31.1.windows.1

[PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment

[Kun Qin]

From: Sean Brogan <sean.brogan@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

This change fixed a misspelling that was not caught by spell check.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>

Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
---

Notes:
    v2:
    - Added signed-off-by from Kun [Ard]
    - Added reviewed-by tag [Ard]

 StandaloneMmPkg/Core/Dispatcher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
index dbd5332fa9d3..7e4bf5e94025 100644
--- a/StandaloneMmPkg/Core/Dispatcher.c
+++ b/StandaloneMmPkg/Core/Dispatcher.c
@@ -4,7 +4,7 @@
   Step #1 - When a FV protocol is added to the system every driver in the FV
             is added to the mDiscoveredList. The Before, and After Depex are
             pre-processed as drivers are added to the mDiscoveredList. If an Apriori
-            file exists in the FV those drivers are addeded to the
+            file exists in the FV those drivers are added to the
             mScheduledQueue. The mFwVolList is used to make sure a
             FV is only processed once.
 
-- 
2.31.1.windows.1

Re: [PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment

[Ard Biesheuvel]

On Mon, 14 Jun 2021 at 20:34, Kun Qin <kuqin12@gmail.com> wrote:
>
> From: Sean Brogan <sean.brogan@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
>
> This change fixed a misspelling that was not caught by spell check.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Merged patches 1 - 3


Thanks,

> ---
>
> Notes:
>     v2:
>     - Added signed-off-by from Kun [Ard]
>     - Added reviewed-by tag [Ard]
>
>  StandaloneMmPkg/Core/Dispatcher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
> index dbd5332fa9d3..7e4bf5e94025 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -4,7 +4,7 @@
>    Step #1 - When a FV protocol is added to the system every driver in the FV
>              is added to the mDiscoveredList. The Before, and After Depex are
>              pre-processed as drivers are added to the mDiscoveredList. If an Apriori
> -            file exists in the FV those drivers are addeded to the
> +            file exists in the FV those drivers are added to the
>              mScheduledQueue. The mFwVolList is used to make sure a
>              FV is only processed once.
>
> --
> 2.31.1.windows.1
>

[PATCH v2 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly

[Kun Qin]

From: Sean Brogan <sean.brogan@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

Spellcheck was not covering all specified files due to CSpell v5 and
Node v10 incompatibility of current CI pipeline configuration.

This change switches the spellcheck for ArmPlatformPkg to AuditOnly to
avoid potentially numerous spell errors. The correction action is to be
revisited by package maintainers once the tool incompatibility is
resolved.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>

Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
---

Notes:
    v2:
    - Moved Kun's signed-off tag to the last
    - Added reviewed-by tag [Ard]

 ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
index 1abaa2f6870c..3dbbcc673bf0 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
+++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
@@ -83,7 +83,7 @@
 
     ## options defined .pytool/Plugin/SpellCheck
     "SpellCheck": {
-        "AuditOnly": False,
+        "AuditOnly": True,
         "IgnoreFiles": [],           # use gitignore syntax to ignore errors
                                      # in matching files
         "ExtendWords": [
-- 
2.31.1.windows.1

[PATCH v2 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords

[Kun Qin]

From: Sean Brogan <sean.brogan@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

Spellcheck was not covering all specified files due to CSpell v5 and
Node v10 incompatibility of current CI pipeline configuration.

This change updates ExtendedWords for ArmPkg with valid acronyms to avoid
potential spell errors.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>

Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
---

Notes:
    v2:
    - Moved Kun's signed-off tag to the last
    - Added reviewed-by tag [Ard]

 ArmPkg/ArmPkg.ci.yaml | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
index d91c03f2acb8..a0d6a75fe881 100644
--- a/ArmPkg/ArmPkg.ci.yaml
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -94,13 +94,18 @@
           "ackintid",
           "actlr",
           "aeabi",
+          "asedis",
           "ashldi",
           "ashrdi",
+          "baddr",
           "ccidx",
           "ccsidr",
           "clidr",
           "clrex",
           "clzsi",
+          "cnthctl",
+          "cortexa",
+          "cpacr",
           "cpuactlr",
           "csselr",
           "ctzsi",
@@ -116,6 +121,7 @@
           "divdi",
           "divsi",
           "dmdepkg",
+          "dpref",
           "drsub",
           "fcmpeq",
           "fcmpge",
@@ -125,17 +131,25 @@
           "ffreestanding",
           "frsub",
           "hisilicon",
+          "iccabpr",
           "iccbpr",
           "icciar",
           "iccicr",
           "icciidr",
+          "iccpir",
           "iccpmr",
+          "iccrpr",
+          "icdabr",
           "icdicer",
           "icdicfr",
+          "icdicpr",
           "icdictr",
+          "icdiidr",
           "icdiser",
           "icdisr",
+          "icdppisr",
           "icdsgir",
+          "icdspr",
           "icenabler",
           "intid",
           "ipriority",
@@ -160,6 +174,7 @@
           "lshrdi",
           "moddi",
           "modsi",
+          "mpcore",
           "mpidr",
           "muldi",
           "mullu",
@@ -168,6 +183,9 @@
           "nsasedis",
           "nuvia",
           "oldit",
+          "pcten",
+          "plpis",
+          "procno",
           "readc",
           "revsh",
           "rfedb",
@@ -189,6 +207,7 @@
           "smmlsr",
           "sourcery",
           "srsdb",
+          "ssacr",
           "stmdb",
           "stmia",
           "strbt",
-- 
2.31.1.windows.1

[PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

Per update from Cspell tool, the minimal requirement of Cspell 5.x
regarding Node is 12 and above. This has caused multple Cspell failures
during CI build validation:
"Failed to process "**.c" TypeError: text.matchAll(...) is not a function
or its return value is not iterable"

This change updates the lowest required node version to 14.x to support
Cspell functionalities.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
---

Notes:
    v2:
    - Added reviewed-by tag [Ard]

 .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml
index e1570d4f2aac..98ee3cfa6bc6 100644
--- a/.azurepipelines/templates/spell-check-prereq-steps.yml
+++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
@@ -13,7 +13,7 @@ parameters:
 steps:
 - task: NodeTool@0
   inputs:
-    versionSpec: '10.x'
+    versionSpec: '14.x'
     #checkLatest: false # Optional
   condition: and(gt(variables.pkg_count, 0), succeeded())
 
-- 
2.31.1.windows.1

Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

[Sean]

Thanks



Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>



On 6/14/2021 11:34 AM, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> 
> Per update from Cspell tool, the minimal requirement of Cspell 5.x
> regarding Node is 12 and above. This has caused multple Cspell failures
> during CI build validation:
> "Failed to process "**.c" TypeError: text.matchAll(...) is not a function
> or its return value is not iterable"
> 
> This change updates the lowest required node version to 14.x to support
> Cspell functionalities.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> 
> Notes:
>      v2:
>      - Added reviewed-by tag [Ard]
> 
>   .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml
> index e1570d4f2aac..98ee3cfa6bc6 100644
> --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> @@ -13,7 +13,7 @@ parameters:
>   steps:
>   - task: NodeTool@0
>     inputs:
> -    versionSpec: '10.x'
> +    versionSpec: '14.x'
>       #checkLatest: false # Optional
>     condition: and(gt(variables.pkg_count, 0), succeeded())
>   
> 

Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

[PierreGondois]

Hi Kun and Sean,
As a follow-up to your patch-set, it seems that the spell checker does not currently run as expected. It only runs on files that are 'one level deep' in each package.
I.e.:
This was taken from Build/CI_BUILDLOG.txt from the TARGET_ARM_ARMPLATFORM artifact at https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=23939&view=artifacts&pathAsName=false&type=publishedArtifacts but this can be checked when running the CI locally on ArmPlatformPkg:

-------Log start---------
INFO - Cmd to run is: cspell --config /home/vsts/work/1/s/Build/ArmPlatformPkg/cspell_actual_config.json ArmPlatformPkg/**/*.c ArmPlatformPkg/**/*.h ArmPlatformPkg/**/*.nasm ArmPlatformPkg/**/*.masm ArmPlatformPkg/**/*.asl ArmPlatformPkg/**/*.dsc ArmPlatformPkg/**/*.dec ArmPlatformPkg/**/*.fdf ArmPlatformPkg/**/*.inf ArmPlatformPkg/**/*.md ArmPlatformPkg/**/*.txt
INFO - ------------------------------------------------
INFO - --------------Cmd Output Starting---------------
INFO - ------------------------------------------------
INFO -  1/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c 829.48ms
INFO -  2/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c 37.06ms
INFO -  3/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.c 13.01ms
INFO -  4/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.c 16.99ms
INFO -  5/22 ./ArmPlatformPkg/PrePeiCore/MainMPCore.c 25.68ms
INFO -  6/22 ./ArmPlatformPkg/PrePeiCore/MainUniCore.c 19.50ms
INFO -  7/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.c 20.86ms
INFO -  8/22 ./ArmPlatformPkg/PrePi/MainMPCore.c 18.98ms
INFO -  9/22 ./ArmPlatformPkg/PrePi/MainUniCore.c 9.86ms
INFO - 10/22 ./ArmPlatformPkg/PrePi/PrePi.c 26.83ms
INFO - 11/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.h 15.71ms
INFO - 12/22 ./ArmPlatformPkg/PrePi/PrePi.h 16.49ms
INFO - 13/22 ./ArmPlatformPkg/ArmPlatformPkg.dsc 21.03ms
INFO - 14/22 ./ArmPlatformPkg/ArmPlatformPkg.dec 24.63ms
INFO - 15/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf 11.12ms
INFO - 16/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf 15.85ms
INFO - 17/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf 9.89ms
INFO - 18/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.inf 9.14ms
INFO - 19/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf 13.97ms
INFO - 20/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf 9.92ms
INFO - 21/22 ./ArmPlatformPkg/PrePi/PeiMPCore.inf 12.01ms
INFO - 22/22 ./ArmPlatformPkg/PrePi/PeiUniCore.inf 18.06ms
INFO - CSpell: Files checked: 22, Issues found: 0 in 0 files
INFO - ------------------------------------------------
INFO - --------------Cmd Output Finished---------------
INFO - --------- Running Time (mm:ss): 00:01 ----------
INFO - ----------- Return Code: 0x00000000 ------------
INFO - ------------------------------------------------
PROGRESS - --->Test Success: Spell Check Test NO-TARGET
-------Log end---------

As shown, in the "ArmPlatformPkg/**/*.c" expression, "**" is evaluated as a single directory instead of any number of directories. This can be fixed by:
 - setting the globstar variable (tried on bash): "shopt -s globstar", run "shopt globstar" to check its value, or
 - modifying .pytool/Plugin/SpellCheck/SpellCheck.py to add quotes around the files to check so that cspell evaluates the "**" by itself. This solution seems better as it doesn't require to modify the environment.

Regards,
Pierre

On 6/14/21 7:34 PM, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
>
> This patch series is a follow up of previous submission:
> https://edk2.groups.io/g/devel/message/76419
>
> v2 patches mainly focus on feedback for reviewed commits in v1 patches,
> including:
> a. Adding "Reviewed-by" tags for applicable patches;
> b. Adding "Signed-Off-by" tags for myself for all patches;
>
> Patch v2 branch: https://github.com/kuqin12/edk2/tree/node_14_v2
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>
> Kun Qin (1):
>   Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x
>
> Sean Brogan (3):
>   StandaloneMmPkg: Core: Spelling error in comment
>   ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly
>   ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords
>
>  StandaloneMmPkg/Core/Dispatcher.c                      |  2 +-
>  .azurepipelines/templates/spell-check-prereq-steps.yml |  2 +-
>  ArmPkg/ArmPkg.ci.yaml                                  | 19 +++++++++++++++++++
>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml                  |  2 +-
>  4 files changed, 22 insertions(+), 3 deletions(-)
>

Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

[Sean]

Pierre,

Yes we noticed this the other day.
Bugzilla here: https://bugzilla.tianocore.org/show_bug.cgi?id=3454

A patch is on the list https://edk2.groups.io/g/devel/message/76428

it implemented your second option.  The good news is this doesn't change 
the outcome of overall CI because the Windows Vs2019 Agent should have 
caught all issues and since both must pass the mainline should be ok. 
There have a been a few issues related to spellchecker that we are 
trying to get fixed that has caused missed failures.  Hopefully today 
the patches will get merged in.  But agree it impacts local scenarios 
and isn't correct. Thanks again.  Nice to see that we both came to the 
same conclusion for a fix.

Thanks
Sean




On 6/15/2021 7:29 AM, PierreGondois wrote:
> Hi Kun and Sean,
> As a follow-up to your patch-set, it seems that the spell checker does not currently run as expected. It only runs on files that are 'one level deep' in each package.
> I.e.:
> This was taken from Build/CI_BUILDLOG.txt from the TARGET_ARM_ARMPLATFORM artifact at https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=23939&view=artifacts&pathAsName=false&type=publishedArtifacts but this can be checked when running the CI locally on ArmPlatformPkg:
> 
> -------Log start---------
> INFO - Cmd to run is: cspell --config /home/vsts/work/1/s/Build/ArmPlatformPkg/cspell_actual_config.json ArmPlatformPkg/**/*.c ArmPlatformPkg/**/*.h ArmPlatformPkg/**/*.nasm ArmPlatformPkg/**/*.masm ArmPlatformPkg/**/*.asl ArmPlatformPkg/**/*.dsc ArmPlatformPkg/**/*.dec ArmPlatformPkg/**/*.fdf ArmPlatformPkg/**/*.inf ArmPlatformPkg/**/*.md ArmPlatformPkg/**/*.txt
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Starting---------------
> INFO - ------------------------------------------------
> INFO -  1/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c 829.48ms
> INFO -  2/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c 37.06ms
> INFO -  3/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.c 13.01ms
> INFO -  4/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.c 16.99ms
> INFO -  5/22 ./ArmPlatformPkg/PrePeiCore/MainMPCore.c 25.68ms
> INFO -  6/22 ./ArmPlatformPkg/PrePeiCore/MainUniCore.c 19.50ms
> INFO -  7/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.c 20.86ms
> INFO -  8/22 ./ArmPlatformPkg/PrePi/MainMPCore.c 18.98ms
> INFO -  9/22 ./ArmPlatformPkg/PrePi/MainUniCore.c 9.86ms
> INFO - 10/22 ./ArmPlatformPkg/PrePi/PrePi.c 26.83ms
> INFO - 11/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.h 15.71ms
> INFO - 12/22 ./ArmPlatformPkg/PrePi/PrePi.h 16.49ms
> INFO - 13/22 ./ArmPlatformPkg/ArmPlatformPkg.dsc 21.03ms
> INFO - 14/22 ./ArmPlatformPkg/ArmPlatformPkg.dec 24.63ms
> INFO - 15/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf 11.12ms
> INFO - 16/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf 15.85ms
> INFO - 17/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf 9.89ms
> INFO - 18/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.inf 9.14ms
> INFO - 19/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf 13.97ms
> INFO - 20/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf 9.92ms
> INFO - 21/22 ./ArmPlatformPkg/PrePi/PeiMPCore.inf 12.01ms
> INFO - 22/22 ./ArmPlatformPkg/PrePi/PeiUniCore.inf 18.06ms
> INFO - CSpell: Files checked: 22, Issues found: 0 in 0 files
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Finished---------------
> INFO - --------- Running Time (mm:ss): 00:01 ----------
> INFO - ----------- Return Code: 0x00000000 ------------
> INFO - ------------------------------------------------
> PROGRESS - --->Test Success: Spell Check Test NO-TARGET
> -------Log end---------
> 
> As shown, in the "ArmPlatformPkg/**/*.c" expression, "**" is evaluated as a single directory instead of any number of directories. This can be fixed by:
>   - setting the globstar variable (tried on bash): "shopt -s globstar", run "shopt globstar" to check its value, or
>   - modifying .pytool/Plugin/SpellCheck/SpellCheck.py to add quotes around the files to check so that cspell evaluates the "**" by itself. This solution seems better as it doesn't require to modify the environment.
> 
> Regards,
> Pierre
> 
> On 6/14/21 7:34 PM, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
>>
>> This patch series is a follow up of previous submission:
>> https://edk2.groups.io/g/devel/message/76419
>>
>> v2 patches mainly focus on feedback for reviewed commits in v1 patches,
>> including:
>> a. Adding "Reviewed-by" tags for applicable patches;
>> b. Adding "Signed-Off-by" tags for myself for all patches;
>>
>> Patch v2 branch: https://github.com/kuqin12/edk2/tree/node_14_v2
>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>>
>> Kun Qin (1):
>>    Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x
>>
>> Sean Brogan (3):
>>    StandaloneMmPkg: Core: Spelling error in comment
>>    ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly
>>    ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords
>>
>>   StandaloneMmPkg/Core/Dispatcher.c                      |  2 +-
>>   .azurepipelines/templates/spell-check-prereq-steps.yml |  2 +-
>>   ArmPkg/ArmPkg.ci.yaml                                  | 19 +++++++++++++++++++
>>   ArmPlatformPkg/ArmPlatformPkg.ci.yaml                  |  2 +-
>>   4 files changed, 22 insertions(+), 3 deletions(-)
>>
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

[Kun Qin]

Hi pipeline maintainers,

Could you please help reviewing this specific patch?

Thanks to Ard, the other patches in this series are already reviewed and 
merged.

Regards,
Kun

On 06/14/2021 11:34, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> 
> Per update from Cspell tool, the minimal requirement of Cspell 5.x
> regarding Node is 12 and above. This has caused multple Cspell failures
> during CI build validation:
> "Failed to process "**.c" TypeError: text.matchAll(...) is not a function
> or its return value is not iterable"
> 
> This change updates the lowest required node version to 14.x to support
> Cspell functionalities.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> 
> Notes:
>      v2:
>      - Added reviewed-by tag [Ard]
> 
>   .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml
> index e1570d4f2aac..98ee3cfa6bc6 100644
> --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> @@ -13,7 +13,7 @@ parameters:
>   steps:
>   - task: NodeTool@0
>     inputs:
> -    versionSpec: '10.x'
> +    versionSpec: '14.x'
>       #checkLatest: false # Optional
>     condition: and(gt(variables.pkg_count, 0), succeeded())
>   
> 

回复: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

[gaoliming]

Acked-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Kun Qin <kuqin12@gmail.com>
> 发送时间: 2021年6月17日 5:08
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Ard Biesheuvel <ardb@kernel.org>
> 主题: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce
> Node dependency to use version 14.x
> 
> Hi pipeline maintainers,
> 
> Could you please help reviewing this specific patch?
> 
> Thanks to Ard, the other patches in this series are already reviewed and
> merged.
> 
> Regards,
> Kun
> 
> On 06/14/2021 11:34, Kun Qin via groups.io wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> >
> > Per update from Cspell tool, the minimal requirement of Cspell 5.x
> > regarding Node is 12 and above. This has caused multple Cspell failures
> > during CI build validation:
> > "Failed to process "**.c" TypeError: text.matchAll(...) is not a function
> > or its return value is not iterable"
> >
> > This change updates the lowest required node version to 14.x to support
> > Cspell functionalities.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > Signed-off-by: Kun Qin <kuqin12@gmail.com>
> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >
> > Notes:
> >      v2:
> >      - Added reviewed-by tag [Ard]
> >
> >   .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml
> b/.azurepipelines/templates/spell-check-prereq-steps.yml
> > index e1570d4f2aac..98ee3cfa6bc6 100644
> > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> > @@ -13,7 +13,7 @@ parameters:
> >   steps:
> >   - task: NodeTool@0
> >     inputs:
> > -    versionSpec: '10.x'
> > +    versionSpec: '14.x'
> >       #checkLatest: false # Optional
> >     condition: and(gt(variables.pkg_count, 0), succeeded())
> >
> >