From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web08.350.1623776050053029923 for ; Tue, 15 Jun 2021 09:54:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DF4lhN00; spf=pass (domain: gmail.com, ip: 209.85.216.41, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f41.google.com with SMTP id o10-20020a17090aac0ab029016e92770073so2609403pjq.5 for ; Tue, 15 Jun 2021 09:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dcu1uvMtm29ty6JvFnEOAEE8BMPQNLsurW0LiuVWoHA=; b=DF4lhN00ZuWjlm5jgkZIOMpDCWhI9BwA0ft4xtGH6ejBOTVYLxgmjnz6d9kwErLTow OBCy/q7DqN7WfVdJXUrcYqGgxz/QiwM0dNZHoOC0uf66wRlzcasNaVKv4vdlvu+bbCPT CG73rbKYnFGT9J5h3vdiLcTgPM/T6di9j0HdpkqCHYQJEMUAWifKmlpqJOd6OKnZ6tAK LZAqMyCobemaoyU7SpSIkz5dRMSjyxmatuUPsYgPx+R+dbNEAa2r3LvClrZNZouNDR0U PaEGvHNAWaR0sUePi0j8NO92LmX6N+zroLVq8kc9TFi5woj3/AR5X/Tc8Yxq0hZjnD00 wotA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dcu1uvMtm29ty6JvFnEOAEE8BMPQNLsurW0LiuVWoHA=; b=Jy5H03NM2PqD+wD5QKlHZNMX9sBOzp52UDMZdVcGmG9usdiNQ+v6LzPmEWQKmzKkg6 DoPfh8eYidnTjd4BaXiXreHdb4KhPDckNDqg5XgYkUZAx4lVV39NxD/l8CtB12S/KQvz nc+hHoyxNAkFxFKvZxS9/unp0O58ITvdqAH69NbhVEygUev1w9s1xJb8NZNl+OEM9kfW VYQIxjFygel2oNetqam0DpBAc14xL/w4ssPq/U9vrVEPlfpvBxkonIKc2zmsYqNPSMno kB6gO789NCV8UrjxVBkMsvOmTZfKcWCr0XHzHFplMUAjCQiummal0aNkdt3SxzRBe+Fo rQIw== X-Gm-Message-State: AOAM531twdOpBOQoN1DmZvd9N8Ye5xoAKgr/1/K6rt9rrF2OhdBn3sEB 2RixiNrGtXjvOI5uhR2ymh51gt+3Ed/25g== X-Google-Smtp-Source: ABdhPJw+AbwyC9zP65rXNy2FmnzefgS4wH0upsAHj6U2ScdmBYF5ulWWpu0CDj4u/KIOXSZ13boF5g== X-Received: by 2002:a17:90a:e512:: with SMTP id t18mr146290pjy.158.1623776049408; Tue, 15 Jun 2021 09:54:09 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id o16sm15492527pfu.75.2021.06.15.09.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 09:54:08 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Bret Barkelew Subject: [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters Date: Tue, 15 Jun 2021 09:53:57 -0700 Message-Id: <20210615165357.1993-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210615165357.1993-1-kuqin12@gmail.com> References: <20210615165357.1993-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Reviewed-by: Sean Brogan Reviewed-by: Bret Barkelew --- Notes: v2: - Added reviewed-by tags [Bret] - Added reviewed-by tag [Sean] - Added signed-off-by tag from Kun [Sean] .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/SpellCheck/SpellCheck.py index 9ad57632a6e8..05c471d91ba1 100644 --- a/.pytool/Plugin/SpellCheck/SpellCheck.py +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py @@ -134,7 +134,8 @@ class SpellCheck(ICiBuildPlugin): # relpath = os.path.relpath(abs_pkg_path) cpsell_paths = " ".join( - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_check]) + # Double quote each path to defer expansion to cspell parameters + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_check]) # Make the config file config_file_path = os.path.join( -- 2.31.1.windows.1