From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.5237.1623921184678651234 for ; Thu, 17 Jun 2021 02:13:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bHuS0uuC; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15H93ej3030607; Thu, 17 Jun 2021 05:13:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=kam7L+UfzUetHAXYUPitcBo3CkHC0FW8k/2rAXKWQSE=; b=bHuS0uuCLLYcsNlpF28/sqBTcuPVcKY2caY4yKsveJcuWXCw8Pru5LJTDXPr+Nw/pwdI 1lILEVW7Qm/Pr1Y10HSp0eOA+kxKobb4g8/DBRBK8oEiSxIFu1CH77PACKT/Fs2aQhhO 7oka/HDHh4H/Wz7UZG4608+SAMF0IsUl5goig/JgPK5bt+PNoeq4BmvSUMs+59a24fTT mqIhakP29ZPBvRC0TESNYVN2PeIV1WM5K4WFmT0bsCmlPYjHK78Hjtp3WZPD+21QeIZn Lpx+4G6H/cHL/nX+1+rr1nP4yTpyx41tBDet6ucYHtv1xGJQymOMAeUMzu7IR9YLiElu ZQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3982vrsg3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 05:13:03 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15H940vn033799; Thu, 17 Jun 2021 05:13:03 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 3982vrsg3h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 05:13:03 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15H97YRD011929; Thu, 17 Jun 2021 09:13:02 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma01wdc.us.ibm.com with ESMTP id 394mj9qjrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Jun 2021 09:13:02 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15H9D1kP30408984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jun 2021 09:13:01 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 928CBBE05A; Thu, 17 Jun 2021 09:13:01 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E81DABE05D; Thu, 17 Jun 2021 09:13:00 +0000 (GMT) Received: from localhost.localdomain (unknown [9.2.130.16]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 17 Jun 2021 09:13:00 +0000 (GMT) From: "Dov Murik" To: devel@edk2.groups.io Cc: Dov Murik , Laszlo Ersek , Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum Subject: [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header Date: Thu, 17 Jun 2021 09:12:44 +0000 Message-Id: <20210617091244.2667569-4-dovmurik@linux.ibm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210617091244.2667569-1-dovmurik@linux.ibm.com> References: <20210617091244.2667569-1-dovmurik@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: NqshOrpzoe-POXJkt8RwkTjnx-5rmLAC X-Proofpoint-GUID: CNtae04gse5nppFZA7slEgIOGrnNNzgH X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-06-17_05:2021-06-15,2021-06-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 adultscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106170063 Content-Transfer-Encoding: quoted-printable Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the ground to add a warning about the incompatibility with boot verification process. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: James Bottomley Cc: Tobin Feldman-Fitzthum Signed-off-by: Dov Murik --- OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++ OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf b/= OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf index e1615badd2ba..c7ec041cb706 100644 --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf @@ -2,6 +2,9 @@ # X86 specific implementation of QemuLoadImageLib library class interface= =0D # with support for loading mixed mode images and non-EFI stub images=0D #=0D +# Note that this implementation reads the cmdline (and possibly kernel, s= etup=0D +# data, and initrd in the legacy boot mode) from fw_cfg directly.=0D +#=0D # Copyright (c) 2020, ARM Ltd. All rights reserved.
=0D #=0D # SPDX-License-Identifier: BSD-2-Clause-Patent=0D diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/Ov= mfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c index 1177582ab051..dc9018f4333b 100644 --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c @@ -2,6 +2,9 @@ X86 specific implementation of QemuLoadImageLib library class interface= =0D with support for loading mixed mode images and non-EFI stub images=0D =0D + Note that this implementation reads the cmdline (and possibly kernel, se= tup=0D + data, and initrd in the legacy boot mode) from fw_cfg directly.=0D +=0D Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
=0D Copyright (c) 2020, ARM Ltd. All rights reserved.
=0D =0D --=20 2.25.1