From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.2526.1623982113762164343 for ; Thu, 17 Jun 2021 19:08:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=DfxCY9nt; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 8089720B83F2; Thu, 17 Jun 2021 19:08:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8089720B83F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623982113; bh=U9QxeeBDyXW5TlUgVpn8rLo9HjLXQAeWU6h2MGi+Qbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DfxCY9ntfvG3WzMggnjhTvjNOakS/g2bchUCfYmZdXsiA1+qTpsXD4Ou635EhYHyh h2dvz9ON3vAjd/KBqCdZ8KOxdMMWex0Pd+Usda5IVDeWVySO4je9eA9B5lNEHWB9lr h2OGpb62Cvy7pfSp8ABqddANpZMtAP3eNShJpyJI= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty , Nate DeSimone Subject: [edk2-platforms][PATCH v3 16/41] CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs Date: Thu, 17 Jun 2021 22:07:01 -0400 Message-Id: <20210618020726.5991-17-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20210618020726.5991-1-mikuback@linux.microsoft.com> References: <20210618020726.5991-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. The previous PCDs are removed from CoffeelakeSiliconPkg.dec. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPol= icyLib.inf | 4 ++-- Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec = | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyL= ib/PeiCpuPolicyLib.inf b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/P= eiCpuPolicyLib/PeiCpuPolicyLib.inf index f793432bf049..ca57b5b31e0a 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiC= puPolicyLib.inf +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiC= puPolicyLib.inf @@ -48,8 +48,8 @@ [Ppis] gSiPreMemPolicyPpiGuid ## CONSUMES =20 [FixedPcd] -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =20 [Pcd] gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode ## Produces diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec b/Silicon/Intel= /CoffeelakeSiliconPkg/SiPkg.dec index 6cf894498d6b..5ea6fbb28411 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec @@ -474,13 +474,8 @@ [PcdsFixedAtBuild] ## NOTE: The size restriction may be changed in next generation processo= r. ## Please refer to Processor BWG for detail. ## -gSiPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF800000|UINT32|0x10000001 -gSiPkgTokenSpaceGuid.PcdBiosSize|0x00800000|UINT32|0x10000002 gSiPkgTokenSpaceGuid.PcdTemporaryRamBase|0xfef00000|UINT32|0x00010028 gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x2000|UINT32|0x00010029 -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE60000|UINT32|0x3000000= 4 -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A0000|UINT32|0x3000000= 5 -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x00660000|UINT32|0x30000= 006 =20 ## ## PcdEfiGcdAllocateType is using for EFI_GCD_ALLOCATE_TYPE selection --=20 2.28.0.windows.1