From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Heng Luo <heng.luo@intel.com>
Subject: [edk2-platforms][PATCH v3 23/41] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib
Date: Thu, 17 Jun 2021 22:07:08 -0400 [thread overview]
Message-ID: <20210618020726.5991-24-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20210618020726.5991-1-mikuback@linux.microsoft.com>
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 7 +++++--
Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
index 1adf63403450..758b966fee81 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
@@ -173,7 +173,7 @@ [LibraryClasses.X64]
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxeLib.dsc
[LibraryClasses.X64.DXE_SMM_DRIVER]
- SpiFlashCommonLib|$(PLATFORM_BOARD_PACKAGE)/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf
+ SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf
!if $(TARGET) == DEBUG
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
!endif
@@ -297,6 +297,10 @@ [Components.X64]
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
$(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf
+!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
+ IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf
+!endif
+
#
# SmmAccess
#
@@ -326,7 +330,6 @@ [Components.X64]
NULL|$(PROJECT)/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf
}
- $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf
$(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf {
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf
index e3b2f048524c..b802c2167d06 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf
@@ -434,7 +434,7 @@ [FV.FvOsBootUncompact]
!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
INF $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf
INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf
-INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf
+INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf
INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf
--
2.28.0.windows.1
next prev parent reply other threads:[~2021-06-18 2:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 2:06 [edk2-platforms][PATCH v3 00/41] Consolidate SpiFlashCommonLib instances Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 01/41] CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 02/41] WhiskeylakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 03/41] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 04/41] IntelSiliconPkg: Add BIOS area base address and size PCDs Michael Kubacki
2021-06-24 21:42 ` Chaganty, Rangasai V
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 05/41] IntelSiliconPkg: Add microcode FV PCDs Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI Michael Kubacki
2021-06-24 21:56 ` Chaganty, Rangasai V
2021-06-25 1:55 ` Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 07/41] IntelSiliconPkg: Add PCH SPI Protocol Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 08/41] IntelSiliconPkg: Add SpiFlashCommonLib Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 09/41] IntelSiliconPkg: Add SmmSpiFlashCommonLib Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 10/41] IntelSiliconPkg: Add MM SPI FVB services Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 11/41] CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 12/41] KabylakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 13/41] SimicsOpenBoardPkg: " Michael Kubacki
2021-06-18 2:06 ` [edk2-platforms][PATCH v3 14/41] TigerlakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 15/41] WhiskeylakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 16/41] CoffeelakeSiliconPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 17/41] KabylakeSiliconPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 18/41] SimicsIch10Pkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 19/41] TigerlakeSiliconPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 20/41] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 21/41] KabylakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 22/41] SimicsOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` Michael Kubacki [this message]
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 24/41] WhiskeylakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 25/41] MinPlatformPkg: Remove SpiFvbService modules Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 26/41] CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 27/41] KabylakeSiliconPkg: " Michael Kubacki
2021-06-18 11:38 ` Chiu, Chasel
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 28/41] SimicsIch10Pkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 29/41] TigerlakeOpenBoardPkg: " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 30/41] MinPlatformPkg: Remove SpiFlashCommonLibNull Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 31/41] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 32/41] CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package Michael Kubacki
2021-06-18 11:39 ` Chiu, Chasel
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 33/41] KabylakeSiliconPkg: " Michael Kubacki
2021-06-18 11:39 ` Chiu, Chasel
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 34/41] SimicsIch10Pkg: Remove PCH SPI SMM " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 35/41] TigerlakeSiliconPkg: Remove PCH SPI PPI and " Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 36/41] IntelSiliconPkg: Add flash region GUIDs Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 37/41] IntelSiliconPkg: Identify flash regions by GUID Michael Kubacki
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 38/41] CoffeelakeSiliconPkg/BasePchSpiCommonLib: " Michael Kubacki
2021-06-18 11:53 ` Chiu, Chasel
2021-06-18 2:07 ` [edk2-platforms][PATCH v3 39/41] KabylakeSiliconPkg: " Michael Kubacki
2021-06-18 11:55 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618020726.5991-24-mikuback@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox