From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web08.5686.1624009721475512432 for ; Fri, 18 Jun 2021 02:48:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cY5ZAkOR; spf=pass (domain: gmail.com, ip: 209.85.216.50, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f50.google.com with SMTP id 13-20020a17090a08cdb029016eed209ca4so5563153pjn.1 for ; Fri, 18 Jun 2021 02:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=85yGIZ8w0ufva63qmFOWAn76jLkNzfeyu94HXqdiXVA=; b=cY5ZAkOR/hB6f1bx5kGfyWCc6Knez90zZOY69xg9KmfPd0/5vCYFU47dnBXFqXEMW0 szAGXlNWjgbaXpOs2vJcOBC1DaISoKTTb5UIKbl0VRIBsHEXX//zUxNfR5YGlZBS2sq9 Mvnkc+9tJmkNdQpv6azxOPFTBU1n8Nm2NGGW5Ox8toy1XNAnqClIWUhHq9OSF7ru38vo d7gZJU5catBXaGsXNTMgWFBTG7Php9YGd0TV6A5p4XmfCI51jzF0Ch+3rBcuj7hdWja8 uFSwuWQKkqw9Rdna9xv6Olf0DweKphHPMprO5mE1+FJdNw43o6N2atbg5Gjl/w0LIyAc 1tiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=85yGIZ8w0ufva63qmFOWAn76jLkNzfeyu94HXqdiXVA=; b=CawDUpRfOLCbuz09s+tzIMvTDw9E/Qis50mGicYRuJDpGH9BOZuZZVTom5stpmmNwY y0IufX47Gs/FxbRW88fTrjlfS8CDc3epLJ/cDY1dCpYyichJl1hEHNWUqG6V9ZLQn+22 3/y8U0ciU3vk8Hh0sYMZty4nb1zBjJvL/8aywq11+eA8fxwqvDR0SLapSfulO/nQFUWm mObK78HFSWpzv4QJ9aOMPO19j7HqMqI2EClQ0rIWZ8kj2FhAgx4cN6ZLu+zKIC6PZRHH zOWs8n7J5EgE57lroT702OL4cD64G/1TB7lIKHw5XLwsASz3sRZ34nX+U+05uHKcb1cm Qllg== X-Gm-Message-State: AOAM530cZhWuaCXtKDqmgwPsmaoPnU9emWkqc7n2ye8+ZrrmZj5n7ono pNYurkcUBnFWkIkTmXKmP7IklUTgX3Ycig== X-Google-Smtp-Source: ABdhPJyETJfZVhgzEY9yQR8oAvr7TA8JHllc16EkucXYCAfEANMyarPyrB48NA03F3R1Ec9TRvNTQw== X-Received: by 2002:a17:903:304e:b029:11d:75ff:c304 with SMTP id u14-20020a170903304eb029011d75ffc304mr3870428pla.33.1624009720626; Fri, 18 Jun 2021 02:48:40 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id j7sm12930291pjf.0.2021.06.18.02.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 02:48:40 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Michael Kubacki Subject: [PATCH v1 1/2] MdePkg: MmConfiguration: Moved EFI_MM_RESERVED_MMRAM_REGION to PiMmCis.h Date: Fri, 18 Jun 2021 02:48:28 -0700 Message-Id: <20210618094829.2651-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210618094829.2651-1-kuqin12@gmail.com> References: <20210618094829.2651-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 The definition of EFI_MM_RESERVED_MMRAM_REGION, according to PI Spec 1.5 is also referenced in EFI_PEI_MM_CONFIGURATION_PPI. Defining this structure as is will enforce any potential usage of MM Configuration PPI interface to include . This change moves EFI_MM_RESERVED_MMRAM_REGION definition into PiMmCis.h, which is already included in Protocol/MmConfiguration.h. It also paves way for introducing Ppi/MmConfiguration.h with proper dependency. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin --- MdePkg/Include/Pi/PiMmCis.h | 16 ++++++++++++++++ MdePkg/Include/Protocol/MmConfiguration.h | 16 ---------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/MdePkg/Include/Pi/PiMmCis.h b/MdePkg/Include/Pi/PiMmCis.h index fdf0591a03d6..422a3ea6c2bb 100644 --- a/MdePkg/Include/Pi/PiMmCis.h +++ b/MdePkg/Include/Pi/PiMmCis.h @@ -242,6 +242,22 @@ VOID IN CONST EFI_MM_ENTRY_CONTEXT *MmEntryContext ); +/// +/// Structure describing a MMRAM region which cannot be used for the MMRAM heap. +/// +typedef struct _EFI_MM_RESERVED_MMRAM_REGION { + /// + /// Starting address of the reserved MMRAM area, as it appears while MMRAM is open. + /// Ignored if MmramReservedSize is 0. + /// + EFI_PHYSICAL_ADDRESS MmramReservedStart; + /// + /// Number of bytes occupied by the reserved MMRAM area. A size of zero indicates the + /// last MMRAM area. + /// + UINT64 MmramReservedSize; +} EFI_MM_RESERVED_MMRAM_REGION; + /// /// Management Mode System Table (MMST) /// diff --git a/MdePkg/Include/Protocol/MmConfiguration.h b/MdePkg/Include/Protocol/MmConfiguration.h index eeb94f64bdf7..d2fb6a13d4af 100644 --- a/MdePkg/Include/Protocol/MmConfiguration.h +++ b/MdePkg/Include/Protocol/MmConfiguration.h @@ -21,22 +21,6 @@ 0x26eeb3de, 0xb689, 0x492e, {0x80, 0xf0, 0xbe, 0x8b, 0xd7, 0xda, 0x4b, 0xa7 } \ } -/// -/// Structure describing a MMRAM region which cannot be used for the MMRAM heap. -/// -typedef struct _EFI_MM_RESERVED_MMRAM_REGION { - /// - /// Starting address of the reserved MMRAM area, as it appears while MMRAM is open. - /// Ignored if MmramReservedSize is 0. - /// - EFI_PHYSICAL_ADDRESS MmramReservedStart; - /// - /// Number of bytes occupied by the reserved MMRAM area. A size of zero indicates the - /// last MMRAM area. - /// - UINT64 MmramReservedSize; -} EFI_MM_RESERVED_MMRAM_REGION; - typedef struct _EFI_MM_CONFIGURATION_PROTOCOL EFI_MM_CONFIGURATION_PROTOCOL; /** -- 2.31.1.windows.1