Re: [PATCH v4 1/4] OvmfPkg/MemEncryptHypercallLib: add library to support SEV hypercalls.

["Ashish Kalra" <ashish.kalra@amd.com>]

Hello Tom, Brijesh,

Thanks for your comments and feedback on this patch-set.

With reference to those, i will remove the new library and
add the hypercall function inside BaseMemEncryptSevLib library.

Also i will let the hypercall handling for SEV-ES be done 
as part of #VC exception handling in VmgExitLib library.

Thanks,
Ashish

On Wed, Jun 23, 2021 at 01:47:47AM +0000, Ashish Kalra wrote:
> Hello Tom,
> 
> On Tue, Jun 22, 2021 at 05:47:48PM -0500, Tom Lendacky wrote:
> > On 6/21/21 8:56 AM, Ashish Kalra wrote:
> > > From: Ashish Kalra <ashish.kalra@amd.com>
> > > 
> > > Add SEV and SEV-ES hypercall abstraction library to support SEV Page
> > > encryption/deceryption status hypercalls for SEV and SEV-ES guests.
> > 
> > Does this have to be a new library? It's just a single function and so I
> > would think it could live in the BaseMemEncryptSevLib library where the
> > change to the c-bit is being done anyway.
> > 
> 
> Actually i like this approach, instead of adding a new library.
> 
> Again, IIRC we had discussed this internally and then decided to
> create a new hypercall library similar to Xen, with reference to 
> the email copied below :
> 
> ...
> Xen has support under Ovmf for a Xen hypercall library
> (OvmfPkg/Library/XenHypercallLib). Take a look at that and maybe create
> something similar for KVM.
> ...
> 
> Thanks,
> Ashish