From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mx.groups.io with SMTP id smtpd.web10.2464.1624505600051422454 for ; Wed, 23 Jun 2021 20:33:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ujctrQg9; spf=pass (domain: gmail.com, ip: 209.85.215.170, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f170.google.com with SMTP id p9so3580776pgb.1 for ; Wed, 23 Jun 2021 20:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IQobBiW8qfIVgx+Zm31GDeVkb0MQPhDTwHeWrOV++Ss=; b=ujctrQg9kRYkPdf2UAPsaRZKsAD+477NCEzw/IsoV6xd+gGxsO+843GXyL4lWwwaIj Vq+8s7OSExvG6PUIY5V1wjNRbYkKV4pZL/6Z5CyActU1F+k2HhGmk7tjb0QLCdJfPCDQ 3ZQEibIl/gVNmh/dqBoq9Xdai4kSCwDwu3+iOIlowmw8OxVCoX9EmcWsn/N562Je3+cq islHto9Rdi7AP9gUB1GqAITvw/dNLFKz37AzJMSJWxABfuotdXi0MCM162mJrlSkbj0v Npxm5/cFSbOBRE59/uxxjQDxsU702nMRDpVw28qZqeiF1WV36AqwVtG9UuvDeXjO6Nk8 Xaqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IQobBiW8qfIVgx+Zm31GDeVkb0MQPhDTwHeWrOV++Ss=; b=Mx+TsRTdRTcO4plY4wiib9LlPWaAZ5RTPWdruUgZy2zGFrtlVKdtQdFfYLyISZuD3u 9StWtNrnJhs3z3+k6dR5/q7A22NvvtbC+fBq7VJ6qM5kbrhn2V4oEgWlnZdb09hz4YRM BaWdUcCzaFKUWrriHCHTckWO6RJB/lq0Hg+H7+9C19mL3AglkVOiEMbXZUjPmF8mH+uY sKm29Q2pufvzE5IbiA9jKarZw12g/tzEDglim/GR+MTXbOxgivwu8yMfjDfXrBFLAo7F 6S+03XafOhIrITCjob4f7ryHyfYyTpeUypLzsvEqlhNpjFU8HFPjO13Lo30BI9fnO629 kzJA== X-Gm-Message-State: AOAM532VApYYP7SgqzbswAZOjvQUyqcj1ORlC9y/gNRaTZ0+n7RcJJd4 xuKbqpQjAhK7AepGMYHLM/JvN7YK1abuAA== X-Google-Smtp-Source: ABdhPJxUEQekDd78iWQhYrsCYasdRANJZ4JsnpKaB8ZVKuALsD7Y/ZH/Q5MXJ910JiwRhCtt/Dlceg== X-Received: by 2002:a63:338c:: with SMTP id z134mr2739121pgz.167.1624505599414; Wed, 23 Jun 2021 20:33:19 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id u1sm555901pgh.80.2021.06.23.20.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 20:33:19 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Michael Kubacki Subject: [PATCH v2 1/2] MdePkg: MmConfiguration: Move definition of EFI_MM_RESERVED_MMRAM_REGION Date: Wed, 23 Jun 2021 20:33:07 -0700 Message-Id: <20210624033308.1111-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20210624033308.1111-1-kuqin12@gmail.com> References: <20210624033308.1111-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3440 The definition of EFI_MM_RESERVED_MMRAM_REGION, according to PI Spec 1.5 is also referenced in EFI_PEI_MM_CONFIGURATION_PPI. Defining this structure as is will enforce any potential usage of MM Configuration PPI interface to include . This change moves this structure definition to PiMultiPhase.h, which is already included by Protocol/MmConfiguration.h through PiMmCis.h. It also paves way for introducing Ppi/MmConfiguration.h with proper dependency. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Michael Kubacki Signed-off-by: Kun Qin --- Notes: v2: - Changed definition from PiMmCis to PiMultiPhase [Liming] MdePkg/Include/Pi/PiMultiPhase.h | 16 ++++++++++++++++ MdePkg/Include/Protocol/MmConfiguration.h | 16 ---------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/MdePkg/Include/Pi/PiMultiPhase.h b/MdePkg/Include/Pi/PiMultiPhase.h index a5056799e1dd..89280d9d3506 100644 --- a/MdePkg/Include/Pi/PiMultiPhase.h +++ b/MdePkg/Include/Pi/PiMultiPhase.h @@ -133,6 +133,22 @@ typedef struct { typedef EFI_MMRAM_DESCRIPTOR EFI_SMRAM_DESCRIPTOR; +/// +/// Structure describing a MMRAM region which cannot be used for the MMRAM heap. +/// +typedef struct _EFI_MM_RESERVED_MMRAM_REGION { + /// + /// Starting address of the reserved MMRAM area, as it appears while MMRAM is open. + /// Ignored if MmramReservedSize is 0. + /// + EFI_PHYSICAL_ADDRESS MmramReservedStart; + /// + /// Number of bytes occupied by the reserved MMRAM area. A size of zero indicates the + /// last MMRAM area. + /// + UINT64 MmramReservedSize; +} EFI_MM_RESERVED_MMRAM_REGION; + typedef enum { EFI_PCD_TYPE_8, EFI_PCD_TYPE_16, diff --git a/MdePkg/Include/Protocol/MmConfiguration.h b/MdePkg/Include/Protocol/MmConfiguration.h index eeb94f64bdf7..d2fb6a13d4af 100644 --- a/MdePkg/Include/Protocol/MmConfiguration.h +++ b/MdePkg/Include/Protocol/MmConfiguration.h @@ -21,22 +21,6 @@ 0x26eeb3de, 0xb689, 0x492e, {0x80, 0xf0, 0xbe, 0x8b, 0xd7, 0xda, 0x4b, 0xa7 } \ } -/// -/// Structure describing a MMRAM region which cannot be used for the MMRAM heap. -/// -typedef struct _EFI_MM_RESERVED_MMRAM_REGION { - /// - /// Starting address of the reserved MMRAM area, as it appears while MMRAM is open. - /// Ignored if MmramReservedSize is 0. - /// - EFI_PHYSICAL_ADDRESS MmramReservedStart; - /// - /// Number of bytes occupied by the reserved MMRAM area. A size of zero indicates the - /// last MMRAM area. - /// - UINT64 MmramReservedSize; -} EFI_MM_RESERVED_MMRAM_REGION; - typedef struct _EFI_MM_CONFIGURATION_PROTOCOL EFI_MM_CONFIGURATION_PROTOCOL; /** -- 2.31.1.windows.1