From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.403.1624656118025565322 for ; Fri, 25 Jun 2021 14:21:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=sTYVXmvs; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 57E4D20B6C50; Fri, 25 Jun 2021 14:21:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 57E4D20B6C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624656117; bh=FEERM4TveeVjoFlxIJsZSRnGMVICmxsqPpdpHu+KdUQ=; h=From:To:Cc:Subject:Date:From; b=sTYVXmvsK3fEIDS8L/POZ06I/je52gQTaSZmG92IWPSW0bkikjrkd0c3CMx3qJPi+ rcMheKJG7EZmUVoh/CFctE/nfpDnHFyoGucdxP5/068gzXXbE5e5ZBZPym8pNCpFNf ZspnG1QSTQwYbp0coN1oXPgP3o6N4b67fYVyWdxo= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Agyeman Prince , Chasel Chiu , Deepika Kethi Reddy , Eric Dong , Heng Luo , Jeremy Soller , Kathappan Esakkithevar , Liming Gao , Nate DeSimone , Rangasai V Chaganty Subject: [edk2-platforms][PATCH v4 00/41] Consolidate SpiFlashCommonLib instances Date: Fri, 25 Jun 2021 17:20:39 -0400 Message-Id: <20210625212120.235-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform design in edk2-platforms. I'm planning to build some additional functionality on top of SpiFlashCommonLib and, ideally, this duplication will be consolidated into a single instance usable across all current lib= rary consumers. This patch series focuses on consolidating the various SpiFlashCommonLib instances as agreed upon in https://edk2.groups.io/g/devel/message/71701. Read the BZ for more general background around this series. I only have an UpXtreme board on hand so maintainers/reviewers of other board packages should test these changes on those boards. V4 changes: - Assigned new GUID values to the PCH SPI PPI and Protocols to differentiate from previous instances. This was done because the interface changed to identify SPI flash regions by GUID. V3 changes: - Added support to IntelSiliconPkg to identify flash regions by GUID as requested in v2 review feedback. V2 changes: - Rebased patch series on current edk2-platforms master (32183bdaa91) Note: Previous patch series only received a couple review comments after being on the mailing list for over 2 months. Please be respectful of contributors time and efforts and review in a timely manner. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Michael Kubacki (41): CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF IntelSiliconPkg: Add BIOS area base address and size PCDs IntelSiliconPkg: Add microcode FV PCDs IntelSiliconPkg: Add PCH SPI PPI IntelSiliconPkg: Add PCH SPI Protocol IntelSiliconPkg: Add SpiFlashCommonLib IntelSiliconPkg: Add SmmSpiFlashCommonLib IntelSiliconPkg: Add MM SPI FVB services CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib MinPlatformPkg: Remove SpiFvbService modules CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib SimicsIch10Pkg: Remove SmmSpiFlashCommonLib TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib MinPlatformPkg: Remove SpiFlashCommonLibNull KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package IntelSiliconPkg: Add flash region GUIDs IntelSiliconPkg: Identify flash regions by GUID CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID KabylakeSiliconPkg: Identify flash regions by GUID SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonL= ib/SpiCommon.c = | 144 ++++++++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiF= lashCommon.c = | 196 ------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiF= lashCommonSmmLib.c = | 54 ---- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/FvbInfo.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceCommon.c = | 4 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceMm.c = | 8 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c = | 0 Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFla= shCommonSmmLib.c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCo= mmonLib/SmmSpiFlashCommonLib.c | 2 +- {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg= }/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c = | 7 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}= /Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/SecureMemoryMapConfiguration.c= = | 106 ++++++- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c = | 196 ------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommonSmmLib.c = | 54 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/= SpiCommon.c = | 140 +++++++-- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon= .c = | 194 ------------- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon= SmmLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommo= n.c = | 165 ++++++++--- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c = = | 4 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiComm= onLib/SpiCommon.c = | 176 ++++++++++-- Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/FlashMapI= nclude.fdf = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf = | 2 +- Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.= inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclu= de.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilic= onPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/Pei= SerialPortLibSpiFlash.inf = | 1 + Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = = | 2 - Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = = | 6 - Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = = | 6 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = = | 2 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashMapI= nclude.fdf = | 4 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib= /PeiPolicyUpdateLib.inf = | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDx= e.inf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapIncl= ude.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/Pei= MultiBoardInitPreMemLib.inf = | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/Flash= MapInclude.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf = = | 38 +-- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPol= icyLib.inf = | 4 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Private/Library/PchSpiCom= monLib.h = | 16 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonL= ib/BasePchSpiCommonLib.inf = | 13 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmS= piFlashCommonLib.inf = | 51 ---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec = = | 8 - {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceCommon.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceMm.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceSmm.inf = | 6 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Featur= e}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf = | 6 +- Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h = = | 45 +++ Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Li= brary/SpiFlashCommonLib.h = | 2 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Pp= i/Spi.h = | 4 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Pr= otocol/Spi.h = | 39 +-- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = = | 37 +++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = = | 17 ++ {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg= }/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf = | 24 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}= /Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolic= yLib.inf = | 4 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf = = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h= = | 98 ------- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h = = | 26 -- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 293 ------------------- Silicon/Intel/KabylakeSiliconPkg/Pch/IncludePrivate/Library/PchSpiCommon= Lib.h = | 20 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpi= FlashCommonLib.inf = | 53 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/= BasePchSpiCommonLib.inf = | 11 + Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 1 + Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec = = | 13 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = = | 11 - Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h = = | 295 ------------------- Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiCommonLib.h = = | 46 +-- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCom= monLib.inf = | 50 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchS= piCommonLib.inf = | 16 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/TigerlakeSiliconPkg/Include/Protocol/Spi.h = = | 301 -------------------- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/IncludePrivate/Library/Spi= CommonLib.h = | 16 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiComm= onLib/BaseSpiCommonLib.inf = | 19 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTgl.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec = = | 8 - 98 files changed, 1083 insertions(+), 2567 deletions(-) delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpi= FlashCommonLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpi= FlashCommonLib/SpiFlashCommonSmmLib.c rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/FvbInfo.c (100%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.c (96%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c (94%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c (100%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c (100%) rename Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib= /SpiFlashCommonSmmLib.c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpi= FlashCommonLib/SmmSpiFlashCommonLib.c (90%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSil= iconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c (93%) rename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSili= conPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c (83%) delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SpiFlashCommonSmmLib.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommo= nLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommo= nLib/SpiFlashCommonSmmLib.c delete mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlas= hCommonLib.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpi= FlashCommonLib/SmmSpiFlashCommonLib.inf rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceCommon.h (100%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceMm.h (100%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceSmm.inf (88%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg= /Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf (88%) create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegio= n.h rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Inc= lude/Library/SpiFlashCommonLib.h (96%) rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Inc= lude/Ppi/Spi.h (85%) rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Inc= lude/Protocol/Spi.h (89%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSil= iconPkg}/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf (67%) rename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSili= conPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf (91%) delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/= SpiFlashCommonLib.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.= h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol= /Spi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SmmSpiFlashCommonLib.inf delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Library/SpiFlash= CommonLib.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Include/Protocol/Spi.h delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommo= nLib/SmmSpiFlashCommonLib.inf delete mode 100644 Silicon/Intel/TigerlakeSiliconPkg/Include/Protocol/Sp= i.h --=20 2.28.0.windows.1