From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web09.9386.1624877477716384825 for ; Mon, 28 Jun 2021 03:51:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HUaaQTd2; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15SAYsjV109929; Mon, 28 Jun 2021 06:51:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : mime-version; s=pp1; bh=fz7F1xWw25Jr8r3a0ToZEk4WAHfD8OngVkM9oz01R8g=; b=HUaaQTd23WAESKflU+q3WTmk4nuM3VWmXZGfKsZ+2fAUhhmebLA8w+n3KFB/FoadK0Af 7bUbjwj3bTsgPOVbnKMmdZ4NS9xQz/zR5dyL3gHA3uuuiHejStFI7qE1JBcyHd6W31Ky /AegSkgL6pTLJDhltSGw99fj59juOM8b7oFBQILRhi5Sd70oq1Fi58tmTgV274kU7IUb w+c8veLrENZVdFnvusmfoJh5ooNYQHAsSYVqYNyGkTWVD8BV6TMbkATJmaXTEoTEffTx tGd5VNZ2ywjHBUSuxr9azY22YWlml5GXNDDzIqSuNi8l1U7O5MQ8RJ+tzSjmr0kV4U9m LQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39fc1q9sn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 06:51:17 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15SAak5K121014; Mon, 28 Jun 2021 06:51:17 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 39fc1q9smv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 06:51:16 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15SAh5Hi018959; Mon, 28 Jun 2021 10:51:16 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma02dal.us.ibm.com with ESMTP id 39duvakf4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Jun 2021 10:51:16 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15SApFar23724328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jun 2021 10:51:15 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10A94AC05E; Mon, 28 Jun 2021 10:51:15 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E72B9AC069; Mon, 28 Jun 2021 10:51:14 +0000 (GMT) Received: from localhost.localdomain (unknown [9.2.130.16]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 28 Jun 2021 10:51:14 +0000 (GMT) From: "Dov Murik" To: devel@edk2.groups.io Cc: Dov Murik , Laszlo Ersek , Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum Subject: [PATCH v3 5/5] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header Date: Mon, 28 Jun 2021 10:51:10 +0000 Message-Id: <20210628105110.379951-6-dovmurik@linux.ibm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210628105110.379951-1-dovmurik@linux.ibm.com> References: <20210628105110.379951-1-dovmurik@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: eCCTh0ZUsXIozAVJ13d-GWNCg3jYabFj X-Proofpoint-GUID: Xf2FJeCi51bVWiZrKgG3f-Tyg0nqaLpK X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-06-28_09:2021-06-25,2021-06-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106280074 Content-Transfer-Encoding: quoted-printable Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the ground to add a warning about the incompatibility with boot verification process. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: James Bottomley Cc: Tobin Feldman-Fitzthum Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3457 Signed-off-by: Dov Murik Reviewed-by: Laszlo Ersek --- OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++ OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf b/= OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf index e1615badd2ba..c7ec041cb706 100644 --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf @@ -2,6 +2,9 @@ # X86 specific implementation of QemuLoadImageLib library class interface= =0D # with support for loading mixed mode images and non-EFI stub images=0D #=0D +# Note that this implementation reads the cmdline (and possibly kernel, s= etup=0D +# data, and initrd in the legacy boot mode) from fw_cfg directly.=0D +#=0D # Copyright (c) 2020, ARM Ltd. All rights reserved.
=0D #=0D # SPDX-License-Identifier: BSD-2-Clause-Patent=0D diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/Ov= mfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c index 6b1e7e649014..9f30df29736d 100644 --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c @@ -2,6 +2,9 @@ X86 specific implementation of QemuLoadImageLib library class interface= =0D with support for loading mixed mode images and non-EFI stub images=0D =0D + Note that this implementation reads the cmdline (and possibly kernel, se= tup=0D + data, and initrd in the legacy boot mode) from fw_cfg directly.=0D +=0D Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
=0D Copyright (c) 2020, ARM Ltd. All rights reserved.
=0D =0D --=20 2.25.1