From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.77]) by mx.groups.io with SMTP id smtpd.web10.14868.1624902233322573934 for ; Mon, 28 Jun 2021 10:43:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=11nL7XKQ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.93.77, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQqBiNROy92SWOZuCBvtrRw457lJPfrcl+Hp6heQarSNfM80D3QJ6sK5hYCTeeHPJzwn0AtSeb73AH+MWJ5UoCoP7luRWw7JQGp/iYEZpAGH97LfpZLzPIoJ+5GSMorg60Oy1RXceToz89Ol4ljT1cjPSTojPEIfb7YO/UfVbwn6Qjxt2oL16TD07vXY7+NEDvWHWQ2voUvQyzR4d7R0+DxY5swmh8UGS2JVdDI4wNRE5jA74J6M3vOmByB/3CbNmIP/wuCjdrMhifhVYOche3GtJM01fyk9mx8TYzo0+Tn/dkXuEEh7LgIrDPuDUPevpdMO5AcxysA3J5MFCgf60g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U+YEdi/UHs5wd3F9ctTTdROdn1n+U82MnLXrb5PCPVU=; b=PHB3EX1Yj6Ee30nOIoCx32Zok+4WG4crBg3it1vmeEprdEl1C9ToW0JyKgvQMvOwMgq63bkfdveqGUmcsejOSOjkmk6Uqbat21fCRetfWvvk3v/SxdHyO8CMoQmqg66jQICcHXlmVMxScXQk2qiJ0ojgjdWPX1seu1F2UabUH9l4sESx5pFUrljTH7u14FcWPQAwbpVBPuG80u+udHZlPEjrFILMhDLDeFdqH35Qmphuebdw4aIVyR0egauUKroThJ10oNiu2vQ10m3HP85/uLrahP0nOOpo6jnBFB0Te3+oOOqlSaRlN+FotuDp0Xb027owTfjYIDO1EBfnSrRffw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U+YEdi/UHs5wd3F9ctTTdROdn1n+U82MnLXrb5PCPVU=; b=11nL7XKQJtI8Fel4MAuDLOD0+hIW3LRQzY1txNGWLFQR0eFWXWe4P5Cs1p08deW1t/sR2uJYr0UsuKgZ+wdBfky5dDVzlFjvYUVmtrScAsv4YnuS2KC3V4zsa0Cl4S0PdjcKe5Tk+mOkiNnDXiPyzzzJKb2REtEBU1hkkzrSZlw= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2714.namprd12.prod.outlook.com (2603:10b6:5:42::18) by DM6PR12MB4371.namprd12.prod.outlook.com (2603:10b6:5:2a3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Mon, 28 Jun 2021 17:43:52 +0000 Received: from DM6PR12MB2714.namprd12.prod.outlook.com ([fe80::7df8:b0cd:fe1b:ae7b]) by DM6PR12MB2714.namprd12.prod.outlook.com ([fe80::7df8:b0cd:fe1b:ae7b%5]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 17:43:52 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Eric Dong , Ray Ni , Rahul Kumar , Michael D Kinney , Liming Gao , Zhiguang Liu , Michael Roth , Brijesh Singh Subject: [RFC PATCH v4 26/27] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map Date: Mon, 28 Jun 2021 12:42:22 -0500 Message-ID: <20210628174223.1302-27-brijesh.singh@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210628174223.1302-1-brijesh.singh@amd.com> References: <20210628174223.1302-1-brijesh.singh@amd.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0601CA0020.namprd06.prod.outlook.com (2603:10b6:803:2f::30) To DM6PR12MB2714.namprd12.prod.outlook.com (2603:10b6:5:42::18) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SN4PR0601CA0020.namprd06.prod.outlook.com (2603:10b6:803:2f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19 via Frontend Transport; Mon, 28 Jun 2021 17:43:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f18b934b-7062-4f8e-4268-08d93a5c4aed X-MS-TrafficTypeDiagnostic: DM6PR12MB4371: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tlB1Pb/iRSu/JVqQhupIz0pw9fSKOZD+8mdhcXgLtj/rpilYr4H6MiodsElqW/xpnp0D65bqOUXAvsYwaG0ZzbRclibaKKJgDGlubsozYNtbVRQpZ6ZQ+U+NsfWe12RzYnIXc5Ku6aiyb5Mm4DcNZUi40px+Efq0zNXgGn6X5zDUuaJzoMsQ/K+7aPahJeXE2KifVed8Yhx+4dVYgJQmWXEi41f3FEaQNpVeY8PskvKyxC7bXoBoOyFyF05FA3s7eF5+SHdMRdzcZ83RCckJ/LlYD/TQ2SREUCJvnDT/bJRXtG8WECkwDFG0n+GyL9Wf94T9rucWDRyAFvXdSBCfw9+fVpzlYaX2BX24eyN3EUmCx6RY8Ilqv+Xx9HIj71vbocu/I964mwtGyIc6HXJnjwtRqWc0OPxL7MeFwli8snqNKmj4MHnfQhok49Rjav23zZBsLbwW6/fEvdArxG+o/E2hzkGEcxgIczbO9IG8daJVT6ggtcclMquvWyMYJBenXJYEvKyvG0+vpXj6Q5gfcuX+ilUB9kVEyDLZgU/6XPsOE6N44dOxaCjJRDMyytXHKVgKdENwjzYe8S79P9jbAoh1bIRVyjD2NnT07AR0nNq1pLEHAmgxe+dHbFrZ0c8xHtz7OGEYbdX5gBEc4GERUMhsAxcjvrcybRlCBRwxkw5jkUju9f2S1xMaQwe45tr0dUOWVBjmSOr+IAIEnn/6Dg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2714.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(8676002)(8936002)(83380400001)(7416002)(66946007)(1076003)(36756003)(478600001)(7696005)(38100700002)(186003)(38350700002)(2906002)(26005)(44832011)(52116002)(16526019)(6666004)(6916009)(4326008)(54906003)(86362001)(5660300002)(2616005)(66556008)(956004)(66476007)(6486002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AUPIyfdNPBL40Zcv+lmr4CANdmbJzjC4+t5GIv3MCHvuNv03yb7sSMmF9nSY?= =?us-ascii?Q?MCFaQNW0+qBduLoQ7sXfDjT/vnJCbyfr2NeoS6oul9+qPbvtMt31hH6WB4iA?= =?us-ascii?Q?bz8CQSvfE5m7lYltwGfI9zx5Id3Wmoj5c+ydDUBgAkvY6ZVxGzqk35bkCJNa?= =?us-ascii?Q?LtXmZgj+VZ+c6jg0z7lHpnh+/6kECm5XdFYjZrOgfwHr4P5v8IoxySi1S83a?= =?us-ascii?Q?axd2e3VpFiys+r8iDH8y0/Uk3PB0CjPx1gTsrshTkzNP0/ozwY3pmimn64/V?= =?us-ascii?Q?7M+OGa56Rsuttt3yR8IfL1sIZO6yjudQ+eC8trAdAA+pggxY9Lr4waaL9LDy?= =?us-ascii?Q?OB651XbcSqCQNRroYSfY/hFfr1/6ObIJiE60U+QBZg8ptDyEBdERd6oOYT10?= =?us-ascii?Q?8ldNmarTZKWyLgIqX8ZF0d/vkPyem3R++qayA7mWWBye5eZlqRT7gCieFXpU?= =?us-ascii?Q?Ku1pJm+h/u4v27ACWuIhSd58C5qWVPKrIpNpVx9WaUClFS6afUwXK251zpEc?= =?us-ascii?Q?qT2UO2rPhhsuHQiMSMp7BsfohRZVHJPPXPqAfCHXqo0akIGDlt8nqJrPyIEa?= =?us-ascii?Q?u90zlEPYOpl8l1FLJaqk+zqxLm25sYS1iEjP1k4/+pQHBaVP2V/f6oWPPjw6?= =?us-ascii?Q?VbiMNYl8Y8XvIUfdEOEs381ffvpMK0QqqoYBc+T3mKV3NfcGe7gB0q7T8ujm?= =?us-ascii?Q?lRgrByUlFWvFohZOAkpSEgr7O9P+y5NJfi3DzAGiMP65FTZ6bFwBTONKLGsl?= =?us-ascii?Q?E/0NHlSKbELsMtxn3bsTW2I/DLtsWO4qDv69OsYOKkRgSynmsDvzQV32SW/w?= =?us-ascii?Q?UzEvfwY+T9DRxP8qbmOHMiOzPzhPlIXyROwbB7c1MbAW15fSu7x2x7ia21A8?= =?us-ascii?Q?wWaf8oQ/57KN83u0HuMqIIToMUaiLXcblrH8C4Kw1N38YiDIeksKLUU8fXzD?= =?us-ascii?Q?X1GPjQAWemludsK69CZvWy8LYrhs1RuTc0KgjN7VP0YrxzV/IGXDKvbNnx83?= =?us-ascii?Q?cil5OwSlr3ijafvaNL9XYHl4++9JNZ/y9GpElFq34LzIy2jozvS2uOAD84x8?= =?us-ascii?Q?Xph/yvNhFx6ztt98wEdd8YxotmOz4FTOikQohkVE7GQc/8cd1DaDAH5Kvbaw?= =?us-ascii?Q?J0ujp87i/HficnRxXUA+Jfkqw5b4XNQwKHG5/3QkLBJ0uKWaFNaBprex0G83?= =?us-ascii?Q?3a5U3qgJdRQ/L8sPT5Uy0xCQGEDZumJ7wmuodFjsWfQK9FIACFVcXhUKJ942?= =?us-ascii?Q?OTKRn5JWpFjAh2ypb3gQ/4lJs65xnh9WzlXAaklOcX4ZsarmyKUQLYBHT6qH?= =?us-ascii?Q?sKEGuUOAABzjq/G1nIo16G13?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f18b934b-7062-4f8e-4268-08d93a5c4aed X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2714.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 17:43:51.9400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BuVWHs2NNdlpImLSbHtosS3LBsSQeub9H8Zy3I9D9jrPHBEHJ2Kzlv0AqGTV2GncL9dlPo6aLgraCppHVkTbDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4371 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain When SEV-SNP is active, the CPUID and Secrets memory range contains the information that is used during the VM boot. The content need to be persist across the kexec boot. Mark the memory range as Reserved in the EFI map so that guest OS or firmware does not use the range as a system RAM. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Signed-off-by: Brijesh Singh --- OvmfPkg/PlatformPei/PlatformPei.inf | 4 ++++ OvmfPkg/PlatformPei/MemDetect.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/Plat= formPei.inf index bd0ade9f33d7..f22a60e7db0e 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -122,6 +122,10 @@ [FixedPcd] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecGhcbBackupSize gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecretsBase + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecretsSize + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpCpuidBase + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpCpuidSize =20 [FeaturePcd] gUefiOvmfPkgTokenSpaceGuid.PcdCsmEnable diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetec= t.c index 2deec128f464..04e0c4e19f97 100644 --- a/OvmfPkg/PlatformPei/MemDetect.c +++ b/OvmfPkg/PlatformPei/MemDetect.c @@ -817,6 +817,27 @@ InitializeRamRegions ( { QemuInitializeRam (); =20 + if (MemEncryptSevSnpIsEnabled ()) { + // + // If SEV-SNP is enabled, reserve the Secrets and CPUID memory area. + // + // This memory range is given to the PSP by the hypervisor to populate + // the information used during the SNP VM boots, and it need to persis= t + // across the kexec boots. Mark it as EfiReservedMemoryType so that + // the guest firmware and OS does not use it as a system memory. + // + BuildMemoryAllocationHob ( + (EFI_PHYSICAL_ADDRESS)(UINTN) PcdGet32 (PcdOvmfSnpSecretsBase), + (UINT64)(UINTN) PcdGet32 (PcdOvmfSnpSecretsSize), + EfiReservedMemoryType + ); + BuildMemoryAllocationHob ( + (EFI_PHYSICAL_ADDRESS)(UINTN) PcdGet32 (PcdOvmfSnpCpuidBase), + (UINT64)(UINTN) PcdGet32 (PcdOvmfSnpCpuidSize), + EfiReservedMemoryType + ); + } + if (mS3Supported && mBootMode !=3D BOOT_ON_S3_RESUME) { // // This is the memory range that will be used for PEI on S3 resume --=20 2.17.1