From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by mx.groups.io with SMTP id smtpd.web10.300.1625069384828050913 for ; Wed, 30 Jun 2021 09:09:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: nuviainc.com, ip: 209.85.166.72, mailfrom: graeme@nuviainc.com) Received: by mail-io1-f72.google.com with SMTP id x21-20020a5d99150000b02904e00bb129f0so2197201iol.18 for ; Wed, 30 Jun 2021 09:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QiIeXkKbWj4sTIkNkcMg90AWHiNjZKWiX6ffP3wVnXM=; b=AyhN08ZcwExhf/Q89rIEgxKg87iwSPXMXljzANUshvTsHRo1WixwkZOaKWbsZZm1FV IC1e5GWpO35RjQJN+zUmNvUjdu6bjHNPPVLdV+y5snuqJr6BpK1K8/MZRKR7lCqEe1Cb 5gk6mkA/JaN96iaW2omQtFvc/u8+lKr52xEfnrvqCksS2On89KsPZDQ1pWDeFUwXeazN BUOAW9b0jTYFdmLPPGvHZrby8mqHc44QiGy8sJLtarXY6KNEYrwqq57Li4oS82m2i36g 9LHiJK7Ttfxldws7OY4oFQ4bejADIBnfNV5cTkXMn1EAlQ+x54laLn/QNfBerbW3utny vXdw== X-Gm-Message-State: AOAM531blnjVNJQ6VS0muAuMd+Llw3ijxX9xY7+I5SEpWbpv3UzQ+/dN aJDYnhoOv6lNVPm/rWybsAtnv/0X1wuL2fmI7cLAaVMCtpYkZHjC/bpaw7FwLpaLvF4DDeiGANG Nuo3NXVPiP/3IHuiyKs/E+v4HNhGvmlltMz4= X-Google-Smtp-Source: ABdhPJwMQpsMly1jPZwdpRHXbNWh0+DYtNHXKGWVeTD6ALojbSNwFvm2IvKa68IUi7AFcNwu6oZkL5Y0g1GAJiUeIKu/jSTo62ipEA== X-Received: by 2002:a6b:e916:: with SMTP id u22mr8279447iof.155.1625069384199; Wed, 30 Jun 2021 09:09:44 -0700 (PDT) Return-Path: Received: from ggregory-linuxws ([2a02:8010:64d6:0:ad:d50c:ff6a:42]) by smtp.gmail.com with ESMTPSA id t17sm13192780wrs.61.2021.06.30.06.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 06:26:41 -0700 (PDT) Date: Wed, 30 Jun 2021 14:26:39 +0100 From: "Graeme Gregory" To: Grzegorz Bernacki Cc: devel@edk2.groups.io, leif@nuviainc.com, ardb+tianocore@kernel.org, Samer.El-Haj-Mahmoud@arm.com, sunny.Wang@arm.com, mw@semihalf.com, upstream@semihalf.com, jiewen.yao@intel.com, jian.j.wang@intel.com, min.m.xu@intel.com, lersek@redhat.com, sami.mujawar@arm.com, afish@apple.com, ray.ni@intel.com, jordan.l.justen@intel.com, rebecca@bsdio.com, grehan@freebsd.org, thomas.abraham@arm.com, chasel.chiu@intel.com, nathaniel.l.desimone@intel.com, gaoliming@byosoft.com.cn, eric.dong@intel.com, michael.d.kinney@intel.com, zailiang.sun@intel.com, yi.qian@intel.com, rad@semihalf.com, pete@akeo.ie Subject: Re: [edk2-platforms PATCH v4 10/12] ARM Silicon and Platforms: add SecureBootVariableLib class resolution Message-ID: <20210630132639.GA1860@ggregory-linuxws> References: <20210630123412.996158-1-gjb@semihalf.com> <20210630123412.996158-11-gjb@semihalf.com> MIME-Version: 1.0 In-Reply-To: <20210630123412.996158-11-gjb@semihalf.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 30, 2021 at 02:34:10PM +0200, Grzegorz Bernacki wrote: > The edk2 patch > SecurityPkg: Create library for setting Secure Boot variables. > > removes generic functions from SecureBootConfigDxe and places > them into SecureBootVariableLib. This patch adds SecureBootVariableLib > mapping for each ARM platform which uses SecureBootConfigDxe. > For the SBSA Qemu bit Reviewed-by: Graeme Gregory > Signed-off-by: Grzegorz Bernacki > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + > Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + > Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 4 ++++ > 5 files changed, 8 insertions(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index fee7cfcc2d..60fdb244ba 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -129,6 +129,7 @@ > !if $(SECURE_BOOT_ENABLE) == TRUE > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > index 11ce361cdb..b1c4030ec9 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > @@ -156,6 +156,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > # > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 53825bcf62..73f7f2f8c3 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -167,6 +167,7 @@ > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > !else > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index fd73c4d14b..d38fee8fb8 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -164,6 +164,7 @@ > !if $(SECURE_BOOT_ENABLE) == TRUE > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 88454c1f90..41b7c3bced 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -52,6 +52,10 @@ > > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > +!if $(SECURE_BOOT_ENABLE) == TRUE > + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > +!endif > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > -- > 2.25.1 >