public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()
@ 2021-07-01 12:24 Joey Gouly
  2021-07-13 17:05 ` Sami Mujawar
  0 siblings, 1 reply; 3+ messages in thread
From: Joey Gouly @ 2021-07-01 12:24 UTC (permalink / raw)
  To: devel; +Cc: joey.gouly, ardb+tianocore, sami.mujawar, thomas.abraham, nd

Building with Clang showed that `RootComplexCount` and
`DeviceIdMappingArrayCount` were unused. Use the
variables where they were intended to be used.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---

The changes can be seen at https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index e99fbb654f5109321e32905af3763233dffdbc3e..776dec999eb1ef47910835987fa4dae1b69c52fd 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -924,7 +924,7 @@ GetArmNameSpaceObject (
                  CmObjectId,
                  &PlatformRepo->RootComplexInfo,
                  sizeof (PlatformRepo->RootComplexInfo),
-                 1,
+                 RootComplexCount,
                  CmObject
                  );
       break;
@@ -935,7 +935,7 @@ GetArmNameSpaceObject (
                  CmObjectId,
                  PlatformRepo->DeviceIdMapping,
                  sizeof (PlatformRepo->DeviceIdMapping),
-                 ARRAY_SIZE (PlatformRepo->DeviceIdMapping),
+                 DeviceIdMappingArrayCount,
                  Token,
                  GetDeviceIdMappingArray,
                  CmObject
-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()
  2021-07-01 12:24 [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject() Joey Gouly
@ 2021-07-13 17:05 ` Sami Mujawar
  2021-07-14 14:36   ` Sami Mujawar
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2021-07-13 17:05 UTC (permalink / raw)
  To: Joey Gouly, devel; +Cc: ardb+tianocore, thomas.abraham, nd

Hi Joey,

Thank you for this patch. This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 01/07/2021 01:24 PM, Joey Gouly wrote:
> Building with Clang showed that `RootComplexCount` and
> `DeviceIdMappingArrayCount` were unused. Use the
> variables where they were intended to be used.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>
> The changes can be seen at https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1
>
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> index e99fbb654f5109321e32905af3763233dffdbc3e..776dec999eb1ef47910835987fa4dae1b69c52fd 100644
> --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> @@ -924,7 +924,7 @@ GetArmNameSpaceObject (
>                    CmObjectId,
>                    &PlatformRepo->RootComplexInfo,
>                    sizeof (PlatformRepo->RootComplexInfo),
> -                 1,
> +                 RootComplexCount,
>                    CmObject
>                    );
>         break;
> @@ -935,7 +935,7 @@ GetArmNameSpaceObject (
>                    CmObjectId,
>                    PlatformRepo->DeviceIdMapping,
>                    sizeof (PlatformRepo->DeviceIdMapping),
> -                 ARRAY_SIZE (PlatformRepo->DeviceIdMapping),
> +                 DeviceIdMappingArrayCount,
>                    Token,
>                    GetDeviceIdMappingArray,
>                    CmObject


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()
  2021-07-13 17:05 ` Sami Mujawar
@ 2021-07-14 14:36   ` Sami Mujawar
  0 siblings, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2021-07-14 14:36 UTC (permalink / raw)
  To: Joey Gouly, devel@edk2.groups.io
  Cc: ardb+tianocore@kernel.org, Thomas Abraham, nd

Pushed as 8cb431b46a08..564a6a340892

Thanks.

Regards,

Sami Mujawar

On 13/07/2021, 18:05, "Sami Mujawar" <sami.mujawar@arm.com> wrote:

    Hi Joey,

    Thank you for this patch. This patch looks good to me.

    Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

    Regards,

    Sami Mujawar


    On 01/07/2021 01:24 PM, Joey Gouly wrote:
    > Building with Clang showed that `RootComplexCount` and
    > `DeviceIdMappingArrayCount` were unused. Use the
    > variables where they were intended to be used.
    >
    > Signed-off-by: Joey Gouly <joey.gouly@arm.com>
    > ---
    >
    > The changes can be seen at https://github.com/jgouly/edk2-platforms/tree/1766_vexpress_count_v1
    >
    >   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 4 ++--
    >   1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > index e99fbb654f5109321e32905af3763233dffdbc3e..776dec999eb1ef47910835987fa4dae1b69c52fd 100644
    > --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
    > @@ -924,7 +924,7 @@ GetArmNameSpaceObject (
    >                    CmObjectId,
    >                    &PlatformRepo->RootComplexInfo,
    >                    sizeof (PlatformRepo->RootComplexInfo),
    > -                 1,
    > +                 RootComplexCount,
    >                    CmObject
    >                    );
    >         break;
    > @@ -935,7 +935,7 @@ GetArmNameSpaceObject (
    >                    CmObjectId,
    >                    PlatformRepo->DeviceIdMapping,
    >                    sizeof (PlatformRepo->DeviceIdMapping),
    > -                 ARRAY_SIZE (PlatformRepo->DeviceIdMapping),
    > +                 DeviceIdMappingArrayCount,
    >                    Token,
    >                    GetDeviceIdMappingArray,
    >                    CmObject



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-14 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-01 12:24 [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject() Joey Gouly
2021-07-13 17:05 ` Sami Mujawar
2021-07-14 14:36   ` Sami Mujawar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox