* [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg. @ 2021-07-08 14:40 Chiu, Chasel 2021-07-08 14:40 ` [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package Chiu, Chasel 2021-07-08 14:40 ` [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: " Chiu, Chasel 0 siblings, 2 replies; 8+ messages in thread From: Chiu, Chasel @ 2021-07-08 14:40 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Sai Chaganty, Liming Gao, Isaac Oram AdvancedFeaturePkg building failure caused by IpmiFeaturePkg code. This patch series fixed the issue. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Isaac Oram <isaac.w.oram@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> Chasel Chiu (2): IpmiFeaturePkg: Fail to build this package. AdvancedFeaturePkg: Fail to build this package. Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +++++++++++++++++-- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 11 +++++++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h | 17 +++++++++++++++++ 4 files changed, 46 insertions(+), 2 deletions(-) -- 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. 2021-07-08 14:40 [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg Chiu, Chasel @ 2021-07-08 14:40 ` Chiu, Chasel 2021-07-09 2:24 ` Chaganty, Rangasai V 2021-07-08 14:40 ` [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: " Chiu, Chasel 1 sibling, 1 reply; 8+ messages in thread From: Chiu, Chasel @ 2021-07-08 14:40 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Sai Chaganty, Liming Gao, Isaac Oram REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Isaac Oram <isaac.w.oram@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 11 +++++++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h | 17 +++++++++++++++++ 3 files changed, 29 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf index 0ef2c18116..bd995ef25f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf @@ -42,6 +42,7 @@ DebugLib IoLib TimerLib + ReportStatusCodeLib [Guids] diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc index a1fcefad70..05a7d4f0af 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc @@ -59,6 +59,12 @@ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf + + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.inf [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] ####################################### @@ -72,6 +78,11 @@ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.inf + ################################################################################ # # Component section - list of all components that need built for this feature. diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h index 244b86e91a..7591f33aba 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h @@ -149,6 +149,15 @@ typedef enum { #define UPPER_NON_RECOVER_GOING_LOW 0x400 #define UPPER_NON_RECOVER_GOING_HI 0x800 +// +// Definitions for Get BMC Execution Context +// +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + // // Server Management COM Addressing types // @@ -318,6 +327,14 @@ typedef struct { UINT16 IoBasePort; } IPMI_HOB_DATA; +// +// Constants and Structure definitions for "Get Device ID" command to follow here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + // // COM Layer Callback // -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. 2021-07-08 14:40 ` [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package Chiu, Chasel @ 2021-07-09 2:24 ` Chaganty, Rangasai V 2021-07-09 6:31 ` Chiu, Chasel 0 siblings, 1 reply; 8+ messages in thread From: Chaganty, Rangasai V @ 2021-07-09 2:24 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Liming Gao, Oram, Isaac W In ServerManagment.h, please make sure the newly added macros and structure names are EFI/PI spec defined. If they are not, please remove "EFI_" prefix from the names. With that: Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> -----Original Message----- From: Chiu, Chasel <chasel.chiu@intel.com> Sent: Thursday, July 08, 2021 7:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Isaac Oram <isaac.w.oram@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 11 +++++++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h | 17 +++++++++++++++++ 3 files changed, 29 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf index 0ef2c18116..bd995ef25f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf @@ -42,6 +42,7 @@ DebugLib IoLib TimerLib + ReportStatusCodeLib [Guids] diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc index a1fcefad70..05a7d4f0af 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc @@ -59,6 +59,12 @@ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf + + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.inf [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] ####################################### @@ -72,6 +78,11 @@ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiBaseLib.inf + ################################################################################ # # Component section - list of all components that need built for this feature. diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h index 244b86e91a..7591f33aba 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement.h @@ -149,6 +149,15 @@ typedef enum { #define UPPER_NON_RECOVER_GOING_LOW 0x400 #define UPPER_NON_RECOVER_GOING_HI 0x800 +// +// Definitions for Get BMC Execution Context +// +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + // // Server Management COM Addressing types // @@ -318,6 +327,14 @@ typedef struct { UINT16 IoBasePort; } IPMI_HOB_DATA; +// +// Constants and Structure definitions for "Get Device ID" command to follow here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + // // COM Layer Callback // -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. 2021-07-09 2:24 ` Chaganty, Rangasai V @ 2021-07-09 6:31 ` Chiu, Chasel 2021-07-09 6:32 ` Chaganty, Rangasai V 0 siblings, 1 reply; 8+ messages in thread From: Chiu, Chasel @ 2021-07-09 6:31 UTC (permalink / raw) To: Chaganty, Rangasai V, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Liming Gao, Oram, Isaac W Hi Sai, We will fix the build failure first and macro naming convention will be checked separately later. Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this > package. > > In ServerManagment.h, please make sure the newly added macros and > structure names are EFI/PI spec defined. > If they are not, please remove "EFI_" prefix from the names. > With that: > Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> > > -----Original Message----- > From: Chiu, Chasel <chasel.chiu@intel.com> > Sent: Thursday, July 08, 2021 7:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Oram, Isaac W <isaac.w.oram@intel.com> > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this > package. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 > > Fixed the build failure of this package. > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > eiGenericIpmi.inf | 1 + > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > re.dsc | 11 +++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > nagement.h | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > index 0ef2c18116..bd995ef25f 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > @@ -42,6 +42,7 @@ > DebugLib > > IoLib > > TimerLib > > + ReportStatusCodeLib > > > > [Guids] > > > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > index a1fcefad70..05a7d4f0af 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > @@ -59,6 +59,12 @@ > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P > eiServicesTablePointerLibIdt.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > eportStatusCodeLib.inf > > + > > + ##################################### > > + # IPMI Feature Package > > + ##################################### > > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > ib/PeiIpmiBaseLib.inf > > > > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] > > ####################################### > > @@ -72,6 +78,11 @@ > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > > > > + ##################################### > > + # IPMI Feature Package > > + ##################################### > > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > IpmiBaseLib.inf > > + > > > ########################################################## > ###################### > > # > > # Component section - list of all components that need built for this feature. > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > index 244b86e91a..7591f33aba 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > @@ -149,6 +149,15 @@ typedef enum { > #define UPPER_NON_RECOVER_GOING_LOW 0x400 > > #define UPPER_NON_RECOVER_GOING_HI 0x800 > > > > +// > > +// Definitions for Get BMC Execution Context > > +// > > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > > +// > > +// Current Execution Context responses > > +// > > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > > + > > // > > // Server Management COM Addressing types > > // > > @@ -318,6 +327,14 @@ typedef struct { > UINT16 IoBasePort; > > } IPMI_HOB_DATA; > > > > +// > > +// Constants and Structure definitions for "Get Device ID" command to > follow here > > +// > > +typedef struct { > > + UINT8 CurrentExecutionContext; > > + UINT8 PartitionPointer; > > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > > + > > // > > // COM Layer Callback > > // > > -- > 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. 2021-07-09 6:31 ` Chiu, Chasel @ 2021-07-09 6:32 ` Chaganty, Rangasai V 2021-07-09 6:41 ` Chiu, Chasel 0 siblings, 1 reply; 8+ messages in thread From: Chaganty, Rangasai V @ 2021-07-09 6:32 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Liming Gao, Oram, Isaac W Sounds good. -----Original Message----- From: Chiu, Chasel <chasel.chiu@intel.com> Sent: Thursday, July 08, 2021 11:32 PM To: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; devel@edk2.groups.io Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Hi Sai, We will fix the build failure first and macro naming convention will be checked separately later. Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > this package. > > In ServerManagment.h, please make sure the newly added macros and > structure names are EFI/PI spec defined. > If they are not, please remove "EFI_" prefix from the names. > With that: > Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> > > -----Original Message----- > From: Chiu, Chasel <chasel.chiu@intel.com> > Sent: Thursday, July 08, 2021 7:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaganty@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > this package. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 > > Fixed the build failure of this package. > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > eiGenericIpmi.inf | 1 + > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > re.dsc | 11 +++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > nagement.h | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > index 0ef2c18116..bd995ef25f 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > @@ -42,6 +42,7 @@ > DebugLib > > IoLib > > TimerLib > > + ReportStatusCodeLib > > > > [Guids] > > > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > index a1fcefad70..05a7d4f0af 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > @@ -59,6 +59,12 @@ > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId > PeiServicesTablePointerLib|t/P > eiServicesTablePointerLibIdt.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > eportStatusCodeLib.inf > > + > > + ##################################### > > + # IPMI Feature Package > > + ##################################### > > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > ib/PeiIpmiBaseLib.inf > > > > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] > > ####################################### > > @@ -72,6 +78,11 @@ > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > > > > + ##################################### > > + # IPMI Feature Package > > + ##################################### > > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > IpmiBaseLib.inf > > + > > > ########################################################## > ###################### > > # > > # Component section - list of all components that need built for this feature. > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > index 244b86e91a..7591f33aba 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > @@ -149,6 +149,15 @@ typedef enum { > #define UPPER_NON_RECOVER_GOING_LOW 0x400 > > #define UPPER_NON_RECOVER_GOING_HI 0x800 > > > > +// > > +// Definitions for Get BMC Execution Context > > +// > > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > > +// > > +// Current Execution Context responses > > +// > > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > > + > > // > > // Server Management COM Addressing types > > // > > @@ -318,6 +327,14 @@ typedef struct { > UINT16 IoBasePort; > > } IPMI_HOB_DATA; > > > > +// > > +// Constants and Structure definitions for "Get Device ID" command > +to > follow here > > +// > > +typedef struct { > > + UINT8 CurrentExecutionContext; > > + UINT8 PartitionPointer; > > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > > + > > // > > // COM Layer Callback > > // > > -- > 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. 2021-07-09 6:32 ` Chaganty, Rangasai V @ 2021-07-09 6:41 ` Chiu, Chasel 0 siblings, 0 replies; 8+ messages in thread From: Chiu, Chasel @ 2021-07-09 6:41 UTC (permalink / raw) To: Chaganty, Rangasai V, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Liming Gao, Oram, Isaac W Change pushed: 8cb431b46a0888a8ee8e442dc3ea50d7de79e473 107af998afe1a34c7b6aff5240abd9918e51b073 Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> > Sent: Friday, July 9, 2021 2:33 PM > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this > package. > > Sounds good. > > -----Original Message----- > From: Chiu, Chasel <chasel.chiu@intel.com> > Sent: Thursday, July 08, 2021 11:32 PM > To: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; > devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this > package. > > > Hi Sai, > > We will fix the build failure first and macro naming convention will be > checked separately later. > > Thanks, > Chasel > > > > -----Original Message----- > > From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com> > > Sent: Friday, July 9, 2021 10:25 AM > > To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io > > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > > this package. > > > > In ServerManagment.h, please make sure the newly added macros and > > structure names are EFI/PI spec defined. > > If they are not, please remove "EFI_" prefix from the names. > > With that: > > Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> > > > > -----Original Message----- > > From: Chiu, Chasel <chasel.chiu@intel.com> > > Sent: Thursday, July 08, 2021 7:41 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V > > <rangasai.v.chaganty@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> > > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > > this package. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 > > > > Fixed the build failure of this package. > > > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Isaac Oram <isaac.w.oram@intel.com> > > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> > > --- > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > > eiGenericIpmi.inf | 1 + > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > > re.dsc | 11 +++++++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > > nagement.h | 17 +++++++++++++++++ > > 3 files changed, 29 insertions(+) > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > index 0ef2c18116..bd995ef25f 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > @@ -42,6 +42,7 @@ > > DebugLib > > > > IoLib > > > > TimerLib > > > > + ReportStatusCodeLib > > > > > > > > [Guids] > > > > > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > index a1fcefad70..05a7d4f0af 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > @@ -59,6 +59,12 @@ > > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId > > PeiServicesTablePointerLib|t/P > > eiServicesTablePointerLibIdt.inf > > > > + > > > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > > eportStatusCodeLib.inf > > > > + > > > > + ##################################### > > > > + # IPMI Feature Package > > > > + ##################################### > > > > + > > > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > > ib/PeiIpmiBaseLib.inf > > > > > > > > > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] > > > > ####################################### > > > > @@ -72,6 +78,11 @@ > > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > > > > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > > /UefiRuntimeServicesTableLib.inf > > > > > > > > + ##################################### > > > > + # IPMI Feature Package > > > > + ##################################### > > > > + > > > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > > IpmiBaseLib.inf > > > > + > > > > > > > ########################################################## > > ###################### > > > > # > > > > # Component section - list of all components that need built for this > feature. > > > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > index 244b86e91a..7591f33aba 100644 > > --- > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > @@ -149,6 +149,15 @@ typedef enum { > > #define UPPER_NON_RECOVER_GOING_LOW 0x400 > > > > #define UPPER_NON_RECOVER_GOING_HI 0x800 > > > > > > > > +// > > > > +// Definitions for Get BMC Execution Context > > > > +// > > > > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > > > > +// > > > > +// Current Execution Context responses > > > > +// > > > > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > > + > > > > // > > > > // Server Management COM Addressing types > > > > // > > > > @@ -318,6 +327,14 @@ typedef struct { > > UINT16 IoBasePort; > > > > } IPMI_HOB_DATA; > > > > > > > > +// > > > > +// Constants and Structure definitions for "Get Device ID" command > > +to > > follow here > > > > +// > > > > +typedef struct { > > > > + UINT8 CurrentExecutionContext; > > > > + UINT8 PartitionPointer; > > > > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > > > > + > > > > // > > > > // COM Layer Callback > > > > // > > > > -- > > 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package. 2021-07-08 14:40 [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg Chiu, Chasel 2021-07-08 14:40 ` [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package Chiu, Chasel @ 2021-07-08 14:40 ` Chiu, Chasel 2021-07-09 2:26 ` Chaganty, Rangasai V 1 sibling, 1 reply; 8+ messages in thread From: Chiu, Chasel @ 2021-07-08 14:40 UTC (permalink / raw) To: devel; +Cc: Chasel Chiu, Nate DeSimone, Sai Chaganty, Liming Gao, Isaac Oram REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Isaac Oram <isaac.w.oram@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index ced0a97c37..0c7a29cc75 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -7,7 +7,7 @@ # 1. Present a consolidated and simplified view of all available advanced features to board packages. # 2. Provide a simple, single package build for all available advanced features. # -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -30,7 +30,12 @@ PEI_ARCH = IA32 DXE_ARCH = X64 -!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +[Packages] + MdePkg/MdePkg.dec + MinPlatformPkg/MinPlatformPkg.dec + +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc + ################################################################################ # @@ -48,6 +53,16 @@ gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable |TRUE gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable |TRUE gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE + +# +# Include common library +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc # # This package builds all advanced features. -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package. 2021-07-08 14:40 ` [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: " Chiu, Chasel @ 2021-07-09 2:26 ` Chaganty, Rangasai V 0 siblings, 0 replies; 8+ messages in thread From: Chaganty, Rangasai V @ 2021-07-09 2:26 UTC (permalink / raw) To: Chiu, Chasel, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Liming Gao, Oram, Isaac W Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com> -----Original Message----- From: Chiu, Chasel <chasel.chiu@intel.com> Sent: Thursday, July 08, 2021 7:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com> Subject: [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Isaac Oram <isaac.w.oram@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index ced0a97c37..0c7a29cc75 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -7,7 +7,7 @@ # 1. Present a consolidated and simplified view of all available advanced features to board packages. # 2. Provide a simple, single package build for all available advanced features. # -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -30,7 +30,12 @@ PEI_ARCH = IA32 DXE_ARCH = X64 -!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc +[Packages] + MdePkg/MdePkg.dec + MinPlatformPkg/MinPlatformPkg.dec + +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc + ################################################################################ # @@ -48,6 +53,16 @@ gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable |TRUE gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable |TRUE gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE + +# +# Include common library +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc # # This package builds all advanced features. -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-09 6:41 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-07-08 14:40 [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg Chiu, Chasel 2021-07-08 14:40 ` [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package Chiu, Chasel 2021-07-09 2:24 ` Chaganty, Rangasai V 2021-07-09 6:31 ` Chiu, Chasel 2021-07-09 6:32 ` Chaganty, Rangasai V 2021-07-09 6:41 ` Chiu, Chasel 2021-07-08 14:40 ` [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: " Chiu, Chasel 2021-07-09 2:26 ` Chaganty, Rangasai V
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox