public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashraf Ali S" <ashraf.ali.s@intel.com>
To: devel@edk2.groups.io
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Debkumar De <debkumar.de@intel.com>,
	Harry Han <harry.han@intel.com>,
	Catharine West <catharine.west@intel.com>,
	Sangeetha V <sangeetha.v@intel.com>
Subject: [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug prints
Date: Fri, 23 Jul 2021 14:10:23 +0530	[thread overview]
Message-ID: <20210723084023.22157-2-ashraf.ali.s@intel.com> (raw)
In-Reply-To: <20210723084023.22157-1-ashraf.ali.s@intel.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3506

Before executing the nasm command, added print statement to know what
commands are executing.
before printing the output file need check the status of command which
is executed. if the status is 0 then only print the output file name.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Debkumar De <debkumar.de@intel.com>
Cc: Harry Han <harry.han@intel.com>
Cc: Catharine West <catharine.west@intel.com>
Cc: Sangeetha V <sangeetha.v@intel.com>
Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>
---
 UefiCpuPkg/ResetVector/Vtf0/Build.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/UefiCpuPkg/ResetVector/Vtf0/Build.py b/UefiCpuPkg/ResetVector/Vtf0/Build.py
index 55f4edd87b..b791d32762 100644
--- a/UefiCpuPkg/ResetVector/Vtf0/Build.py
+++ b/UefiCpuPkg/ResetVector/Vtf0/Build.py
@@ -32,9 +32,12 @@ for arch in ('ia32', 'x64'):
             '-o', output,
             'Vtf0.nasmb',
             )
+        print(f"Command : {' '.join(commandLine)}")
         ret = RunCommand(commandLine)
+        if ret != 0:
+            print(f"something went wrong while executing {commandLine[-1]}")
+            sys.exit()
         print('\tASM\t' + output)
-        if ret != 0: sys.exit(ret)
 
         commandLine = (
             'python',
-- 
2.30.2.windows.1


  reply	other threads:[~2021-07-23  8:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  8:40 [PATCH v2 1/2] UefiCpuPkg: ResetVector Tool Support for Python 3 Ashraf Ali S
2021-07-23  8:40 ` Ashraf Ali S [this message]
2021-07-27  5:11   ` [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug prints Ni, Ray
2021-08-15 16:31     ` Ashraf Ali S
2021-07-27  5:11 ` [PATCH v2 1/2] UefiCpuPkg: ResetVector Tool Support for Python 3 Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723084023.22157-2-ashraf.ali.s@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox