From: "Sunny Wang" <Sunny.Wang@arm.com>
To: devel@edk2.groups.io
Cc: Sunny Wang <Sunny.Wang@arm.com>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Jeremy Linton <jeremy.linton@arm.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Pete Batard <pete@akeo.ie>, Leif Lindholm <leif@nuviainc.com>,
Sunny Wang <sunny.wang@arm.com>
Subject: [edk2-platform PATCH v1 1/1] Platform/RaspberryPi: Make SetVariable return EFI_UNSUPPORTED at runtime
Date: Fri, 23 Jul 2021 17:15:21 +0800 [thread overview]
Message-ID: <20210723091521.1663-1-Sunny.Wang@arm.com> (raw)
The RPi does not support storing UEFI NV variables at runtime. For now,
gRT->SetVariable at runtime returns EFI_OUT_OF_RESOURCES which is not a
proper error and would cause FWTS failures. Therefore, this patch is
to make gRT->SetVariable at runtime return EFI_UNSUPPORTED.
For more information, please check the issues below:
-https://github.com/pftf/RPi4/issues/6
-https://github.com/pftf/RPi4/issues/93
-https://github.com/pftf/RPi4/issues/163
I also tested this with the ACS 3.0 FWTS. All the failures
reported in issue 93 and 163 can be fixed by this patch.
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Pete Batard <pete@akeo.ie>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Sunny Wang <sunny.wang@arm.com>
---
.../Drivers/VarBlockServiceDxe/VarBlockService.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockService.c b/Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockService.c
index 572309439a..16d4d4f178 100644
--- a/Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockService.c
+++ b/Platform/RaspberryPi/Drivers/VarBlockServiceDxe/VarBlockService.c
@@ -2,6 +2,7 @@
*
* Copyright (c) 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
* Copyright (c) 2006-2014, Intel Corporation. All rights reserved.
+ * Copyright (c) 2021, ARM Limited. All rights reserved.
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*
@@ -596,6 +597,7 @@ FvbProtocolWrite (
EFI_DEVICE_ERROR - The block device is not functioning correctly and
could not be written
EFI_INVALID_PARAMETER - NumBytes or Buffer are NULL
+ EFI_UNSUPPORTED This function is not supported at runtime
--*/
{
@@ -605,6 +607,16 @@ FvbProtocolWrite (
EFI_STATUS Status;
EFI_STATUS ReturnStatus;
+ //
+ // The current variables support relies on modifying RPI_EFI.FD on SD
+ // card, which works fine at boot time. However, at runtime, the SD
+ // controller is exposed via ACPI and subsequently owned by the OS.
+ // Therefore, we need to direclty return EFI_UNSUPPORTED.
+ //
+ if (EfiAtRuntime ()) {
+ return EFI_UNSUPPORTED;
+ }
+
//
// Check for invalid conditions.
//
--
2.31.0.windows.1
next reply other threads:[~2021-07-23 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 9:15 Sunny Wang [this message]
2021-07-23 15:09 ` [edk2-platform PATCH v1 1/1] Platform/RaspberryPi: Make SetVariable return EFI_UNSUPPORTED at runtime Ard Biesheuvel
2021-07-26 7:18 ` Sunny Wang
2021-07-26 15:56 ` Ard Biesheuvel
2022-02-13 16:01 ` [edk2-devel] " Tinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723091521.1663-1-Sunny.Wang@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox