[edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry
@ 2021-07-26 22:56 Benjamin Doron
  2021-07-29  6:02 ` Chiu, Chasel
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Benjamin Doron @ 2021-07-26 22:56 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

In the case that there are too many EfiRuntimeServicesData entries, this
was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
 Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
     DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount[EfiRuntimeServicesCode]));
   }
   if (EntryCount[EfiRuntimeServicesData] > 1) {
-    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));
+    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesData]));
   }
   if (EntryCount[EfiACPIMemoryNVS] > 1) {
     DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiACPIMemoryNVS]));
@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
 Done:
   DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap - Exit\n"));
   return Status;
-}
\ No newline at end of file
+}
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry
  2021-07-26 22:56 [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry Benjamin Doron
@ 2021-07-29  6:02 ` Chiu, Chasel
  2021-08-13  5:24 ` Nate DeSimone
  2021-08-13  5:28 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2021-07-29  6:02 UTC (permalink / raw)
  To: Benjamin Doron, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Liming Gao, Dong, Eric


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Benjamin Doron <benjamin.doron00@gmail.com>
> Sent: Tuesday, July 27, 2021 6:56 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib:
> Correctly print memory map entry
> 
> In the case that there are too many EfiRuntimeServicesData entries, this was
> incorrectly printing the number of EfiRuntimeServicesCode entries.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
> 
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMem
> oryMap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> index fce44bf73e9d..b8ebac8fe304 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
> +++ eckMemoryMap.c
> @@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
>      DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n",
> EntryCount[EfiRuntimeServicesCode]));   }   if
> (EntryCount[EfiRuntimeServicesData] > 1) {-    DEBUG ((DEBUG_ERROR,
> "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+
> DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n",
> EntryCount[EfiRuntimeServicesData]));   }   if (EntryCount[EfiACPIMemoryNVS] >
> 1) {     DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n",
> EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@
> TestPointCheckUefiMemoryMap (
>  Done:   DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap -
> Exit\n"));   return Status;-}
> \ No newline at end of file
> +}--
> 2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry
  2021-07-26 22:56 [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry Benjamin Doron
  2021-07-29  6:02 ` Chiu, Chasel
@ 2021-08-13  5:24 ` Nate DeSimone
  2021-08-13  5:28 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-08-13  5:24 UTC (permalink / raw)
  To: Benjamin Doron, devel@edk2.groups.io; +Cc: Chiu, Chasel, Liming Gao, Dong, Eric

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com> 
Sent: Monday, July 26, 2021 3:56 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

In the case that there are too many EfiRuntimeServicesData entries, this was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
 Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
     DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount[EfiRuntimeServicesCode]));   }   if (EntryCount[EfiRuntimeServicesData] > 1) {-    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesData]));   }   if (EntryCount[EfiACPIMemoryNVS] > 1) {     DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
 Done:   DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap - Exit\n"));   return Status;-}
\ No newline at end of file
+}--
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry
  2021-07-26 22:56 [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry Benjamin Doron
  2021-07-29  6:02 ` Chiu, Chasel
  2021-08-13  5:24 ` Nate DeSimone
@ 2021-08-13  5:28 ` Nate DeSimone
  2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-08-13  5:28 UTC (permalink / raw)
  To: Benjamin Doron, devel@edk2.groups.io; +Cc: Chiu, Chasel, Liming Gao, Dong, Eric

Pushed: https://github.com/tianocore/edk2-platforms/commit/c9fff3e

-----Original Message-----
From: Benjamin Doron <benjamin.doron00@gmail.com> 
Sent: Monday, July 26, 2021 3:56 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

In the case that there are too many EfiRuntimeServicesData entries, this was incorrectly printing the number of EfiRuntimeServicesCode entries.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
 Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
index fce44bf73e9d..b8ebac8fe304 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryMap.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckMemoryMap.c
@@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
     DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n", EntryCount[EfiRuntimeServicesCode]));   }   if (EntryCount[EfiRuntimeServicesData] > 1) {-    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+    DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesData]));   }   if (EntryCount[EfiACPIMemoryNVS] > 1) {     DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n", EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@ TestPointCheckUefiMemoryMap (
 Done:   DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap - Exit\n"));   return Status;-}
\ No newline at end of file
+}--
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-13  5:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-26 22:56 [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry Benjamin Doron
2021-07-29  6:02 ` Chiu, Chasel
2021-08-13  5:24 ` Nate DeSimone
2021-08-13  5:28 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox