public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib
@ 2021-07-28  5:04 Abner Chang
  2021-08-08 12:59 ` Nickle Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Abner Chang @ 2021-07-28  5:04 UTC (permalink / raw)
  To: devel; +Cc: Nickle Wang

Move RefishCrtLib from PrivateInclude to Include.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
 RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h  | 2 +-
 .../RedfishLib/edk2libredfish/include/redfishPayload.h          | 2 +-
 .../RedfishLib/edk2libredfish/include/redfishService.h          | 2 +-
 .../PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h (96%)

diff --git a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
similarity index 96%
rename from RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
rename to RedfishPkg/Include/Library/RedfishCrtLib.h
index 28a493d782..5e15768938 100644
--- a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
+++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
@@ -2,7 +2,7 @@
   Redfish CRT wrapper functions.
 
   Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
-  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+  (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
 
     SPDX-License-Identifier: BSD-2-Clause-Patent
 
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
index 03380d9394..43149f3c89 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
@@ -17,7 +17,7 @@
 #ifndef LIBREDFISH_REDFISH_PAYLOAD_H_
 #define LIBREDFISH_REDFISH_PAYLOAD_H_
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <jansson.h>
 #include <redfishService.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
index 5bcb381c05..0215caccfc 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
@@ -30,7 +30,7 @@
 #include <Library/UefiRuntimeServicesTableLib.h>
 #include <Library/UefiBootServicesTableLib.h>
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <Protocol/EdkIIRedfishConfigHandler.h>
 #include <Protocol/RestEx.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
index bdec6098e5..24413a648a 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
@@ -17,7 +17,7 @@
 #ifndef LIBREDFISH_REDPATH_H_
 #define LIBREDFISH_REDPATH_H_
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <jansson.h>
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib
  2021-07-28  5:04 [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib Abner Chang
@ 2021-08-08 12:59 ` Nickle Wang
  2021-08-11  3:59   ` Abner Chang
  0 siblings, 1 reply; 3+ messages in thread
From: Nickle Wang @ 2021-08-08 12:59 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io

Reviewed-by: Nickle Wang <nickle.wang@hpe.com>

Thanks,
Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> 
Sent: Wednesday, July 28, 2021 1:04 PM
To: devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
Subject: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib

Move RefishCrtLib from PrivateInclude to Include.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
 RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h  | 2 +-
 .../RedfishLib/edk2libredfish/include/redfishPayload.h          | 2 +-
 .../RedfishLib/edk2libredfish/include/redfishService.h          | 2 +-
 .../PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)  rename RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h (96%)

diff --git a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
similarity index 96%
rename from RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
rename to RedfishPkg/Include/Library/RedfishCrtLib.h
index 28a493d782..5e15768938 100644
--- a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
+++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
@@ -2,7 +2,7 @@
   Redfish CRT wrapper functions.
 
   Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
-  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+  (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
 
     SPDX-License-Identifier: BSD-2-Clause-Patent
 
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
index 03380d9394..43149f3c89 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPayload.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
+++ hPayload.h
@@ -17,7 +17,7 @@
 #ifndef LIBREDFISH_REDFISH_PAYLOAD_H_
 #define LIBREDFISH_REDFISH_PAYLOAD_H_
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <jansson.h>
 #include <redfishService.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
index 5bcb381c05..0215caccfc 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishService.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
+++ hService.h
@@ -30,7 +30,7 @@
 #include <Library/UefiRuntimeServicesTableLib.h>
 #include <Library/UefiBootServicesTableLib.h>
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <Protocol/EdkIIRedfishConfigHandler.h>
 #include <Protocol/RestEx.h>
diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
index bdec6098e5..24413a648a 100644
--- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
+++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpat
+++ h.h
@@ -17,7 +17,7 @@
 #ifndef LIBREDFISH_REDPATH_H_
 #define LIBREDFISH_REDPATH_H_
 
-#include <PrivateInclude/Library/RedfishCrtLib.h>
+#include <Include/Library/RedfishCrtLib.h>
 
 #include <jansson.h>
 
--
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib
  2021-08-08 12:59 ` Nickle Wang
@ 2021-08-11  3:59   ` Abner Chang
  0 siblings, 0 replies; 3+ messages in thread
From: Abner Chang @ 2021-08-11  3:59 UTC (permalink / raw)
  To: Wang, Nickle (HPS SW), devel@edk2.groups.io

Hi Nickle,
I sent the V2 patch to add the change on RedfishPkg.yaml file. Please review it again.

Thanks
Abner
> -----Original Message-----
> From: Wang, Nickle (HPS SW)
> Sent: Sunday, August 8, 2021 9:00 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Subject: RE: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib
> 
> Reviewed-by: Nickle Wang <nickle.wang@hpe.com>
> 
> Thanks,
> Nickle
> 
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Wednesday, July 28, 2021 1:04 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib
> 
> Move RefishCrtLib from PrivateInclude to Include.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
>  RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h  | 2 +-
>  .../RedfishLib/edk2libredfish/include/redfishPayload.h          | 2 +-
>  .../RedfishLib/edk2libredfish/include/redfishService.h          | 2 +-
>  .../PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)  rename
> RedfishPkg/{PrivateInclude => Include}/Library/RedfishCrtLib.h (96%)
> 
> diff --git a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
> b/RedfishPkg/Include/Library/RedfishCrtLib.h
> similarity index 96%
> rename from RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
> rename to RedfishPkg/Include/Library/RedfishCrtLib.h
> index 28a493d782..5e15768938 100644
> --- a/RedfishPkg/PrivateInclude/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -2,7 +2,7 @@
>    Redfish CRT wrapper functions.
> 
>    Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> -  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +  (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> 
>      SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> diff --git
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPaylo
> ad.h
> b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPaylo
> ad.h
> index 03380d9394..43149f3c89 100644
> ---
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishPaylo
> ad.h
> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
> +++ hPayload.h
> @@ -17,7 +17,7 @@
>  #ifndef LIBREDFISH_REDFISH_PAYLOAD_H_
>  #define LIBREDFISH_REDFISH_PAYLOAD_H_
> 
> -#include <PrivateInclude/Library/RedfishCrtLib.h>
> +#include <Include/Library/RedfishCrtLib.h>
> 
>  #include <jansson.h>
>  #include <redfishService.h>
> diff --git
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishServic
> e.h
> b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishServic
> e.h
> index 5bcb381c05..0215caccfc 100644
> ---
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfishServic
> e.h
> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redfis
> +++ hService.h
> @@ -30,7 +30,7 @@
>  #include <Library/UefiRuntimeServicesTableLib.h>
>  #include <Library/UefiBootServicesTableLib.h>
> 
> -#include <PrivateInclude/Library/RedfishCrtLib.h>
> +#include <Include/Library/RedfishCrtLib.h>
> 
>  #include <Protocol/EdkIIRedfishConfigHandler.h>
>  #include <Protocol/RestEx.h>
> diff --git
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
> b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
> index bdec6098e5..24413a648a 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpath.h
> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/include/redpat
> +++ h.h
> @@ -17,7 +17,7 @@
>  #ifndef LIBREDFISH_REDPATH_H_
>  #define LIBREDFISH_REDPATH_H_
> 
> -#include <PrivateInclude/Library/RedfishCrtLib.h>
> +#include <Include/Library/RedfishCrtLib.h>
> 
>  #include <jansson.h>
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-11  3:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-28  5:04 [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib Abner Chang
2021-08-08 12:59 ` Nickle Wang
2021-08-11  3:59   ` Abner Chang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox