[edk2-platforms PATCH v1 0/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

[edk2-platforms PATCH v1 0/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

[Takuto Naito]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3514

v1:
https://github.com/naitaku/edk2-platforms/tree/bug3514_v1

Cc: Agyeman Prince <prince.agyeman@intel.com>

Takuto Naito (1):
  Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

 .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

[edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

[Takuto Naito]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3514

PcdVideoHorizontalResolution and PcdVideoVerticalResolutio are set in
the SimicsDxe module and consumed by the other module GraphicsConsoleDxe.
In this case, the type of these PCDs should be Dynamic.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
 .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
index 251f46f812..88009b8f10 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
@@ -221,8 +221,6 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1
 !endif
   gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
-  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
-  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
   gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000
 
   ######################################
@@ -238,6 +236,8 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0
+  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
+  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
 
   ######################################
   # Board Configuration
-- 
2.25.1

Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Takuto Naito
> Sent: Thursday, July 29, 2021 7:54 AM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Agyeman, Prince <prince.agyeman@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3514
> 
> PcdVideoHorizontalResolution and PcdVideoVerticalResolutio are set in
> the SimicsDxe module and consumed by the other module GraphicsConsoleDxe.
> In this case, the type of these PCDs should be Dynamic.
> 
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
>  .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> index 251f46f812..88009b8f10 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> @@ -221,8 +221,6 @@
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1
>  !endif
>    gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
>    gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000
> 
>    ######################################
> @@ -238,6 +236,8 @@
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
> 
>    ######################################
>    # Board Configuration
> --
> 2.25.1
> 
> 
> 
> 
>