From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mx.groups.io with SMTP id smtpd.web08.10766.1627570510085347304 for ; Thu, 29 Jul 2021 07:55:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b99Nqxdi; spf=pass (domain: gmail.com, ip: 209.85.216.51, mailfrom: naitaku@gmail.com) Received: by mail-pj1-f51.google.com with SMTP id j1so10666205pjv.3 for ; Thu, 29 Jul 2021 07:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XnFEb6dFxefBPfZ60z5y5U3QzSZXr/tw3NuoxiT5Lgs=; b=b99NqxdinFD7MdyrL0c3pqa3xQn06iL3eP7Wf8vw4h+fMpELIfNWJf7evoF3Y9QSsz SIy81BUvCYhAlkNwbaDsy6wH/Fa4NXOHviskckeZaRAEk8CJY0r8JhF/OSq81tkrSyUX zzbrfbO7b1gI4ET0nGDPrZY1NR8DPQGEPix6FfMs2qYZYgkhrgdgUufpVgAoopDcl+ug e7v4K6gSm0Y9nW3maa/q6boTf8ZlYS/iU/PcLuIjg3BKa/wV+/gyyaJtTsNVZnr3YYOS 8kc/epYoFi1gVDqUu4a2KHo1dLU5OM75/x26GeJarZroa+yE+orTeWo9k+YNztosQFrr V9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XnFEb6dFxefBPfZ60z5y5U3QzSZXr/tw3NuoxiT5Lgs=; b=gwynwktsaMc44YImYSHLoKsS3DtJWxjASvIA0iIclvmJWO9OjWCzHDaUsMGq/UX13J /T/zLYYKFh+0ccZziD9tRIQiibtDdbjzjXHE6tu4pTTQE0iM5OtJ76y8VVOGUSuwFK+X MiHfzPlBa/sdNIDNwEAMqNUyscTsIfPY8NB9cRtYyq9NcUXwbPFENDJys//6riCbLnZn P4a9fQ6NeV9Fhr0mP8UIObGG5hgJH3l6vQoiu8eQ6Jl4ZyUJkZhlifndwcawkfpw+KnD AEGUGOCb1pv0dqIqKvh1lK8UVMK2MCx4QP1CovZhvZuGtG38G5Uk5v/ZZzL1b0zRHw1C TKMA== X-Gm-Message-State: AOAM533WsyO88/kqiD5t/0iRkm+g5OZ5AK9xmWGIzRoo68SqgCbMNrO3 plE3QgKhbZJ0rlnEyL1J9umq/CA1Mnktxey8 X-Google-Smtp-Source: ABdhPJwAkBdiw1eybSCJp24M3oYsD9DFDIFpxu9a5nIKoeZNgE8lHrGADL51wCFYDIwCAZpKitqGpA== X-Received: by 2002:a63:4c03:: with SMTP id z3mr4129445pga.130.1627570509244; Thu, 29 Jul 2021 07:55:09 -0700 (PDT) Return-Path: Received: from localhost.localdomain (fp93c0ba2e.oski110.ap.nuro.jp. [147.192.186.46]) by smtp.googlemail.com with ESMTPSA id 20sm4198871pfi.170.2021.07.29.07.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:55:08 -0700 (PDT) From: "Takuto Naito" To: devel@edk2.groups.io Cc: Takuto Naito , Agyeman Prince Subject: [edk2-platforms PATCH v1 1/1] Platform/Intel/SimicsOpenBoardPkg: Fix PCD type of PcdVideo*Resolution Date: Thu, 29 Jul 2021 14:54:11 +0000 Message-Id: <20210729145411.23659-2-naitaku@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210729145411.23659-1-naitaku@gmail.com> References: <20210729145411.23659-1-naitaku@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3514 PcdVideoHorizontalResolution and PcdVideoVerticalResolutio are set in the SimicsDxe module and consumed by the other module GraphicsConsoleDxe. In this case, the type of these PCDs should be Dynamic. Cc: Agyeman Prince Signed-off-by: Takuto Naito --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index 251f46f812..88009b8f10 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc @@ -221,8 +221,6 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1 !endif gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000 ###################################### @@ -238,6 +236,8 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024 + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 ###################################### # Board Configuration -- 2.25.1