From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.49]) by mx.groups.io with SMTP id smtpd.web12.21203.1627633673471231574 for ; Fri, 30 Jul 2021 01:27:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=YrWCeQWi; spf=pass (domain: arm.com, ip: 40.107.21.49, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vk81OwogEiUOEGioN8ITJ0VfHicrSVJput8Afz2JVpE=; b=YrWCeQWiSQAPkB/CLKbWcmWCMJ2ot4y2FRzPVnKA+qC+50PSHM2kLOeV1FI7jl8kx0mncDCb9ovO1RFbUKfHc0FY2E+KssDkxJhLijiZ56UT3L+vu1lk+sFLxYAnvgq2ysBtz7nDCPLkQ45z3rzHgJqkeUhquha+6ixqPGMOSNA= Received: from DB6PR1001CA0004.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::14) by DB9PR08MB6618.eurprd08.prod.outlook.com (2603:10a6:10:263::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.26; Fri, 30 Jul 2021 08:27:39 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::2b) by DB6PR1001CA0004.outlook.office365.com (2603:10a6:4:b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20 via Frontend Transport; Fri, 30 Jul 2021 08:27:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 08:27:39 +0000 Received: ("Tessian outbound cee5995f7b16:v100"); Fri, 30 Jul 2021 08:27:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1dd4fe3aaa8fa25d X-CR-MTA-TID: 64aa7808 Received: from e902077b0cb5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77F37DAD-273F-415A-9218-5F797AEF3449.1; Fri, 30 Jul 2021 08:27:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e902077b0cb5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Jul 2021 08:27:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8tfOqIZbVJ9yOZ2npUVvOTyzmFtSywWhPOkgmcoS8X1vUKQtL9HDJ1UWa8cBeezzVREfbliKTXz3dxpo9dz3svKvu6w3eVwWFA952TnIequxZyv1LbqOgNDwbLCDh7nWMG+wS0FzN7Q23VJqlAlZCvgL9Nh1ru5Gkgi4bUkV/RvN4cblbvRqMRd98uibzTz1CKkdaM9mIzbmJfOFvemRXEC/Yszb6UhfvNXihxDDi43V6Qb64s70gXUih84KnDdQs/X0z3niR2AI0DdSPLq30JG8xceG06TXHxcR15PVbNpYyv0UK00TtqnoEJd8R28AZP4i2yaaFEqdmeMCjvO7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vk81OwogEiUOEGioN8ITJ0VfHicrSVJput8Afz2JVpE=; b=n1PerkCP6xo9westdgw9fsR3zrXw4mZ9fNBqNxGAtksjg5VBABI/hjWbIFoqWeZV/PTOQlAB3P99+aCOAre12XzV7wyxBya4ogiIW7KmwBmRn/26V7xxZ3LQUa6EuIn20rCDoGiS1cY7EbGx2exzEvD+Rft7UURzfdfqQu2/m3CZxnUt7aqPKpc82LFbZxKXSh6Pjim5LAK/nxmkKQIHSNN4MztpS9n2m1MbYKF1yzDYQlbGoTZ+qtuflsYyJTxthgMX1vRHdWnBCkqtk5tudshbNbyx4iEJ7nL5CZ2dSF7EB0Ko2jYJStZhjf+9r73pWC5IUvp8UPLYO++J91EkrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vk81OwogEiUOEGioN8ITJ0VfHicrSVJput8Afz2JVpE=; b=YrWCeQWiSQAPkB/CLKbWcmWCMJ2ot4y2FRzPVnKA+qC+50PSHM2kLOeV1FI7jl8kx0mncDCb9ovO1RFbUKfHc0FY2E+KssDkxJhLijiZ56UT3L+vu1lk+sFLxYAnvgq2ysBtz7nDCPLkQ45z3rzHgJqkeUhquha+6ixqPGMOSNA= Received: from AS8PR05CA0002.eurprd05.prod.outlook.com (2603:10a6:20b:311::7) by AM4PR08MB2801.eurprd08.prod.outlook.com (2603:10a6:205:9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Fri, 30 Jul 2021 08:27:30 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::34) by AS8PR05CA0002.outlook.office365.com (2603:10a6:20b:311::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21 via Frontend Transport; Fri, 30 Jul 2021 08:27:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 08:27:30 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 30 Jul 2021 08:26:55 +0000 Received: from e125153.arm.com (10.57.39.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 30 Jul 2021 08:26:55 +0000 From: "Chris Jones" To: CC: , , , , , , , Subject: [PATCH v1 13/13] MdePkg: Fix broken coding style in Acpi64.h Date: Fri, 30 Jul 2021 09:26:49 +0100 Message-ID: <20210730082649.15343-14-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210730082649.15343-1-christopher.jones@arm.com> References: <20210730082649.15343-1-christopher.jones@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e7dba33-4fbe-45af-7f2c-08d95333e4cb X-MS-TrafficTypeDiagnostic: AM4PR08MB2801:|DB9PR08MB6618: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502;OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 87TLEv4EK0d1Xw1n4ZICTKkeX8S3NbvD25RwWclMRmsfND7E4X6oKA8eljPFsBtxIEChgfXw7g3TCWgW0iWtzztH/twOpNptVf6bav04buuXlG0QBO888torpA8trqBCCcu7v+6YsyJSM9kv6Buo/IY4cPgG+yCNkJpWMtCC9t0zguCLpgqdWhHO6d5M24UqFwv/quFXIFhgKaYJHvmVQGTupy/OSP6oLkSt6DrNDyHyR6Thva7TG/4wz23rZq8MZjY3RjCU/9MLbe3aEHhoNrqF/Rj4xCvSRO7+1RAxAXqSx8LQh3hstpTcZyanGVnA6UCT3OMrlYtvsX/yBNRJn3dZiNRywyAohW+k0QcfVvK2LSrh8Gi3jGM57VySzX2kl0jRaGX1U6CLYdkLt8rcG+B/1PH8DR3EcYD8Lub4Zcf2aYb/9U1IlLtSufdFR+FOfWkVdlootTs3ahOkbVcMdy7jH3gB5iazklvTwDJFQtAYobk7SL3rdZvglgkCbtdavAAC2gedp8nz+QyDUFzERxbdR0Q+MYtqp1C8f0oaRbAryv5Pr+2Et6EOYgz5PVY3gRsXwBDRpPf4drFsIJRzOh9S10YxsLh2cRWZznS4oztO9pWsLD3PYlA3J03R0TCLrP5tItPa5lGhI0UXEbJROXMPsHNZLXgrZrkSLgTUWmcvtcrOkkicoobPERBbs1+zMXA5xQrRdj++ykI+y+/uWT7I64xcaJcsl+wzteXPRAQ= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(136003)(39850400004)(36840700001)(46966006)(82740400003)(356005)(8676002)(86362001)(70586007)(186003)(6666004)(316002)(83380400001)(26005)(478600001)(5660300002)(54906003)(81166007)(8936002)(4326008)(36860700001)(36756003)(6916009)(1076003)(19627235002)(426003)(47076005)(7696005)(336012)(70206006)(82310400003)(2906002)(2616005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2801 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b85494be-5a06-41f1-178b-08d95333df1c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AOkWp/BRMgfq+53FJVAVLtm3OyzQTyT9PI4obu36FTFa+VrpKsJzv9SOnV+wdPOb0kp+Al74p91bDMCNp3pVkJi3jbMb2aVDUhHVr/zNF62xrvz83fDiUCTdOuTYNuA3gC+laZP3HCA6WqfK723H1t8dvl3kj3oWHLFNC2d8K1MZ09RdYAWo3Vb5VecTm9ti3onaKAulsn7q9426+WzfXPEff1a2uRepOGQUOMZWh0LpaFIi+j/UsCfxYl7h+JWC32T+6y8cXuKTjdtdEq5XRIT2y24JkdEEG6RRB9CNS1+T5ZGEJzuElpVEn5kLBcZk3MIGzrypwLIjgTlYD81gVfqL2RHq2XdUxjIlzWK/MAFBWNRDPucdGalTKCBKdMwlz/v8s6ZCpJMEvMdK72feRh7MPsM8Qq58rKDBRc4XV/hlMtLrXqa+gJvmzgN3TUrxRvfNju6co4O6utISs1BBtop4PfpfFqNf+7Cz8QUanB8d8wuk2fgUTB79KSafkMuKtjgxw5uWe8XT0NBSg7zCv2LaAHpGLhx5O3Bd0Oe7O58mDPVzByA42jtSc3yjaEBZQP3SpTjwsjq1yIBGGPJlCFNC+eLE7to+k59F0ih8LEPzOjsPxuAB5lbR9pl9/IuNESuuA8oMD7HiR6aNsp9KbX5CKJK+i+TyPo49uWNLnX7FuxaYJ9OGPQcO6vFzXCkVKRnz5Xm5u4hWmUMEiPWh+w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966006)(36840700001)(2616005)(26005)(70586007)(47076005)(1076003)(81166007)(6666004)(86362001)(2906002)(19627235002)(36756003)(5660300002)(4326008)(336012)(426003)(7696005)(186003)(8936002)(70206006)(82310400003)(82740400003)(54906003)(36860700001)(8676002)(478600001)(6916009)(316002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2021 08:27:39.6535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7dba33-4fbe-45af-7f2c-08d95333e4cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6618 Content-Type: text/plain Fix several coding style issues raised by EccCheck. These issues are also present in previous versions of Acpi.h however seem to have been introduced prior to the CI check. - Error code: 7008 - complex types should be typedef-ed, Nested union in [EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICV]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICH]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR]. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++++++++++--------- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index c905db93fabb6faa553dd49a9fed886437dd4daf..abff78ea5d92afa4693689732d6cd147c16ad11c 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -502,18 +502,18 @@ typedef struct { UINT8 Type; UINT8 Length; UINT16 Reserved; - UINT32 CPUInterfaceNumber; + UINT32 CpuInterfaceNumber; UINT32 AcpiProcessorUid; UINT32 Flags; UINT32 ParkingProtocolVersion; UINT32 PerformanceInterruptGsiv; UINT64 ParkedAddress; UINT64 PhysicalBaseAddress; - UINT64 GICV; - UINT64 GICH; - UINT32 VGICMaintenanceInterrupt; - UINT64 GICRBaseAddress; - UINT64 MPIDR; + UINT64 GicV; + UINT64 GicH; + UINT32 VGicMaintenanceInterrupt; + UINT64 GicRBaseAddress; + UINT64 MpIdr; UINT8 ProcessorPowerEfficiencyClass; UINT8 Reserved2; UINT16 SpeOverflowInterrupt; @@ -788,22 +788,25 @@ typedef struct { } EFI_ACPI_6_4_DEVICE_HANDLE_PCI; /// -/// Generic Initiator Affinity Structure +/// Device Handle /// -typedef struct { - UINT8 Type; - UINT8 Length; - UINT8 Reserved1; - UINT8 DeviceHandleType; - UINT32 ProximityDomain; - - union { +typedef union { EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi; EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci; - } DeviceHandle; +} EFI_ACPI_6_4_DEVICE_HANDLE; - UINT32 Flags; - UINT8 Reserved2[4]; +/// +/// Generic Initiator Affinity Structure +/// +typedef struct { + UINT8 Type; + UINT8 Length; + UINT8 Reserved1; + UINT8 DeviceHandleType; + UINT32 ProximityDomain; + EFI_ACPI_6_4_DEVICE_HANDLE DeviceHandle; + UINT32 Flags; + UINT8 Reserved2[4]; } EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE; /// -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")