From: "Chris Jones" <christopher.jones@arm.com>
To: <devel@edk2.groups.io>
Cc: <Sami.Mujawar@arm.com>, <Akanksha.Jain2@arm.com>,
<Ben.Adderson@arm.com>, <michael.d.kinney@intel.com>,
<gaoliming@byosoft.com.cn>, <zhiguang.liu@intel.com>,
<Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: [PATCH RESEND v1 13/13] MdePkg: Fix broken coding style in Acpi64.h
Date: Fri, 30 Jul 2021 11:22:41 +0100 [thread overview]
Message-ID: <20210730102241.508-14-christopher.jones@arm.com> (raw)
In-Reply-To: <20210730102241.508-1-christopher.jones@arm.com>
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Fix several coding style issues raised by EccCheck. These issues are
also present in previous versions of Acpi.h however seem to have been
introduced prior to the CI check.
- Error code: 7008 - complex types should be typedef-ed, Nested union
in [EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE].
- Error code: 8005 - Variable name must contain lower case characters,
Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICV].
- Error code: 8005 - Variable name must contain lower case characters,
Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICH].
- Error code: 8005 - Variable name must contain lower case characters,
Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR].
Signed-off-by: Chris Jones <christopher.jones@arm.com>
---
MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++++++++++---------
1 file changed, 21 insertions(+), 18 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index c905db93fabb6faa553dd49a9fed886437dd4daf..abff78ea5d92afa4693689732d6cd147c16ad11c 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -502,18 +502,18 @@ typedef struct {
UINT8 Type;
UINT8 Length;
UINT16 Reserved;
- UINT32 CPUInterfaceNumber;
+ UINT32 CpuInterfaceNumber;
UINT32 AcpiProcessorUid;
UINT32 Flags;
UINT32 ParkingProtocolVersion;
UINT32 PerformanceInterruptGsiv;
UINT64 ParkedAddress;
UINT64 PhysicalBaseAddress;
- UINT64 GICV;
- UINT64 GICH;
- UINT32 VGICMaintenanceInterrupt;
- UINT64 GICRBaseAddress;
- UINT64 MPIDR;
+ UINT64 GicV;
+ UINT64 GicH;
+ UINT32 VGicMaintenanceInterrupt;
+ UINT64 GicRBaseAddress;
+ UINT64 MpIdr;
UINT8 ProcessorPowerEfficiencyClass;
UINT8 Reserved2;
UINT16 SpeOverflowInterrupt;
@@ -788,22 +788,25 @@ typedef struct {
} EFI_ACPI_6_4_DEVICE_HANDLE_PCI;
///
-/// Generic Initiator Affinity Structure
+/// Device Handle
///
-typedef struct {
- UINT8 Type;
- UINT8 Length;
- UINT8 Reserved1;
- UINT8 DeviceHandleType;
- UINT32 ProximityDomain;
-
- union {
+typedef union {
EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi;
EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci;
- } DeviceHandle;
+} EFI_ACPI_6_4_DEVICE_HANDLE;
- UINT32 Flags;
- UINT8 Reserved2[4];
+///
+/// Generic Initiator Affinity Structure
+///
+typedef struct {
+ UINT8 Type;
+ UINT8 Length;
+ UINT8 Reserved1;
+ UINT8 DeviceHandleType;
+ UINT32 ProximityDomain;
+ EFI_ACPI_6_4_DEVICE_HANDLE DeviceHandle;
+ UINT32 Flags;
+ UINT8 Reserved2[4];
} EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE;
///
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
next prev parent reply other threads:[~2021-07-30 10:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:22 [PATCH RESEND v1 00/13] Add ACPI 6.4 header file Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 01/13] MdePkg: " Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 02/13] MdePkg: Increment FADT version Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 04/13] MdePkg: Update PMTT to ACPI 6.4 Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 06/13] MdePkg: Remove DPPT table Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 08/13] MdePkg: Add 'Type 5' PCC structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 09/13] MdePkg: Add Multiprocessor Wakeup structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT) Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 11/13] MdePkg: Add Secure Access Components in the SDEV table Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 12/13] MdePkg: Add Cache ID to PPTT Chris Jones
2021-07-30 10:22 ` Chris Jones [this message]
2021-08-04 3:27 ` 回复: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730102241.508-14-christopher.jones@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox