From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.68]) by mx.groups.io with SMTP id smtpd.web11.22214.1627640587663300870 for ; Fri, 30 Jul 2021 03:23:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=C6AJo3f0; spf=pass (domain: arm.com, ip: 40.107.22.68, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKcLAX95yeF7KURbviOgoeEEzRSjPQ4xfC/UHhIYNjk=; b=C6AJo3f0l//Cfaoeu/IqwQJTiDGUDvlNs4RTsD13zSIBprRSfPag7XwKQEXjoihYbWaVf/RAmV0w0kCuR37HZJSkvYAM6unnJ4M6ZSIjA0jXO6WJjUFY6X1dPw8wY6wFYRPoEGRktvy8ELrQuVf4tcjBkYv8A/qWhy6HAdUFPgQ= Received: from DB6PR0501CA0022.eurprd05.prod.outlook.com (2603:10a6:4:8f::32) by AM5PR0802MB2593.eurprd08.prod.outlook.com (2603:10a6:203:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Fri, 30 Jul 2021 10:23:05 +0000 Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::88) by DB6PR0501CA0022.outlook.office365.com (2603:10a6:4:8f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 10:23:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 10:23:05 +0000 Received: ("Tessian outbound 31e6e3649d31:v100"); Fri, 30 Jul 2021 10:23:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b9ba6c84ae713967 X-CR-MTA-TID: 64aa7808 Received: from 58db51921aac.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 20FD3C4B-84CD-46C3-A64D-35603ABFF945.1; Fri, 30 Jul 2021 10:22:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 58db51921aac.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Jul 2021 10:22:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FzFtEWOJz9WSy+h8pU719QvJJzKKHKIY2z2oBuIduxHAt9C7oDNnyShRyyIxox5QJJ3T6UjvV7KhDaY5d4ssmbObRGGKjXsomcn1aoDUAicDWoZZm9kWgm7izh0wmFBhZgKF9vzzomPCeZv6Yy5zErjamzLQ3QbYAZ0Asxx0CEkQR3pKTMM4ENS0nbrxxw5ZePkDFXvKdXe1yaXWdN++Q6hvmj1DCtkmOA80NPMbZ9ZWl9hjnohaA9h8kBg1pYF6y2xeoGzUE7DTlbfX40lZ0xYf1Z5Av8GZ4NG1TxZCrgeZDzykXMsTNCOEya7tmzWTF0XeREojnRgdfWZWwx2sug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKcLAX95yeF7KURbviOgoeEEzRSjPQ4xfC/UHhIYNjk=; b=Nu3FFZittUxvl1N1ypUP8vWY0z7djE58F/Wp76ROboFP2M/yXP/Wz7/CGgD46BwLhmkLxMas5w+pBSnit69HcJOIsG68UBO+RlhlNHMnWCHn22FR7U/ocaKqyP4BBNYksCVpoxb9HvRUh3H1BDYXXaHnLnKjwhhK0vXH6ExE5KdI1s5AyTDdg9dTLc9jI1pscpdyytosYNSZkv8uXkG9XX5nLCw56axbs68dob1oDEqFpemVl2XgOmxigB+krhVJxW9N26nFDS8mjtZ++R6PjmNwP7+Djxo6pE7nYN/8JEpEoR9Bqe5RfRhyMDHpvQiISDL3bVAyRP5D1ZyeWMpFHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKcLAX95yeF7KURbviOgoeEEzRSjPQ4xfC/UHhIYNjk=; b=C6AJo3f0l//Cfaoeu/IqwQJTiDGUDvlNs4RTsD13zSIBprRSfPag7XwKQEXjoihYbWaVf/RAmV0w0kCuR37HZJSkvYAM6unnJ4M6ZSIjA0jXO6WJjUFY6X1dPw8wY6wFYRPoEGRktvy8ELrQuVf4tcjBkYv8A/qWhy6HAdUFPgQ= Received: from DB8PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:10:be::30) by VE1PR08MB4992.eurprd08.prod.outlook.com (2603:10a6:803:10f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Fri, 30 Jul 2021 10:22:56 +0000 Received: from DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::1e) by DB8PR03CA0017.outlook.office365.com (2603:10a6:10:be::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 10:22:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT016.mail.protection.outlook.com (10.152.20.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 10:22:56 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.14; Fri, 30 Jul 2021 10:22:47 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.14; Fri, 30 Jul 2021 10:22:47 +0000 Received: from e125153.arm.com (10.57.39.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 30 Jul 2021 10:22:46 +0000 From: "Chris Jones" To: CC: , , , , , , , Subject: [PATCH RESEND v1 13/13] MdePkg: Fix broken coding style in Acpi64.h Date: Fri, 30 Jul 2021 11:22:41 +0100 Message-ID: <20210730102241.508-14-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210730102241.508-1-christopher.jones@arm.com> References: <20210730102241.508-1-christopher.jones@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3dca0db-0e0e-4e64-6783-08d9534404b9 X-MS-TrafficTypeDiagnostic: VE1PR08MB4992:|AM5PR0802MB2593: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4502;OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y2QyRVB24crQqMNMj6YA4TUrQY1dWp1ml+nvlwvOs+GeqvbQhpZMKO3BPsUP5/5YXZz29iFz7tRe3bW98RRvpfLGnBsENYioWYV2SaylBZ3eP4nKby3/97a9hCUHGBtHktBZNfKay/LZsu1kVqGPbYDmb69SoLM2vMIMJ/pXP5yK8HQ6fhYbveshC6+nNQEnA0k3wIFGeODQW3NSbJetSyZK/jX3qBogRl9b3mzkEYE6mALtkhtlIU6Holy9la3OBVhqVnfVF3wTopmvJUxx7fLe9Ih38iSlkR3X5Fq6cbLVr8UbLUJ+Vfuh0zJH3oFAvPXHHbH+19zzzuQyBs15OTuLHlD78uTnUsA+6OwZ46WEfnt5jRtdtnlM4UYjOZi8jmIN7T0pFoE4RWzkthFuaez6KdZj9ZG6NW769gtBAtDzJvGDFOlq8dbiP7F2udrLoghi4IfUKMaGjhlSsv9ZIJQ74ZBxFOlpjiQoIGehogSJroec3oAs4bj0TYTebSUbBFfxlBuWHjCG675f4gRCi8dJqI8TfQ2iMZgpPFLBpJPWog+60Lm7Dx+hmlPrg9UISOwkC0TPw7O9niUg6WGc6ovohPs+xlC1IPQ0Vtq1wbo2uzpPvxfvQ+UBqdRdsRDqSOLvh0VQ71psrHi+yfb1vBVkpCRvjksE+/5ZAfulG17jt99p1sGvzEcmIcid1UOdQMkQYDw8oq/aSR0YR5I8IqK7RBptdstgqiofAW0/0H8ncFXGnxaCY3M9OI6i2vnI+HJMLHrG8DV3nfMNenoLuR2WHNcqna/LYPRFftpCFv/bcddIgur3WUpgYwGy0LLB X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(376002)(136003)(39850400004)(396003)(346002)(46966006)(36840700001)(82310400003)(356005)(5660300002)(47076005)(36756003)(2906002)(478600001)(1076003)(6916009)(336012)(4326008)(36860700001)(82740400003)(54906003)(86362001)(8936002)(83380400001)(70586007)(316002)(426003)(81166007)(6666004)(8676002)(186003)(26005)(19627235002)(70206006)(2616005)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4992 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5a3a2e47-d498-437d-257f-08d95343ffa5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NFcWzcaUdOewNUwooKsFShDgInArbDjOxO4GDaNp/lKlUf4qHOyDOBj2SLV0kodX+s9pOEYHi1DeYy0nJ9xnGqPXmvRyYrmH3zzYJZs59pFhOTzipej8dKOS7agCqSI7y6jOV2/43z+WC41ZyrxP6j0blSdDi9EdjbZUyCQ0T8I70fydbwuneaRDrY6SsB0NWbfcat7otbCPGf5N64udPFoqBlZNUdsAzYfzHGEGPlySrh8O38LqHh5kpuQGnCeW7jsAk2Y6KOWuAQstFIjgEGUWdNjVlDGAg5quIjIugJk769+uUFg+ixtosmv8Kjg5/rNPPVJf1vEj9DL/TUzJlYyyjmS6Tat4ZIlMFH7iTChRW/9kIQzZ/W0HaNM0Uo1aLof00uQkrrwNR48ICUhUs9vK7Qt6TgTzG1Zs2WPXSlhueDNDmIfAVwW1I7FIRv38HxyN9AFm6ymaIzmdaU3pqTWb9vaHbA0fMnmB3zXdC5l9IObX2EzllzrgqkArX+KxRwm+YtR72LpbBWb8/zZO2EWohEjKjP0TJJPkyNX1C9iW4qXOu6OSxTnc6ka4NI8ryH21PPh8dm2L3dUOivAm0S5ffIqTJR+7oMi8ULJJmvu92hkPYyXsvkFx5/ci4xcdHhXOOC77nci01K2bvNP+Tq70A679NCBdfwiQz2r6J/HXwAbPcYIDfF2cZJq/dpgSbO3nveQg6dmx/ziEIKcsoCVUSez36EjHhveetBAhdD1DDiDMUIO3A4BrVebbE/3Sx9wOKLkVXPa+/iEyds5KeD6veLO6mK9A/V24c71Q1xo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(396003)(39850400004)(36840700001)(46966006)(8676002)(478600001)(19627235002)(82740400003)(2906002)(70206006)(8936002)(70586007)(36860700001)(81166007)(82310400003)(36756003)(6916009)(336012)(7696005)(5660300002)(6666004)(47076005)(2616005)(4326008)(54906003)(316002)(26005)(426003)(1076003)(83380400001)(86362001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2021 10:23:05.1706 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3dca0db-0e0e-4e64-6783-08d9534404b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2593 Content-Type: text/plain Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Fix several coding style issues raised by EccCheck. These issues are also present in previous versions of Acpi.h however seem to have been introduced prior to the CI check. - Error code: 7008 - complex types should be typedef-ed, Nested union in [EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICV]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.GICH]. - Error code: 8005 - Variable name must contain lower case characters, Member variable [EFI_ACPI_6_4_GIC_STRUCTURE_.MPIDR]. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acpi64.h | 39 +++++++++++--------- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index c905db93fabb6faa553dd49a9fed886437dd4daf..abff78ea5d92afa4693689732d6cd147c16ad11c 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -502,18 +502,18 @@ typedef struct { UINT8 Type; UINT8 Length; UINT16 Reserved; - UINT32 CPUInterfaceNumber; + UINT32 CpuInterfaceNumber; UINT32 AcpiProcessorUid; UINT32 Flags; UINT32 ParkingProtocolVersion; UINT32 PerformanceInterruptGsiv; UINT64 ParkedAddress; UINT64 PhysicalBaseAddress; - UINT64 GICV; - UINT64 GICH; - UINT32 VGICMaintenanceInterrupt; - UINT64 GICRBaseAddress; - UINT64 MPIDR; + UINT64 GicV; + UINT64 GicH; + UINT32 VGicMaintenanceInterrupt; + UINT64 GicRBaseAddress; + UINT64 MpIdr; UINT8 ProcessorPowerEfficiencyClass; UINT8 Reserved2; UINT16 SpeOverflowInterrupt; @@ -788,22 +788,25 @@ typedef struct { } EFI_ACPI_6_4_DEVICE_HANDLE_PCI; /// -/// Generic Initiator Affinity Structure +/// Device Handle /// -typedef struct { - UINT8 Type; - UINT8 Length; - UINT8 Reserved1; - UINT8 DeviceHandleType; - UINT32 ProximityDomain; - - union { +typedef union { EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi; EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci; - } DeviceHandle; +} EFI_ACPI_6_4_DEVICE_HANDLE; - UINT32 Flags; - UINT8 Reserved2[4]; +/// +/// Generic Initiator Affinity Structure +/// +typedef struct { + UINT8 Type; + UINT8 Length; + UINT8 Reserved1; + UINT8 DeviceHandleType; + UINT32 ProximityDomain; + EFI_ACPI_6_4_DEVICE_HANDLE DeviceHandle; + UINT32 Flags; + UINT8 Reserved2[4]; } EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE; /// -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")