From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Nickle Wang <nickle.wang@hpe.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Andrew Fish <afish@apple.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt
Date: Tue, 3 Aug 2021 12:16:29 +0100 [thread overview]
Message-ID: <20210803111629.qmbuelmxhiehhnws@leviathan> (raw)
In-Reply-To: <20210720035358.22177-3-abner.chang@hpe.com>
On Tue, Jul 20, 2021 at 11:53:58 +0800, Abner Chang wrote:
> Add maintainer and reviewer to RedfishClinetPkg.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e9dda5c5ca..55068c9140 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -519,6 +519,11 @@ F: RedfishPkg/
> M: Abner Chang <abner.chang@hpe.com>
> R: Nickle Wang <nickle.wang@hpe.com>
>
> +RedfishClientPkg: Redfish Client related modules
My interpretation of the normal use of this field is that we can add a
comment if the entry applies only to a subset of a package.
This adds an entry for a whole new package, and as such should only
state the name of the package.
With everything from the : until the end of line dropped:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
/
Leif
> +F: RedfishClientPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Nickle Wang <nickle.wang@hpe.com>
> +
> SecurityPkg
> F: SecurityPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> --
> 2.17.1
>
>
>
>
>
>
next prev parent reply other threads:[~2021-08-03 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 3:53 [staging/edk2-redfish-client PATCH v2 0/2] RedfishClientPkg Abner Chang
2021-07-20 3:53 ` [staging/edk2-redfish-client PATCH v2 1/2] RedfishClientPkg: Initial commit Abner Chang
2021-07-20 6:21 ` Nickle Wang
2021-07-20 3:53 ` [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt Abner Chang
2021-08-03 11:16 ` Leif Lindholm [this message]
2021-08-03 14:03 ` [edk2-devel] " Abner Chang
2021-08-08 13:02 ` Nickle Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803111629.qmbuelmxhiehhnws@leviathan \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox