From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.groups.io with SMTP id smtpd.web10.8171.1628080435301092446 for ; Wed, 04 Aug 2021 05:33:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=lW0e6S2s; spf=pass (domain: nuviainc.com, ip: 209.85.221.52, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f52.google.com with SMTP id k4so2097529wrc.0 for ; Wed, 04 Aug 2021 05:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SAN9Hw/tHoEg8TRz1Xv62Es+PhltluJmGmd2t+7ux2U=; b=lW0e6S2sGp9ChyMnOrY6rnpku2e/K5PigcGH1mMwhaNkJsQ//YoAC+n5G3aD8puqsy NLFDBkWFwdiTlWLEi2cIkkdAtpShAdIjn/tw/pf/I1BcufVFxuTtS0nWZjiI5NO434wc Ik0zZbqgtAf37Sg1YqSWe87CwBRY+jh0En+357q6pVpsJeRPzUC5qyiJhs6SK4gtu8ec BqGq/wbz6C/Pftc37G/+IaK9BZ1z1eZXTdH/6SK549T5sBMv9ED3WcuNi5Ynq4l7e3CI d4eA4X/cuvenyX718lMfx+peq15/EQlnaAD+wfNijmfIPXjV/gC+IscysTZBZt5Lv6iJ Z1dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SAN9Hw/tHoEg8TRz1Xv62Es+PhltluJmGmd2t+7ux2U=; b=uhlMXaXGBGEezvlKu6bo5iDs4re/OoNFHq5frURZx/O7+QDm6zW5HXrYR1+nQCY2mP kQ7CiaG7xyPvWNxOjimuyaDeeVcqRh8hm3lym+D2FJihMnzDusj9tXRtLlxsZ6pNe1kH jEghG0uPSa9yMRYtX41GrHPQW/nWkegMhjYsq8DC2moow0jcepoaFXVP2S9eebwPF9OE dr7h32HmRVHk7bbLlnm+aaEdanEdq4E26M/FHHsbh0O3vz3k67ROhRXhj+rog8ia5+Aj xQXO1RFXRqQ4aY0gySH9r12VrFpn6Fgb+46NM5adECbMSW09VAe2ytyUXVs2+i0sDVq7 mCDw== X-Gm-Message-State: AOAM530euFda/y316p2+rHarWSRobYUNh4Bk/iO+0IsyYPRrNg8uoX7G hC6gRecEsqU3DVSuD3cOLaSXeA== X-Google-Smtp-Source: ABdhPJyH+UGCmG5Bb9LF2XZzc7yc0WtqMV9Tj1e6v4k4JeUMJ2ZdFUNHr0ZT/2BzshFCuo2W2Xw02w== X-Received: by 2002:adf:ef4d:: with SMTP id c13mr28596973wrp.281.1628080433819; Wed, 04 Aug 2021 05:33:53 -0700 (PDT) Return-Path: Received: from leviathan (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id v5sm2493839wrd.74.2021.08.04.05.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 05:33:53 -0700 (PDT) Date: Wed, 4 Aug 2021 13:33:51 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "Schaefer, Daniel" , Ard Biesheuvel , Anup Patel Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Message-ID: <20210804123351.2cgsmimicd53mf3r@leviathan> References: <20210519145822.4028-1-daniel.schaefer@hpe.com> <1680817ADB2092C8.5504@groups.io> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Gah, sorry. The original patch landed while I was distracted, and this reminder while I was on holiday. Apart from the typo in the subject line, I guess I'm OK with this. Acked-by: Leif Lindholm However, I have a feeling RISC-V will be updating EmbeddedPkg as frequently as ARM in the near future. Could we add one or both of you as maintainers? / Leif On Wed, Jul 14, 2021 at 14:05:53 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Leif and Ard, > Please help to review this and merge it if you have no comments on this patch. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Wednesday, May 19, 2021 11:30 PM > > To: Schaefer, Daniel ; devel@edk2.groups.io > > Cc: Leif Lindholm ; Ard Biesheuvel > > ; Anup Patel > > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp > > and strncpy to libfdt_env.h > > > > Reviewed-by: Abner Chang > > > > > -----Original Message----- > > > From: Schaefer, Daniel > > > Sent: Wednesday, May 19, 2021 10:58 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner (HPS SW/FW Technologist) ; > > Leif > > > Lindholm ; Ard Biesheuvel > > ; > > > Anup Patel > > > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to > > > libfdt_env.h > > > > > > OpenSBI has started using those in v0.9. See: > > > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c > > > > > > Cc: Abner Chang > > > Cc: Leif Lindholm > > > Cc: Ard Biesheuvel > > > Cc: Daniel Schaefer > > > Cc: Anup Patel > > > Signed-off-by: Daniel Schaefer > > > --- > > > EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/EmbeddedPkg/Include/libfdt_env.h > > > b/EmbeddedPkg/Include/libfdt_env.h > > > index 7feff52bc0fb..c35ac739703c 100644 > > > --- a/EmbeddedPkg/Include/libfdt_env.h > > > +++ b/EmbeddedPkg/Include/libfdt_env.h > > > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, size_t > > strsz ) { > > > return AsciiStrnLenS (str, strsz); > > > > > > } > > > > > > > > > > > > +static inline size_t strcmp (const char* str1, const char* str2) { > > > > > > + return AsciiStrCmp (str1, str2); > > > > > > +} > > > > > > + > > > > > > static inline size_t strncmp (const char* str1, const char* str2, size_t strsz ) > > { > > > > > > return AsciiStrnCmp (str1, str2, strsz); > > > > > > } > > > > > > > > > > > > +static inline size_t strncpy (char* dest, const char* source, size_t > > dest_max) { > > > > > > + return AsciiStrCpyS (dest, dest_max, source); > > > > > > +} > > > > > > + > > > > > > #endif /* _LIBFDT_ENV_H */ > > > > > > -- > > > 2.30.1 > > > > > > > > > > >