public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>
Subject: [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE
Date: Wed,  4 Aug 2021 16:43:13 -0400	[thread overview]
Message-ID: <20210804204314.7628-1-benjamin.doron00@gmail.com> (raw)

Fix assert when trying to retrieve the ACPI table.

However, now a second bug can be seen: SMM module also calls the DXE
module's notification, causing a second ACPI table to be installed with
colliding definitions.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
 Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf
index ae90238bedfa..bbd6eca87b0c 100644
--- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf
+++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf
@@ -7,5 +7,5 @@
 #
 ##
 
-  INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf
-  INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf
+  INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf
+  INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf
-- 
2.31.1


             reply	other threads:[~2021-08-04 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 20:43 Benjamin Doron [this message]
2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron
2021-08-17 17:59   ` Nate DeSimone
2021-08-17 18:03     ` Benjamin Doron
2021-08-17 21:49       ` [edk2-devel] " Nate DeSimone
2021-08-17 17:59 ` [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Nate DeSimone
2021-08-17 21:52 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804204314.7628-1-benjamin.doron00@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox