* [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE @ 2021-08-04 20:43 Benjamin Doron 2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Benjamin Doron @ 2021-08-04 20:43 UTC (permalink / raw) To: devel; +Cc: Eric Dong, Liming Gao Fix assert when trying to retrieve the ACPI table. However, now a second bug can be seen: SMM module also calls the DXE module's notification, causing a second ACPI table to be installed with colliding definitions. Cc: Eric Dong <eric.dong@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf index ae90238bedfa..bbd6eca87b0c 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf @@ -7,5 +7,5 @@ # ## - INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf - INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf + INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf + INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf -- 2.31.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE 2021-08-04 20:43 [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Benjamin Doron @ 2021-08-04 20:43 ` Benjamin Doron 2021-08-17 17:59 ` Nate DeSimone 2021-08-17 17:59 ` [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Nate DeSimone 2021-08-17 21:52 ` Nate DeSimone 2 siblings, 1 reply; 7+ messages in thread From: Benjamin Doron @ 2021-08-04 20:43 UTC (permalink / raw) To: devel; +Cc: Isaac Oram, Nate DeSimone, Liming Gao While I am unable to test IPMI changes, this patch should ensure that the ACPI table can be located. Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf index b5b37ddd9f5a..ba19a03baa8a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf @@ -7,7 +7,7 @@ # ## - INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf + INF RuleOverride = DRIVER_ACPITABLE OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf INF OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf INF OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf INF OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf -- 2.31.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE 2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron @ 2021-08-17 17:59 ` Nate DeSimone 2021-08-17 18:03 ` Benjamin Doron 0 siblings, 1 reply; 7+ messages in thread From: Nate DeSimone @ 2021-08-17 17:59 UTC (permalink / raw) To: Benjamin Doron, devel@edk2.groups.io; +Cc: Oram, Isaac W, Liming Gao Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> > -----Original Message----- > From: Benjamin Doron <benjamin.doron00@gmail.com> > Sent: Wednesday, August 4, 2021 1:43 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn> > Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is > DRIVER_ACPITABLE > > While I am unable to test IPMI changes, this patch should ensure that the > ACPI table can be located. > > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem > ory.fdf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > index b5b37ddd9f5a..ba19a03baa8a 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mo > +++ ry.fdf > @@ -7,7 +7,7 @@ > # ## - INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+ > INF RuleOverride = DRIVER_ACPITABLE > OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf INF > OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf INF > OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf INF > OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf-- > 2.31.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE 2021-08-17 17:59 ` Nate DeSimone @ 2021-08-17 18:03 ` Benjamin Doron 2021-08-17 21:49 ` [edk2-devel] " Nate DeSimone 0 siblings, 1 reply; 7+ messages in thread From: Benjamin Doron @ 2021-08-17 18:03 UTC (permalink / raw) To: Desimone, Nathaniel L; +Cc: devel, Oram, Isaac W, Liming Gao [-- Attachment #1: Type: text/plain, Size: 1964 bytes --] It appears that this fix was already committed as part of commit 2333ea4. How do I drop this patch? On Tue., Aug. 17, 2021, 1:59 p.m. Desimone, Nathaniel L, < nathaniel.l.desimone@intel.com> wrote: > Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> > > > -----Original Message----- > > From: Benjamin Doron <benjamin.doron00@gmail.com> > > Sent: Wednesday, August 4, 2021 1:43 PM > > To: devel@edk2.groups.io > > Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desimone@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn> > > Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is > > DRIVER_ACPITABLE > > > > While I am unable to test IPMI changes, this patch should ensure that the > > ACPI table can be located. > > > > Cc: Isaac Oram <isaac.w.oram@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> > > --- > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem > > ory.fdf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > > mory.fdf > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > > mory.fdf > > index b5b37ddd9f5a..ba19a03baa8a 100644 > > --- > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > > mory.fdf > > +++ > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > > mo > > +++ ry.fdf > > @@ -7,7 +7,7 @@ > > # ## - INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+ > > INF RuleOverride = DRIVER_ACPITABLE > > OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf INF > > OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf INF > > OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf INF > > OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf-- > > 2.31.1 > > [-- Attachment #2: Type: text/html, Size: 3379 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE 2021-08-17 18:03 ` Benjamin Doron @ 2021-08-17 21:49 ` Nate DeSimone 0 siblings, 0 replies; 7+ messages in thread From: Nate DeSimone @ 2021-08-17 21:49 UTC (permalink / raw) To: devel@edk2.groups.io, benjamin.doron00@gmail.com Cc: Oram, Isaac W, Liming Gao [-- Attachment #1: Type: text/plain, Size: 2775 bytes --] Hi Benjamin, I’ll just push the AcpiDebugFeaturePkg change. Thanks, Nate From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Tuesday, August 17, 2021 11:04 AM To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> Cc: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE It appears that this fix was already committed as part of commit 2333ea4. How do I drop this patch? On Tue., Aug. 17, 2021, 1:59 p.m. Desimone, Nathaniel L, <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>> wrote: Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>> > -----Original Message----- > From: Benjamin Doron <benjamin.doron00@gmail.com<mailto:benjamin.doron00@gmail.com>> > Sent: Wednesday, August 4, 2021 1:43 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Cc: Oram, Isaac W <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>>; Liming Gao > <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Subject: [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is > DRIVER_ACPITABLE > > While I am unable to test IPMI changes, this patch should ensure that the > ACPI table can be located. > > Cc: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com<mailto:nathaniel.l.desimone@intel.com>> > Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> > Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com<mailto:benjamin.doron00@gmail.com>> > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMem > ory.fdf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > index b5b37ddd9f5a..ba19a03baa8a 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mory.fdf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMe > mo > +++ ry.fdf > @@ -7,7 +7,7 @@ > # ## - INF OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf+ > INF RuleOverride = DRIVER_ACPITABLE > OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf INF > OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf INF > OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf INF > OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf-- > 2.31.1 [-- Attachment #2: Type: text/html, Size: 6124 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE 2021-08-04 20:43 [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Benjamin Doron 2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron @ 2021-08-17 17:59 ` Nate DeSimone 2021-08-17 21:52 ` Nate DeSimone 2 siblings, 0 replies; 7+ messages in thread From: Nate DeSimone @ 2021-08-17 17:59 UTC (permalink / raw) To: devel@edk2.groups.io, benjamin.doron00@gmail.com; +Cc: Dong, Eric, Liming Gao Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Benjamin Doron > Sent: Wednesday, August 4, 2021 1:43 PM > To: devel@edk2.groups.io > Cc: Dong, Eric <eric.dong@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn> > Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] > AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE > > Fix assert when trying to retrieve the ACPI table. > > However, now a second bug can be seen: SMM module also calls the DXE > module's notification, causing a second ACPI table to be installed with > colliding definitions. > > Cc: Eric Dong <eric.dong@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> > --- > Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf > | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd > f > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd > f > index ae90238bedfa..bbd6eca87b0c 100644 > --- > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd > f > +++ > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd > +++ f > @@ -7,5 +7,5 @@ > # ## - INF > Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf- > INF > Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+ > INF RuleOverride = DRIVER_ACPITABLE > Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+ > INF RuleOverride = DRIVER_ACPITABLE > Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf-- > 2.31.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#78678): https://edk2.groups.io/g/devel/message/78678 > Mute This Topic: https://groups.io/mt/84671506/1767664 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [nathaniel.l.desimone@intel.com] > -=-=-=-=-=-= > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE 2021-08-04 20:43 [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Benjamin Doron 2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron 2021-08-17 17:59 ` [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Nate DeSimone @ 2021-08-17 21:52 ` Nate DeSimone 2 siblings, 0 replies; 7+ messages in thread From: Nate DeSimone @ 2021-08-17 21:52 UTC (permalink / raw) To: devel@edk2.groups.io, benjamin.doron00@gmail.com; +Cc: Dong, Eric, Liming Gao Pushed: https://github.com/tianocore/edk2-platforms/commit/109380 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Wednesday, August 4, 2021 1:43 PM To: devel@edk2.groups.io Cc: Dong, Eric <eric.dong@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Fix assert when trying to retrieve the ACPI table. However, now a second bug can be seen: SMM module also calls the DXE module's notification, causing a second ACPI table to be installed with colliding definitions. Cc: Eric Dong <eric.dong@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> --- Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf index ae90238bedfa..bbd6eca87b0c 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fd +++ f @@ -7,5 +7,5 @@ # ## - INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf- INF Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf+ INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.inf+ INF RuleOverride = DRIVER_ACPITABLE Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.inf-- 2.31.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78678): https://edk2.groups.io/g/devel/message/78678 Mute This Topic: https://groups.io/mt/84671506/1767664 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nathaniel.l.desimone@intel.com] -=-=-=-=-=-= ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-17 21:52 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-08-04 20:43 [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Benjamin Doron 2021-08-04 20:43 ` [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE Benjamin Doron 2021-08-17 17:59 ` Nate DeSimone 2021-08-17 18:03 ` Benjamin Doron 2021-08-17 21:49 ` [edk2-devel] " Nate DeSimone 2021-08-17 17:59 ` [edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE Nate DeSimone 2021-08-17 21:52 ` Nate DeSimone
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox